Bug 129274

Summary: [mail/dovecot] Patch to dovecot.sh.in to facilitate multi-instance configurations
Product: Ports & Packages Reporter: Darren Pilgrim <phi>
Component: Individual Port(s)Assignee: Beech Rintoul <beech>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff
none
dovecot.sh.in.diff
none
dovecot.diff none

Description Darren Pilgrim 2008-11-29 08:00:16 UTC 
Dovecot requires multiple instances with separate configuration files if your configuration requires differing settings across multiple addresses/ports.  This isn't an uncommon requirement (i.e., a single server with secure services via more than one hostname requires more than one SSL certificate; however, Dovecot only permits one SSL certificate per configuration).  Making copies of the current RC script and editting them to run the extra configurations creates the following problems:

- Port upgrades will not stop all running Dovecot instances prior to the deinstall/reinstall phase;
- Port upgrades that change the RC script result in outdated/broken RC scripts;
- Port deinstalls result in orphaned files;

Fix: The provided patch to dovecot.sh.in introduces the dovecot_extra_configs variable which specifies the configuration files of additional instances.  When dovecot_extra_configs is defined, the script iterates over dovecot_config and each extra config, starting, stopping or restarting each in turn.  The single-instance behavior (dovecot_extra_configs is empty) is the same as the current script.

I received no response from the maintainer to my original inquiry on 2008-11-11 about the issue of controlling multiple Dovecot instances.

Patch attached with submission follows:
How-To-Repeat: n/a
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2008-11-29 08:00:28 UTC 
Maintainer of mail/dovecot,

Please note that PR ports/129274 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/129274

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2008-11-29 08:00:30 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Darren Pilgrim 2008-11-29 17:58:21 UTC 
I missed a %%PREFIX%% in the previous diff.  A revised diff is attached.
Comment 4 Beech Rintoul freebsd_committer freebsd_triage 2008-11-30 07:54:06 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->beech

I'll take it
Comment 5 Yarema 2008-12-10 23:00:27 UTC 
Sent alternate version of dovecot.sh.in to PR originator, Darren Pilgrim
<phi@evilphi.com>, for testing.  Please hold off committing this PR
until we work out the kinks.

-- 
Yarema
Comment 6 Beech Rintoul freebsd_committer freebsd_triage 2008-12-10 23:24:56 UTC 
State Changed
From-To: feedback->open

Maintainer response
Comment 7 Yarema 2008-12-13 05:45:15 UTC 
Please apply the following patch and close the PR.

The patch adds the ability for etc/rc.d/dovecot to start/stop/restart
multiple instances of dovecot by setting dovecot_config to a space
seperated list of configuration files.

-- 
Yarema
Comment 8 dfilter service freebsd_committer freebsd_triage 2008-12-13 06:56:45 UTC 
beech       2008-12-13 06:56:31 UTC

  FreeBSD ports repository

  Modified files:
    mail/dovecot         Makefile 
    mail/dovecot/files   dovecot.sh.in pkg-message.in 
  Log:
  - Patch to facilitate multi-instance configurations
  
  PR:             ports/129274
  Submitted by:   Darren Pilgrim <phi@evilphi.com>
  Approved by:    Yarema <yds@coolrat.org> (maintainer)
  
  Revision  Changes    Path
  1.97      +1 -0      ports/mail/dovecot/Makefile
  1.11      +24 -15    ports/mail/dovecot/files/dovecot.sh.in
  1.4       +13 -4     ports/mail/dovecot/files/pkg-message.in
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 9 Beech Rintoul freebsd_committer freebsd_triage 2008-12-13 07:00:29 UTC 
State Changed
From-To: open->closed

Committed (with maintainer changes), Thanks!