Bug 12934

Summary: procmail 3.13 port doesn't have "install-suid" make
Product: Ports & Packages Reporter: root <root>
Component: Individual Port(s)Assignee: Andrey A. Chernov <ache>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   

Description root 1999-08-02 23:30:01 UTC
When building the procmail port, after compilation finishes it mentions
"do a make install-suid for increased security and speed", yet
install-suid is not a valid target in the makefile.

Fix: 

add the "install-suid" target back into the makefile, or remove the notice
at the end of the build process so joe dumbuser doesn't come onto #freebsd
asking why he can't make install-suid with procmail. :)
How-To-Repeat: 
cd /usr/ports/mail/procmail && make
Comment 1 cpiazza freebsd_committer freebsd_triage 1999-08-02 23:56:35 UTC
Responsible Changed
From-To: freebsd-ports->ache

Over to maintainer 

Comment 2 cpiazza 1999-08-02 23:57:33 UTC
> >Description:
> 
> When building the procmail port, after compilation finishes it mentions
> "do a make install-suid for increased security and speed", yet
> install-suid is not a valid target in the makefile.
> 
> >Fix:
> 	
> add the "install-suid" target back into the makefile, or remove the notice
> at the end of the build process so joe dumbuser doesn't come onto #freebsd
> asking why he can't make install-suid with procmail. :)

Hi joe, ache,

The port automatically uses install-suid and install.man

from the Makefile:
INSTALL_TARGET= install-suid install.man

A solution might be to just add something like this (some minor
portlint changes included):

Index: procmail/Makefile
===================================================================
RCS file: /home/ncvs/ports/mail/procmail/Makefile,v
retrieving revision 1.26
diff -u -r1.26 Makefile
--- Makefile	1999/04/07 06:11:23	1.26
+++ Makefile	1999/08/02 22:55:37
@@ -7,14 +7,13 @@
 #
 
 DISTNAME=       procmail-3.13.1
-PKGNAME=        procmail-3.13.1
 CATEGORIES=	mail
 MASTER_SITES=	ftp://ftp.procmail.org/pub/procmail/ \
 		ftp://ftp.informatik.rwth-aachen.de/pub/packages/procmail/
-INSTALL_TARGET= install-suid install.man
 
 MAINTAINER=     ache@FreeBSD.ORG
 
+INSTALL_TARGET=	install-suid install.man
 # It asks for list af directories to do test for file locking
 # (defaults to /tmp and ".", so return should suffice in most cases).
 .if !defined(PACKAGE_BUILDING) # handled in patch-aa
@@ -22,5 +21,9 @@
 .endif
 MAN1=		procmail.1 formail.1 lockfile.1
 MAN5=		procmailex.5 procmailrc.5 procmailsc.5
+
+install-suid:
+	@${ECHO_MSG} "install-suid is not needed for this port.  Please run"
+	@${ECHO_MSG} "make install if you haven't already."
 
 .include <bsd.port.mk>

-Chris

-- 
cpiazza@home.net              cpiazza@FreeBSD.org
"It's better to be quotable than to be honest."
                                   --Tom Stoppard
Comment 3 brett 1999-08-03 00:51:11 UTC
Hi,

> >Synopsis:       procmail 3.13 port doesn't have "install-suid" make

> When building the procmail port, after compilation finishes it
> mentions "do a make install-suid for increased security and speed",
> yet install-suid is not a valid target in the makefile.

This information is provided by the procmail build, not something done by
the ports team.  If you examine the port Makefile you find that it uses
the install-suid install target.  Typing "make install-suid" for the
FreeBSD port Makefile will of course do nothing as it isn't valid for the
port Makefile.  There's nothing wrong w/ this port.

Brett
***********************************************************
Brett Taylor            brett@peloton.physics.montana.edu *
                        brett@daemonnews.org              *
							  *
			http://www.daemonnews.org/        *
***********************************************************
Comment 4 Steve Price freebsd_committer freebsd_triage 1999-12-29 07:32:18 UTC
State Changed
From-To: open->closed

Fixed, thanks!