Bug 129741

Summary: [patch] bsd.port.mk: support systems that have been built WITHOUT_INFO=yes (no makeinfo & install-info)
Product: Ports & Packages Reporter: John E. Hein <jhein>
Component: Ports FrameworkAssignee: Port Management Team <portmgr>
Status: Closed FIXED    
Severity: Affects Only Me CC: bapt, ports
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff
none
p
none
patch-3.diff
none
without-info.diff.txt none

Description John E. Hein 2008-12-18 19:10:03 UTC 
If world is built with WITHOUT_INFO=yes, then as of 7.x, it does not
install install-info and makeinfo, etc. (see the exclusion of the
texinfo subdir in gnu/usr.bin/Makefile).

But lots of ports and bsd.port.mk expect these tools to be there
unconditionally.

Worlds without these tools (think building for embedded boxes with
nanobsd, for example) break when building these ports.

The port I hit first that has this problem is libtool15 which has this...

CONFIGURE_ENV=	MAKEINFO="makeinfo --no-split"

See also at least these PRs for more:

ports/121296, ports/121717

Fix: Support WITHOUT_INFO (or detect missing install-info) in ports/Mk.
See patch below.

Ports can be fixed by keying on HAS_INFO (the preferred method, I
think) or changing hard-coded invocations of makeinfo and/or
install-info to the MAKEINFO and INSTALLINFO commands as defined
below in bsd.commands.mk.

Once this fix (or similar) is in place, we can generate a patch
for all the ports that have hard-coded references to the *info
utilities.
How-To-Repeat: 
make buildworld WITHOUT_INFO=yes
make installworld WITHOUT_INFO=yes

(or just manually move away /usr/bin/makeinfo and /usr/bin/install-info)

Then
cd ports/devel/libtool15
make && make install
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2008-12-18 23:38:30 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->portmgr

Over to maintainer(s).
Comment 2 John E. Hein 2008-12-19 17:55:09 UTC 
The previous patch for bsd.ports.mk had some stray debug in it.
That has been removed in a respin of the patch attached here...
Comment 3 Garrett Cooper 2008-12-20 03:53:00 UTC 
Are the ls + cat operations still required?
Also, can a more experienced porter please look at this and provide
some critiques?
Thanks!
-Garrett
Comment 4 John E. Hein 2008-12-21 08:55:42 UTC 
Garrett Cooper wrote at 19:53 -0800 on Dec 19, 2008:
 > Are the ls + cat operations still required?

If you mean the stray debug I inadvertently had in the first patch, then
no.  Look at the later patch in the PR.
http://www.freebsd.org/cgi/query-pr.cgi?pr=129741

 > Also, can a more experienced porter please look at this and provide
 > some critiques?

Thanks for taking a look.
Comment 5 John E. Hein 2009-01-22 17:20:43 UTC 
bsd.port.mk has been updated a bit since I submitted this PR.
The old patch still applies, but here's a refreshed one.
Nothing changed in the patch except some line numbers.
Comment 6 Pav Lucistnik freebsd_committer freebsd_triage 2009-03-10 15:12:40 UTC 
Fresh patch sitting in my ~ on freefall...

-- 
Pav Lucistnik <pav@oook.cz>
              <pav@FreeBSD.org>

Russians in the rear view mirror ...
are closer than they appear.
Comment 7 Garrett Cooper 2010-03-03 06:26:46 UTC 
    Getting back to this bug because I hit the same issue today with a
new system, is it possible to do a simpler diff like the following?
This patch wouldn't guard against users shooting themselves in the
foot, but for folks who have actually configured a system
appropriately so infopages aren't installed.
    I'm not changing the pkg-plist reference to INSTALL_INFO because
it may taint the system if one's cross-compiling.
    This patch shouldn't be committed because a lot of ports need to
be fixed with upstream patches (don't have knobs for --with-infopages,
and conditional variables aren't being set in configure.{ac,in} for
INSTALL_INFO, MAKEINFO, etc -- devel/libtool22 is a prime example). To
be consistent with autoconf INSTALL_INFO and MAKEINFO are being
spelled the way that they are.
Thanks!
-Garrett
Comment 8 Mark Linimon freebsd_committer freebsd_triage 2014-06-02 03:12:37 UTC 
Infrastructure PR.
Comment 9 Baptiste Daroussin freebsd_committer freebsd_triage 2014-06-05 16:01:42 UTC 
this is still needed, I to think having a USES=info might be a good idea
Comment 10 Baptiste Daroussin freebsd_committer freebsd_triage 2014-06-15 21:38:37 UTC 
Imho the best approach here is to make the ports depend on print/texinfo if base was built WITHOUT_INFO
Comment 11 commit-hook freebsd_committer freebsd_triage 2014-06-15 21:39:19 UTC 
A commit references this bug:

Author: bapt
Date: Sun Jun 15 21:38:30 UTC 2014
New revision: 357930
URL: http://svnweb.freebsd.org/changeset/ports/357930

Log:
  Make ports providing info files depending on print/textinfo if base has been built WITHOUT_INFO

  PR:		129741

Changes:
  head/Mk/bsd.port.mk