Bug 129909
| Summary: | sysutils/fusefs-kmod: does not build | ||
|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Dmitry Marakasov <amdmi3> |
| Component: | Individual Port(s) | Assignee: | Dmitry Marakasov <amdmi3> |
| Status: | Closed FIXED | ||
| Severity: | Affects Only Me | ||
| Priority: | Normal | ||
| Version: | Latest | ||
| Hardware: | Any | ||
| OS: | Any | ||
|
Description
Dmitry Marakasov
2008-12-24 14:10:01 UTC
Responsible Changed From-To: freebsd-ports-bugs->amdmi3 Submitter has GNATS access (via the GNATS Auto Assign Tool) Maintainer of sysutils/fusefs-kmod,
Please note that PR ports/129909 has just been submitted.
If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.
The full text of the PR can be found at:
http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/129909
--
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool) Hi, Dmitry
> In file included from fuse_main.c:5:
> config.h:2:24: error: opt_global.h: No such file or directory
> *** Error code 1
opt_global.h autogenerated in process of make buildkernel.
As a workaraund You need to build kernel first. Or remove
#ifdef KERNCONFDIR
#include <opt_global.h>
#endif
from fuse_module/config.h
--
Adios
* Alex Kozlov (spam@rm-rf.kiev.ua) wrote: > > In file included from fuse_main.c:5: > > config.h:2:24: error: opt_global.h: No such file or directory > > *** Error code 1 > opt_global.h autogenerated in process of make buildkernel. Seems like it only exists in /usr/obj/usr/src/sys/$KERNCONF/opt_global.h How can it be used reliably given that /usr/obj and real kernel may be completely different? Shouldn't that be fixed in the port? > Or remove > #ifdef KERNCONFDIR > #include <opt_global.h> > #endif > from fuse_module/config.h -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://www.amdmi3.ru On Tue, Dec 30, 2008 at 05:33:12PM +0300, Dmitry Marakasov wrote: > >> In file included from fuse_main.c:5: > >> config.h:2:24: error: opt_global.h: No such file or directory > >> *** Error code 1 >> opt_global.h autogenerated in process of make buildkernel. > Seems like it only exists in /usr/obj/usr/src/sys/$KERNCONF/opt_global.h > How can it be used reliably given that /usr/obj and real kernel may be > completely different? Shouldn't that be fixed in the port? I'm succesfuly using fuse_kmod for years after removing lines about opt_global.h from config.h. Still, more testing may be needed. >> Or remove >> #ifdef KERNCONFDIR >> #include <opt_global.h> >> #endif >> from fuse_module/config.h -- Adios * Alex Kozlov (spam@rm-rf.kiev.ua) wrote: > > Seems like it only exists in /usr/obj/usr/src/sys/$KERNCONF/opt_global.h > > How can it be used reliably given that /usr/obj and real kernel may be > > completely different? Shouldn't that be fixed in the port? > I'm succesfuly using fuse_kmod for years after removing lines about > opt_global.h from config.h. Still, more testing may be needed. Seems like the problem is that fuse-kmod's Makefile decides that I have compiled kernel because there's KERNCONF set in my /etc/make.conf. Judging from code, the only thing it uses from opt_global.h is INVARIANTS, but changes depending on whether it's defiend doesn't really seem to affect anything and be useable in the port. Thus, I suggest to add .undef KERNCONF to files/patch-fuse_module__Makefile In case you're against it, there's a patch (see below) that only solves my problem, but for the sake of determinacy and predictable behaviour, I'd prefer to under KERNCONF uncnditionally. What do you say? --- fuse.patch begins here --- Index: files/patch-fuse_module__Makefile =================================================================== RCS file: /home/amdmi3/projects/freebsd/FreeBSD.cvs/ports/sysutils/fusefs-kmod/files/patch-fuse_module__Makefile,v retrieving revision 1.1 diff -u -r1.1 patch-fuse_module__Makefile --- files/patch-fuse_module__Makefile 3 Apr 2008 02:16:54 -0000 1.1 +++ files/patch-fuse_module__Makefile 13 Jan 2009 20:15:46 -0000 @@ -1,12 +1,17 @@ ---- fuse_module/Makefile.orig 2008-03-30 21:36:21.000000000 +0800 -+++ fuse_module/Makefile 2008-03-30 21:39:23.000000000 +0800 -@@ -22,7 +22,8 @@ +--- fuse_module/Makefile.orig 2008-02-05 08:25:57.000000000 +0300 ++++ fuse_module/Makefile 2009-01-13 23:15:46.000000000 +0300 +@@ -22,7 +22,13 @@ .if defined(KERNCONF) KERNCONF1!= echo ${KERNCONF} | sed -e 's/ .*//g' -KERNCONFDIR= /usr/obj/usr/src/sys/${KERNCONF1} +KRNLOBJDIR!= make -C /usr/src -f /usr/src/Makefile.inc1 -V KRNLOBJDIR +KERNCONFDIR= ${KRNLOBJDIR}/${KERNCONF1} ++.endif ++ ++.if defined(KERNCONFDIR) && !exists(${KERNCONFDIR}/opt_global.h) ++.undef KERNCONF ++.undef KERNCONFDIR .endif .if defined(KERNCONFDIR) --- fuse.patch ends here --- -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://www.amdmi3.ru On Tue, Jan 13, 2009 at 11:22:51PM +0300, Dmitry Marakasov wrote:
> >> Seems like it only exists in /usr/obj/usr/src/sys/$KERNCONF/opt_global.h
> >> How can it be used reliably given that /usr/obj and real kernel may be
> >> completely different? Shouldn't that be fixed in the port?
>> I'm succesfuly using fuse_kmod for years after removing lines about
>> opt_global.h from config.h. Still, more testing may be needed.
> Seems like the problem is that fuse-kmod's Makefile decides that I
> have compiled kernel because there's KERNCONF set in my /etc/make.conf.
> Judging from code, the only thing it uses from opt_global.h is
> INVARIANTS, but changes depending on whether it's defiend doesn't really
> seem to affect anything and be useable in the port.
> Thus, I suggest to add .undef KERNCONF to files/patch-fuse_module__Makefile
I don't mind.
--
Adios
State Changed From-To: feedback->closed Committed. Thanks! amdmi3 2009-01-13 22:19:14 UTC
FreeBSD ports repository
Modified files:
sysutils/fusefs-kmod/files patch-fuse_module__Makefile
Log:
- Add .undef KERNCONF to fusefs-kmod's Makefile, so KERNCONF defined in /etc/make.conf don't break the build in some cases
PR: 129909
Submitted by: myself
Approved by: Alex Kozlov <spam at rm-rf dot kiev dot ua> (maintainer)
Revision Changes Path
1.2 +9 -3 ports/sysutils/fusefs-kmod/files/patch-fuse_module__Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
|