Bug 130070

Summary: change wording of 'submit a PR' page
Product: Documentation Reporter: Michael W Lucas <mwlucas>
Component: Books & ArticlesAssignee: freebsd-doc (Nobody) <doc>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   

Description Michael W Lucas 2008-12-31 00:00:18 UTC 
I just submitted a ports PR with a patch attached.  The Web interface offers the following instructions for uploading a patch.

And/or patch file (100KB max, .txt extension recommended): 

The word "recommendation" implies that it's not strictly required.  I ignored the recommendation, and listed my patch as it existed.  (I knew durn well that the committer would have to rename it to the name I gave it, anyway.)

The submission was rejected because the patch did not have the extension .txt.  I do not object to this behavior, but I would suggest that the word "recommended" be changed to "required."

Of course, I stumbled over this less than a month after (willingly) relenquishing my doc commit bit...  figures.

Fix: 

Change "recommended" to "required," perhaps listing any other types that the script will take.
How-To-Repeat: Go to http://www.freebsd.org/send-pr.html.  Try to submit a PR with a patch with a name such as 

patch-bin_flow-rptfmt

While this (or something much like it) is how the file name will appear when committed, send-pr.html rejected it.

Had it said "required," I would have changed the file name before even trying to submit.
Comment 1 dfilter service freebsd_committer freebsd_triage 2008-12-31 08:03:33 UTC 
remko       2008-12-31 08:03:19 UTC

  FreeBSD doc repository

  Modified files:
    en                   send-pr.sgml 
  Log:
  Tell that a shar file or .txt file is required for attaching a diff.
  
  PR:             130070
  Submitted by:   mwlucas
  
  Revision  Changes    Path
  1.61      +3 -3      www/en/send-pr.sgml
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 2 Remko Lodder freebsd_committer freebsd_triage 2008-12-31 08:04:08 UTC 
State Changed
From-To: open->closed

Committed. Thanks!