Bug 13046

Comment 1 Brian Somers 1999-08-10 00:50:06 UTC

Responsible Changed
From-To: freebsd-bugs->brian

Ppp's mine. 

> ---------- Forwarded message ----------
> Date: Mon, 9 Aug 1999 13:00:03 -0700 (PDT)
> From: gnats-admin@FreeBSD.org
> To: seva@sevasoft.alex-ua.com
> Subject: Re: bin/13046: [PATCH] ppp don't close session on modem hangup
> 
> Thank you very much for your problem report.
> It has the internal identification `bin/13046'.
> The individual assigned to look at your
> report is: freebsd-bugs. 
> 
> >Category:       bin
> >Responsible:    freebsd-bugs
> >Synopsis:       [PATCH] ppp don't close session on modem hangup
> >Arrival-Date:   Mon Aug  9 13:00:03 PDT 1999

I think there's a problem here.  We don't want to end up blocking 
waiting for carrier on this line.  Ppp turns CLOCAL on so that it can 
control non-modem ttys and then does frequent TIOCMGETs.

Does this really make things work in your environment ?  Have you 
tried enabling debug logging to see what ppp thinks is happening with 
carrier ?

Cheers.
-- 
Brian <brian@Awfulhak.org>                        <brian@FreeBSD.org>
      <http://www.Awfulhak.org>                   <brian@OpenBSD.org>
Don't _EVER_ lose your sense of humour !          <brian@FreeBSD.org.uk>

On Tue, 10 Aug 1999, Brian Somers wrote:

> > ---------- Forwarded message ----------
> > Date: Mon, 9 Aug 1999 13:00:03 -0700 (PDT)
> > From: gnats-admin@FreeBSD.org
> > To: seva@sevasoft.alex-ua.com
> > Subject: Re: bin/13046: [PATCH] ppp don't close session on modem hangup
> > 
> > Thank you very much for your problem report.
> > It has the internal identification `bin/13046'.
> > The individual assigned to look at your
> > report is: freebsd-bugs. 
> > 
> > >Category:       bin
> > >Responsible:    freebsd-bugs
> > >Synopsis:       [PATCH] ppp don't close session on modem hangup
> > >Arrival-Date:   Mon Aug  9 13:00:03 PDT 1999
> 
> I think there's a problem here.  We don't want to end up blocking 
> waiting for carrier on this line.  Ppp turns CLOCAL on so that it can 
> control non-modem ttys and then does frequent TIOCMGETs.

Sorry, forgot to mention. I have a semi-callback connection, so ppp
working in -direct mode, and tty_Timeout doesn't gets called at all.

> Does this really make things work in your environment ?  Have you 
> tried enabling debug logging to see what ppp thinks is happening with 
> carrier ?

There are nothing about carrier in logs. Instrumented tty_Timeout (with
log_Printf on start) does not called. 

With my patch it works. Possibly patch need to be changed for explicit
PHYS_DIRECT case and not for !PHYS_DEDICATED

Hi,

This should now be fixed in the latest ppp archive on my web site.  
Would you care to verify ?

Thanks.

> On Tue, 10 Aug 1999, Brian Somers wrote:
> 
> > > ---------- Forwarded message ----------
> > > Date: Mon, 9 Aug 1999 13:00:03 -0700 (PDT)
> > > From: gnats-admin@FreeBSD.org
> > > To: seva@sevasoft.alex-ua.com
> > > Subject: Re: bin/13046: [PATCH] ppp don't close session on modem hangup
> > > 
> > > Thank you very much for your problem report.
> > > It has the internal identification `bin/13046'.
> > > The individual assigned to look at your
> > > report is: freebsd-bugs. 
> > > 
> > > >Category:       bin
> > > >Responsible:    freebsd-bugs
> > > >Synopsis:       [PATCH] ppp don't close session on modem hangup
> > > >Arrival-Date:   Mon Aug  9 13:00:03 PDT 1999
> > 
> > I think there's a problem here.  We don't want to end up blocking 
> > waiting for carrier on this line.  Ppp turns CLOCAL on so that it can 
> > control non-modem ttys and then does frequent TIOCMGETs.
> 
> Sorry, forgot to mention. I have a semi-callback connection, so ppp
> working in -direct mode, and tty_Timeout doesn't gets called at all.
> 
> > Does this really make things work in your environment ?  Have you 
> > tried enabling debug logging to see what ppp thinks is happening with 
> > carrier ?
> 
> There are nothing about carrier in logs. Instrumented tty_Timeout (with
> log_Printf on start) does not called. 
> 
> With my patch it works. Possibly patch need to be changed for explicit
> PHYS_DIRECT case and not for !PHYS_DEDICATED
> 
> 

-- 
Brian <brian@Awfulhak.org>                        <brian@FreeBSD.org>
      <http://www.Awfulhak.org>                   <brian@OpenBSD.org>
Don't _EVER_ lose your sense of humour !          <brian@FreeBSD.org.uk>

Comment 5 Brian Somers 1999-10-16 11:14:08 UTC

State Changed
From-To: open->closed

Fixed in -current.  Will MFC soon. 

On Sat, 16 Oct 1999, Brian Somers wrote:

> Hi,
> 
> This should now be fixed in the latest ppp archive on my web site.  
> Would you care to verify ?

It works now, thanks.