Bug 130657
| Summary: | [ip6] [patch] ipv6 class option | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Base System | Reporter: | Alfred Perlstein <alfred> | ||||
| Component: | kern | Assignee: | Tom Jones <thj> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | rscheff, thj, tuexen | ||||
| Priority: | Normal | Flags: | tuexen:
mfc-stable12+
|
||||
| Version: | 7.1-PRERELEASE | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Responsible Changed From-To: freebsd-bugs->bz Bjoern asked for this bug. adding mailing list discussion to audit trail. ----- Forwarded message from Bruce Simpson <bms@incunabulum.net> ----- From: Bruce Simpson <bms@incunabulum.net> To: Alfred Perlstein <alfred@freebsd.org> Cc: net@freebsd.org Subject: Re: ipv6 bugfix, need review. Date: Wed, 24 Dec 2008 17:43:43 +0000 Message-ID: <495274CF.3030703@incunabulum.net> User-Agent: Thunderbird 2.0.0.18 (X11/20081204) Sender: owner-freebsd-net@freebsd.org Alfred Perlstein wrote: > The traffic class byte is set to 0x00000000 in the header of some > BGP packets sent between interfaces that have IPv6 addresses, > instead of the correct setting 0xc0 (INTERNETCONTROL). Content free argument: Feels right. I had to commit a man page diff to document the TCLASS socket option. If this isn't happening for TCP sockets, then that certainly needs dealing with. _______________________________________________ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" ----- End forwarded message ----- -- - Alfred Perlstein adding mailing list discussion to audit trail. ----- Forwarded message from "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> ----- From: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> To: Alfred Perlstein <alfred@freebsd.org> cc: net@freebsd.org Subject: Re: ipv6 bugfix, need review. Date: Wed, 24 Dec 2008 23:13:17 +0000 (UTC) Message-ID: <20081224230540.C97918@maildrop.int.zabbadoz.net> On Mon, 22 Dec 2008, Alfred Perlstein wrote: Hi, >Fix is small and attached. One thing I am wondering, do we >need to check "if (inp)" ? I don't think so. I am not that concerned about the inp at the moment; there are a few other things: 1 FreeBSD to my knowledge has neither IPV6_GET_CLASS nor IPV6_SET_CLASS nor IPV6_CLASS_MASK 2 To the best I can see this currently ignores the upper 4 TC bits that go with the `version field' ("vcf"), so it's a hack good enough for now, but not a proper fix? 3 I am assuming that we'd need to fix at least one more place. Tha said I planned to look at the in6p_flowinfo (inp_flow) field in the not too distant future anyway; I should perhaps combine this looking into the entire TC thing as well. -- Bjoern A. Zeeb The greatest risk is not taking one. ----- End forwarded message ----- -- - Alfred Perlstein Responsible Changed From-To: bz->gnn I shall not use bugzilla (at least until we will have a CLI). For bugs matching the following criteria: Status: In Progress Changed: (is less than) 2014-06-01 Reset to default assignee and clear in-progress tags. Mail being skipped Patch https://reviews.freebsd.org/D25909 / Commit rS364089 has effectively addressed this reported issue. TCP syncache will retain the ttl and tos (tclass) values and restore them once the session is properly established. MFCed to stable/12 in base r365563, so the fix will be in 12.2 and higher. |
This is in a private version of FreeBSD we have, but the code seems to be somewhat close to what we have in FreeBSD. Fix: Index: bsd/sys/netinet/tcp_syncache.c =================================================================== RCS file: /cvs/junos-2008/bsd/sys/netinet/tcp_syncache.c,v retrieving revision 1.24 How-To-Repeat: Source inspection, see email audit trail for more information.