Bug 131059

Summary: [tinybsd] [patch] tinybsd MFSROOT option suggests YES/NO but only accepts yes/no
Product: Base System Reporter: Brock Williams <brock>
Component: miscAssignee: freebsd-bugs (Nobody) <bugs>
Status: Closed FIXED    
Severity: Affects Only Me CC: gonzo
Priority: Normal    
Version: 7.1-RELEASE   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Brock Williams 2009-01-27 20:20:02 UTC 
The tinybsd tool when prompting for config settings prompts for the MFSROOT option and suggests the options are YES/NO.  If you say YES, though, it ignores your desire to have an MFSROOT as it checks the value = 'yes'.

Fix: patch attached to change (YES/NO) to (yes/no)

Patch attached with submission follows:
How-To-Repeat: Run tinybsd script and answer YES to the "Use an MFSROOT? (YES/NO)" prompt
Comment 1 Eitan Adler freebsd_committer freebsd_triage 2017-12-31 07:58:24 UTC 
For bugs matching the following criteria:

Status: In Progress Changed: (is less than) 2014-06-01

Reset to default assignee and clear in-progress tags.

Mail being skipped
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-01-24 06:35:27 UTC 
A commit references this bug:

Author: gonzo
Date: Thu Jan 24 06:34:30 UTC 2019
New revision: 343391
URL: https://svnweb.freebsd.org/changeset/base/343391

Log:
  Fix prompt for MFSROOT in tinybsd

  tinybsd offers two choices when prompting user for MFSROOT: 'YES'
  and 'NO'. Script logic only handles 'yes'. Change offered values
  to lower case.

  PR:		131059
  Submitted by:	Brock Williams <brock@cotcomsol.com>
  MFC after:	1 week

Changes:
  head/tools/tools/tinybsd/tinybsd
Comment 3 Oleksandr Tymoshenko freebsd_committer freebsd_triage 2019-01-24 09:15:47 UTC 
Fix has been committed. I'll handle the MFC separately.
Comment 4 commit-hook freebsd_committer freebsd_triage 2019-02-04 10:25:09 UTC 
A commit references this bug:

Author: gonzo
Date: Mon Feb  4 10:24:17 UTC 2019
New revision: 343739
URL: https://svnweb.freebsd.org/changeset/base/343739

Log:
  MFC r343391:

  Fix prompt for MFSROOT in tinybsd

  tinybsd offers two choices when prompting user for MFSROOT: 'YES'
  and 'NO'. Script logic only handles 'yes'. Change offered values
  to lower case.

  PR:		131059
  Submitted by:	Brock Williams <brock@cotcomsol.com>

Changes:
_U  stable/12/
  stable/12/tools/tools/tinybsd/tinybsd