Bug 131925

Summary:	Broken Port audio/aureal-kmod
Product:	Ports & Packages	Reporter:	Tom Mende <tmende>
Component:	Individual Port(s)	Assignee:	Rong-En Fan <rafan>
Status:	Closed FIXED
Severity:	Affects Only Me
Priority:	Normal
Version:	Latest
Hardware:	Any
OS:	Any

Description Tom Mende 2009-02-21 03:50:00 UTC

port appears to be broken - last worked for me on FreeBSD 6.2 - used a clean install from CDs to go the FreeBSD 7.0 - been using freebsd-update since.

#/usr/ports/audio/aureal-kmod>make install clean
=> au88x0-1.5_4.tar.gz doesn't seem to exist in /usr/ports/distfiles/.
=> Attempting to fetch from http://www.matey.org/au88x0/.
au88x0-1.5_4.tar.gz                           100% of  212 kB  136 kBps
===>  Extracting for aureal-kmod-1.5_6
=> MD5 Checksum OK for au88x0-1.5_4.tar.gz.
=> SHA256 Checksum OK for au88x0-1.5_4.tar.gz.
===>  Patching for aureal-kmod-1.5_6
===>  Applying FreeBSD patches for aureal-kmod-1.5_6
1 out of 6 hunks failed--saving rejects to au88x0.c.rej
=> Patch patch-au88x0.c failed to apply cleanly.
=> Patch(es) patch-10_Makefile patch-20_Makefile patch-30_Makefile patch-Makefile patch-Makefile.inc applied cleanly.
*** Error code 1

Stop in /usr/ports/audio/aureal-kmod.
#/usr/ports/audio/aureal-kmod>

..contents of au88x0.c.rej

***************
*** 29,46 ****
   */
  
  #include <dev/sound/pcm/sound.h>
- #include <dev/sound/pci/au88x0.h>
  
- #include <pci/pcireg.h>
- #include <pci/pcivar.h>
  #include <sys/queue.h>
  
  SND_DECLARE_FILE("$FreeBSD: ports/audio/aureal-kmod/files/patch-au88x0.c,v 1.9 2009/01/07 01:38:11 rafan Exp $");
  
- #if __FreeBSD_version < 500033
- #error Cannot be compiled on older 5.0-CURRENT and 4.x systems
- #endif
- 
  #include "mixer_if.h"
  
  MALLOC_DEFINE(M_PCMAUCORE, "PCMaucore", "Aureal Vortex 88x0 core");
--- 29,43 ----
   */
  
  #include <dev/sound/pcm/sound.h>
+ #include "au88x0.h"
+ #include <sys/systm.h>
  
+ #include <dev/pci/pcireg.h>
+ #include <dev/pci/pcivar.h>
  #include <sys/queue.h>
  
  SND_DECLARE_FILE("$FreeBSD: ports/audio/aureal-kmod/files/patch-au88x0.c,v 1.9 2009/01/07 01:38:11 rafan Exp $");
  
  #include "mixer_if.h"
  
  MALLOC_DEFINE(M_PCMAUCORE, "PCMaucore", "Aureal Vortex 88x0 core");

***Portsnap fetch update done this morning, freebsd-update fetch && install done this morning, GENERIC kernel (with unused devices commented out) rebuilt and reinstalled this morning.

How-To-Repeat: #/usr/ports/audio/aureal-kmod>make or make install or make install clean

Comment 1 Edwin Groothuis freebsd_committer

2009-02-21 03:50:10 UTC

Maintainer of audio/aureal-kmod,

Please note that PR ports/131925 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/131925

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org

Comment 2 Edwin Groothuis freebsd_committer

2009-02-21 03:50:12 UTC

State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)

Comment 3 c.kworr 2009-02-21 07:20:03 UTC

Ew.

Last time rafan changed the patch he added some code with a $FreeBSD$ 
knob, which is autoexpanded. This ruins the patch. The correct way to 
fix this is to set SCM props on patch-au88x0.c so the knobs would not be 
autoexpanded.

CC'ing rafan in case he might mix it...

-- 
Sphinx of black quartz judge my vow.

Comment 4 Rong-En Fan freebsd_committer

2009-02-21 08:10:42 UTC

Responsible Changed
From-To: freebsd-ports-bugs->rafan

I'll take it.

Comment 5 dfilter service freebsd_committer

2009-02-21 08:18:29 UTC

rafan       2009-02-21 08:18:20 UTC

  FreeBSD ports repository

  Modified files:
    audio/aureal-kmod/files patch-au88x0.c 
  Log:
  - Remove the portion that contains a $FreeBSD$ which is a keyword to our CVS
    to avoid broken patch file. As it seems no way to tell CVS not to expand
    the keywords after add, it's better not to contain $FreeBSD$ in the
    patch file.
  
  PR:             ports/131925
  Reported by:    Tom Mende <tmende at optusnet.com.au>
  Approved by:    maintainer
  
  Revision  Changes    Path
  1.10      +7 -26     ports/audio/aureal-kmod/files/patch-au88x0.c
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"

Comment 6 Rong-En Fan freebsd_committer

2009-02-21 08:18:35 UTC

State Changed
From-To: feedback->closed

Fixed in ports. Thanks for the report!