Bug 13196

Summary: [BTX] page in BTX has problem(quit key)
Product: Base System Reporter: sanpei
Component: kernAssignee: freebsd-bugs (Nobody) <bugs>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Unspecified   
Hardware: Any   
OS: Any   

Description sanpei 1999-08-17 11:10:01 UTC
I installed FreeBSD-4.0-19990816-CURRENT. 

But BTX loader has problem.  When I show help message as below:

disk1s1a:> help set tunables
<<snip>>
--more--  <space> page down <enter> line down <q> quit 

If I enter <q>, but I can't quit help mode.
Another operations, <space> and <enter> are fine.
Comment 1 sanpei 1999-11-30 10:28:28 UTC
  I think this problem(can't quit help mode) was only appear with
``help set tunables'', because this help is larger than screen
height.

  I created quick hack code. Your comments are welcome :-)

--- sys/boot/common/commands.c.org	Tue Nov 30 18:37:05 1999
+++ sys/boot/common/commands.c	Tue Nov 30 18:38:43 1999
@@ -176,8 +176,10 @@
 		((subtopic != NULL) && (s != NULL) && !strcmp(subtopic, s))) {
 		/* exact match, print text */
 		while((fgetstr(buf, 80, hfd) >= 0) && (buf[0] != '#')) {
-		    pager_output(buf);
-		    pager_output("\n");
+		    if (pager_output(buf))
+			break;
+		    if (pager_output("\n"))
+			break;
 		}
 	    } else if ((subtopic == NULL) && (s != NULL)) {
 		/* topic match, list subtopics */
Comment 2 msmith freebsd_committer freebsd_triage 1999-12-28 07:19:37 UTC
State Changed
From-To: open->closed

Suggested fix is good, committed.