Bug 132270

Summary: x11-servers/xorg-server can't load usb keyboards via config/hal
Product: Ports & Packages Reporter: Jose M Rodriguez <josemi>
Component: Individual Port(s)Assignee: freebsd-x11 (Nobody) <x11>
Status: Closed FIXED    
Severity: Affects Only Me CC: gnome
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
pr.patch none

Description Jose M Rodriguez 2009-03-03 01:00:09 UTC 
	xorg-server can't load usb keyboards via config/hal.
	It fails at device open, as hal have a device key.

	This is not noticeable in an stock system.
	The presence of an atkbd without a hal device key
	makes xorg-server load the module.

	Seems that xorg-server keyboard is not device oriented
	and hal must not have a device key for usb keyboard

Fix: Don't add a device key for usb keyborads, as is done
	for at ones (PS/2)

	- hf_device_set_input(device, "keyboard", devname);
	+ hf_device_set_input(device, "keyboard", NULL);

How-To-Repeat: 	You can see this on the Xorg logs.
	In systems without kernel atkbd device, xorg-server
	can't get a functional keyboad
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2009-03-03 02:57:19 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->freebsd-x11

Over to maintainer(s). 

Date: Mon, 02 Mar 2009 21:17:07 -0600
Comment 2 dfilter service freebsd_committer freebsd_triage 2009-03-03 03:30:29 UTC 
rnoland     2009-03-03 03:30:20 UTC

  FreeBSD ports repository

  Modified files:
    sysutils/hal         Makefile 
    sysutils/hal/files   patch-hald_freebsd_hf-usb.c 
                         patch-hald_freebsd_hf-usb2.c 
  Log:
  Set the device node to NULL for usb keyboards.  The xorg keyboard
  driver has the ability to open character devices, but in our case
  syscons always owns the devices.  This should allow usb only
  setups as well as help people who are setting xorg input options
  on usb devices.
  
  PR:             132270
  Submitted by:   Jose M Rodriguez <josemi@freebsd.jazztel.es>
  Approved by:    marcus
  
  Revision  Changes    Path
  1.51      +1 -1      ports/sysutils/hal/Makefile
  1.6       +15 -6     ports/sysutils/hal/files/patch-hald_freebsd_hf-usb.c
  1.2       +3 -3      ports/sysutils/hal/files/patch-hald_freebsd_hf-usb2.c
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Robert Noland freebsd_committer freebsd_triage 2009-03-03 03:30:53 UTC 
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!