Bug 132548

Summary:	[newusb] sysutils/apcupsd compile broken with USB support
Product:	Ports & Packages	Reporter:	Ben Kelly <ben>
Component:	Individual Port(s)	Assignee:	Ion-Mihai "IOnut" Tetcu <itetcu>
Status:	Closed FIXED
Severity:	Affects Only Me
Priority:	Normal
Version:	Latest
Hardware:	Any
OS:	Any

Description Ben Kelly 2009-03-11 15:40:01 UTC

Building apcupsd on a recent CURRENT using the new USB stack results in the following error:


  CXX   src/drivers/usb/bsd/bsd-usb.c
bsd-usb.c: In function 'int init_device(UPSINFO*, const char*)':
bsd-usb.c:101: error: aggregate 'usb_device_info devinfo' has incomplete type and cannot be defined
bsd-usb.c:104: error: 'MAXDEVNAMELEN' was not declared in this scopebsd-usb.c:111: error: 'USB_GET_DEVICEINFO' was not declared in this scope
bsd-usb.c:163: error: 'intdevname' was not declared in this scope
bsd-usb.c: In function 'int open_usb_device(UPSINFO*)':bsd-usb.c:197: error: 'MAXDEVNAMELEN' was not declared in this scope
bsd-usb.c:198: error: aggregate 'usb_device_info devinfo' has incomplete type and cannot be definedbsd-usb.c:259: error: 'USB_DEVICEINFO' was not declared in this scope
bsd-usb.c:264: error: 'MAXDEVNAMES' was not declared in this scope
bsd-usb.c:268: error: 'MAXDEVNAMES' was not declared in this scope
bsd-usb.c:269: error: ISO C++ forbids applying 'sizeof' to an expression of function type
bsd-usb.c:269: error: cannot convert 'char* (*)(__dev_t, __mode_t)' to 'char*' for argument '1' to '
char* astrncpy(char*, const char*, int)'
bsd-usb.c:270: error: ISO C++ forbids applying 'sizeof' to an expression of function type
bsd-usb.c:275: error: cannot convert 'char* (*)(__dev_t, __mode_t)' to 'const char*' for argument '2
' to 'int init_device(UPSINFO*, const char*)'
bsd-usb.c:276: error: cannot convert 'char* (*)(__dev_t, __mode_t)' to 'const char*' for argument '2
' to 'char* astrncpy(char*, const char*, int)'
gmake[5]: *** [.obj/bsd-usb.o] Error 1


I tried adding --with-generic-usb as discussed in this mail thread:

  http://docs.freebsd.org/cgi/getmsg.cgi?fetch=412215+0+archive/2009/freebsd-usb/20090215.freebsd-usb

This did not work, however, because the apcupsd configure script looks for libusb-config.  Unfortunately, the libusb port can no longer be installed when the new USB stack is in use.

Should the base system provide a libusb-config binary?

Comment 1 Ion-Mihai "IOnut" Tetcu freebsd_committer

2009-03-11 21:51:35 UTC

Responsible Changed
From-To: freebsd-ports-bugs->itetcu

my port

Comment 2 Ion-Mihai "IOnut" Tetcu freebsd_committer

2009-03-12 14:11:12 UTC

State Changed
From-To: open->closed

Fixed, thanks for testing.

Comment 3 dfilter service freebsd_committer

2009-03-12 14:11:48 UTC

itetcu      2009-03-12 14:10:55 UTC

  FreeBSD ports repository

  Modified files:
    sysutils/apcupsd     Makefile 
  Added files:
    sysutils/apcupsd/files patch-configure 
  Log:
  - fix it to work with newusb on HEAD [1] [2]
  - makefile cleanup and portlint petting.
  
  PR:             ports/132548 [1]
  Submitted by:   Ben Kelly [1], stass@ [2]
  
  Revision  Changes    Path
  1.62      +10 -4     ports/sysutils/apcupsd/Makefile
  1.3       +58 -0     ports/sysutils/apcupsd/files/patch-configure (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"