Summary: | Fixes to nos-tun(8) | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Base System | Reporter: | Nick Johnson <freebsd> | ||||||
Component: | bin | Assignee: | freebsd-bugs (Nobody) <bugs> | ||||||
Status: | Open --- | ||||||||
Severity: | Affects Only Me | ||||||||
Priority: | Normal | ||||||||
Version: | 4.0-CURRENT | ||||||||
Hardware: | Any | ||||||||
OS: | Any | ||||||||
Attachments: |
|
Description
Nick Johnson
1999-08-21 23:40:01 UTC
Responsible Changed From-To: gnats-admin->freebsd-bugs Misfiled PR > >+/* >+ * 19990727 - Nick Johnson <freebsd@spatula.net> >+ * Added -r and -w flags, cleaned up the code a bit, >+ * made writes more robust (return values were not being >+ * checked) >+ */ Don't include these type of comments. We have cvs do this for us. >-void Finish(int signum) >+void Cleanup() > { I guess there's no prototype for this function. >+ if(Set_address(target, to)) >+ return(4); To maintain consistency with the existing nos-tun.c, consider using a "{ ... }" block even if it's not needed. >-end, a concept cisco doesn't really implement. >+end, a concept Cisco doesn't really implement. Destination may be >+a hostname. To make keeping the translated manpages synchronized with their English versions easier, don't gratuitously change a line. The sentence you added should have been started on a new line. [Actually, there has been some suggestion that standard mdoc style is to start sentences on newlines in most cases... You may consider this, too... It means that future changes are clearer and easier to read --- once again important for people doing translation.] >-address set on the remote end. >+address set on the remote end. Target may be a hostname. Same. State Changed From-To: open->feedback Is this problem still present? If so, do you have an update patch as per the comments in the audit trail? State Changed From-To: feedback->open these patches are still relevent Responsible Changed From-To: freebsd-bugs->billf i will work with the submitter (as i know him) to generate updated patches and test them. State Changed From-To: open->feedback To submitter: are these patches still relevant? Responsible Changed From-To: billf->linimon Assignee did not respond to request for status of this PR, so reassign to the pool. State Changed From-To: feedback->suspended Since no one responded to my request for status on this PR, just set it to 'suspended'. Responsible Changed From-To: linimon->freebsd-bugs For bugs matching the following conditions: - Status == In Progress - Assignee == "bugs@FreeBSD.org" - Last Modified Year <= 2017 Do - Set Status to "Open" Keyword: patch or patch-ready – in lieu of summary line prefix: [patch] * bulk change for the keyword * summary lines may be edited manually (not in bulk). Keyword descriptions and search interface: <https://bugs.freebsd.org/bugzilla/describekeywords.cgi> |