Bug 133534
| Summary: | Move VLC to 0.9.9a and revamp OPTIONS to allow for stream server only | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Joseph S. Atkinson <jsa> | ||||
| Component: | Individual Port(s) | Assignee: | Dmitry Marakasov <amdmi3> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | cjk32 | ||||
| Priority: | Normal | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
|
Description
Joseph S. Atkinson
2009-04-09 08:50:01 UTC
Responsible Changed From-To: freebsd-ports-bugs->amdmi3 I'll take it. > Synopsis: Move VLC to 0.9.9a and revamp OPTIONS to allow for stream server only > > http://www.freebsd.org/cgi/query-pr.cgi?pr=133534 1) What do you think about adding GNOMEVFS option? + GNOMEVFS "Gnome VFS support" On \ 2) Are you sure this is correct? .if defined(WITHOUT_NLS) USE_GETTEXT= yes CONFIGURE_ARGS+=--disable-nls .endif 3) Fails WITH_DIRAC: http://people.freebsd.org/~amdmi3/vlc-dirac-0.9.9.a%2c3.log -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://www.amdmi3.ru State Changed From-To: open->feedback Awaiting submitters feedback. > 1) What do you think about adding GNOMEVFS option? I'm fine with it. Looks like it's already in there, just not an option to toggle. It's probably been like that since it's inception. > 2) Are you sure this is correct? Not one bit. But I have noble intentions. If I am mistaken, the purpose of WITHOUT_NLS is to not require the internationalization support. USE_GETTEXT forces dependency on libintl, which is used for that. So I was attempting to break the forcing of the depend even when no NLS was requested. Is the conditional causing it to breakage I didn't see locally? > 3) Fails WITH_DIRAC: This looks like a dragon we might could slay. Dirac is currently at 1.0.6 upstream, but in ports it's 0.7 from 2007. Maintainer dropped it in 2006. The reference port is also unmaintained and marked broken. Nothing depends on this, and I am betting not many care. VideoLAN informs me that it's still fully supported, so I may just bump dirac myself. Until I have time to do that, the option might need to conditionally mark BROKEN and noted on the option description. (a la OPENGL in gnash) Do you use dirac, or were you just testing? Overall, I think I am going to have to go through this with a fine toothed comb and rework a lot of this port at some point... Dmitry Marakasov wrote:
> You are, however, using USE_GETTEXT in WITHOUT_NLS branch which doesn't
> make sence.
>
/me facepalms
I never even blinked at that. Yeah, should clearly be paired WITH_NLS
and the --enable arg, sorry.
Told you I didn't swear it was right!
As far as the NLS plist entries go, there isn't a static plist. But
because the plist is currently dynamic, it (hypothetically) contains
only what was tailored to their install.
State Changed From-To: feedback->closed Committed, with minor changes. Thanks! * Joseph S. Atkinson (jsatkinson@embarqmail.com) wrote: > > You are, however, using USE_GETTEXT in WITHOUT_NLS branch which doesn't > > make sence. > > > > /me facepalms > > I never even blinked at that. Yeah, should clearly be paired WITH_NLS > and the --enable arg, sorry. Done. No need for --enable actually, as it's on by default. Logs show that libintl is correctly detected by default and there's no attempt to detect libintl when WITHOUT_NLS is set. Also, from the PR: > There is a known issue with this Makefile, and it will not pass portlint > due to the conditional inclusion of USE_QT_VER dependant on if a > person's selection of WITH(OUT)_QT4. I believe this to be unavoidable. There's bsd.port.options.mk thing that may help. --- OPTIONS=... .include <bsd.port.options.mk> # here it's OK to both check WITH_/WITHOUT_ values from options, # and set all USE_ stuff. .if defined(WITH_QT) USE_QT_VER= 4 .endif .include <bsd.port.pre.mk> # here go targets .include <bsd.port.post.mk> --- > Please run this through a tinderbox in case I missed something beyond > my ability to test for. FYI, I've run it for each option toggled, dirac is the only one that failed. -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://www.amdmi3.ru |
