Bug 134595

Summary: Take games/odamex port and update to 0.4.3
Product: Ports & Packages Reporter: Josh Rickmar <joshua_rickmar>
Component: Individual Port(s)Assignee: Dmitry Marakasov <amdmi3>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff
none
odamex-patch none

Description Josh Rickmar 2009-05-17 04:30:01 UTC 
I would like to take over this port.  Attached is an update to version 0.4.3.

Fix: Patch attached with submission follows:
Comment 1 Dmitry Marakasov freebsd_committer freebsd_triage 2009-05-18 15:00:05 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->amdmi3

I'll take it.
Comment 2 Dmitry Marakasov freebsd_committer freebsd_triage 2009-05-18 15:04:42 UTC 
State Changed
From-To: open->feedback

Patch is proken. It doesn't apply correctly for 
patch-client__src__d_main.cpp itself, then it ca't apply 
files/patch-Makefile correctly.
Comment 3 Josh Rickmar 2009-05-18 22:01:42 UTC 
I made the patch according to the instructions in the Porter's Handbook.
The only thing that I can think that would be wrong is that the Odamex
sources are in a dos encoding, so they have ^M at the end of all the
files.  These may have been stripped somehow.

After I submitted this, I realized that even if this patch did work, the
port would not behave as expected.  I forgot to patch
server/src/d_main.cpp in the same way as client/src/d_main.cpp.  Without
doing this, it would not be able to find odamex.wad in
/usr/local/share/odamex/ and wouldn't look in /usr/local/share/doom/ for
other wads.

I've attached the newer patch to fix this problem, but I'm not sure what
needs to be changed to fix the problems of the first patch.  If I'm
doing something stupid, please tell me.
Comment 4 Dmitry Marakasov freebsd_committer freebsd_triage 2009-05-31 19:34:05 UTC 
State Changed
From-To: feedback->closed

Committed, with minor changes. Thanks!
Comment 5 dfilter service freebsd_committer freebsd_triage 2009-05-31 19:34:18 UTC 
amdmi3      2009-05-31 18:34:04 UTC

  FreeBSD ports repository

  Modified files:
    games/odamex         Makefile distinfo 
    games/odamex/files   patch-Makefile 
                         patch-client__src__d_main.cpp 
                         patch-odalaunch__Makefile 
  Added files:
    games/odamex/files   patch-server__src__d_main.cpp 
  Log:
  - Update to 0.4.3
  - Pass maintainership to submitter
  
  PR:             134595
  Submitted by:   Josh Rickmar <joshua_rickmar@eumx.net>
  
  Revision  Changes    Path
  1.5       +7 -5      ports/games/odamex/Makefile
  1.2       +3 -3      ports/games/odamex/distinfo
  1.2       +53 -53    ports/games/odamex/files/patch-Makefile
  1.2       +10 -11    ports/games/odamex/files/patch-client__src__d_main.cpp
  1.2       +18 -18    ports/games/odamex/files/patch-odalaunch__Makefile
  1.1       +11 -0     ports/games/odamex/files/patch-server__src__d_main.cpp (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"