Bug 13468

Summary: [PATCH] incorrect wakeup argument in atapi_free()
Product: Base System Reporter: Vsevolod Lobko <seva>
Component: i386Assignee: Luoqi Chen <luoqi>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: 4.0-CURRENT   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Vsevolod Lobko 1999-08-30 13:40:01 UTC 
When using block devices system places many concurent commands for device

ATAPI driver have static buffer for 16 commands, and after 16 commands, 
atapi_alloc tsleep's on ata structure

atapi_free have wakeup, but with incorrect sleep addr &ata

Fix: Apply patch:
How-To-Repeat: 
dd if=/dev/zero of=/dev/rwfd0 bs=2k count=100
and 
dd if=/dev/zero of=/dev/wfd0 bs=2k count=100

have very different transfer rates
Comment 1 Sheldon Hearn 1999-08-30 14:35:18 UTC 
On Mon, 30 Aug 1999 15:34:17 +0300, Vsevolod Lobko wrote:

> When using block devices system places many concurent commands for
> device

Do you find the same poor performance with the now ata driver?

Ciao,
Sheldon.
Comment 2 seva 1999-08-30 14:40:50 UTC 
On Mon, 30 Aug 1999, Sheldon Hearn wrote:

> 
> 
> On Mon, 30 Aug 1999 15:34:17 +0300, Vsevolod Lobko wrote:
> 
> > When using block devices system places many concurent commands for
> > device
> 
> Do you find the same poor performance with the now ata driver?

I don't check this.
I need working atapi support on stable branch :)) (It's an embedded 
system)
Comment 3 Sheldon Hearn freebsd_committer freebsd_triage 1999-08-30 15:00:55 UTC 
Responsible Changed
From-To: freebsd-bugs->luoqi

Luoqi, could you take a look at this? The originator's using STABLE, 
despite the Environment: field in the PR.
Comment 4 Luoqi Chen freebsd_committer freebsd_triage 1999-08-30 19:38:52 UTC 
State Changed
From-To: open->closed

Fix committed.