Bug 134731

In moving from hal-0.5.11_21 to hal-0.5.11_23, hald suddenly took up 100% of my CPU and I was unable to run lshal at all. I recompiled hald with debug flags and noticed that the function hf_storage_device_probe_geom called itself recursively and eventually blew the stack. I'm afraid I don't know enough to debug exactly what the problem is, but after adding a return statement at the beginning of the function hf_storage_device_probe_geom and recompiling, all is well. I suspect the issue is the recently added support for the PART GEOM type.

Here is the output of sysctl -b kern.geom.conftxt on my system:

0 DISK cd0 0 2048 hd 0 sc 0
0 DISK ad14 251000193024 512 hd 16 sc 63
1 PART ad14s2 162062659584 512 i 2 o 32256 ty !5 xs MBR xt 5
2 MBR ad14s2s2 119998609920 512 i 1 o 8192346624 ty 5
3 MBREXT ad14s2s5 119998577664 512 i 0 o 32256 ty 131
2 MBR ad14s2s1 8192314368 512 i 0 o 32256 ty 130
1 PART ad14s1 88937178624 512 i 1 o 162063014400 ty !175 xs MBR xt 175
1 MBR ad14s2 162062659584 512 i 1 o 32256 ty 5
2 PART ad14s2s2 119998609920 512 i 2 o 8192346624 ty !5 xs MBR xt 5
3 MBR ad14s2s2s2 17001653760 512 i 1 o 128190956544 ty 5
3 MBR ad14s2s2s1 119998577664 512 i 0 o 32256 ty 131
2 PART ad14s2s1 8192314368 512 i 1 o 32256 ty !130 xs MBR xt 130
2 MBREXT ad14s8 16870017024 512 i 3 o 145192642560 ty 131
2 MBREXT ad14s7 17001621504 512 i 2 o 128190988800 ty 131
2 MBREXT ad14s6 119998577664 512 i 1 o 8192378880 ty 131
2 MBREXT ad14s5 8192314368 512 i 0 o 32256 ty 130
1 MBR ad14s1 88937178624 512 i 0 o 162063014400 ty 175
0 DISK ad12 1000204886016 512 hd 16 sc 63
1 MBR ad12s1 824633639424 512 i 0 o 32256 ty 165
2 BSD ad12s1g 64424428032 512 i 6 o 760209211392 ty 7
2 BSD ad12s1f 68719476736 512 i 5 o 691489734656 ty 7
2 BSD ad12s1e 68719476736 512 i 4 o 622770257920 ty 7
2 BSD ad12s1d 536870912000 512 i 3 o 17179869184 ty 7
2 BSD ad12s1c 824633639424 512 i 2 o 0 ty 0
3 PART ad12s1cg 64424428032 512 i 7 o 760209211392 ty freebsd-ufs xs BSD xt 7
3 PART ad12s1cf 68719476736 512 i 6 o 691489734656 ty freebsd-ufs xs BSD xt 7
3 PART ad12s1ce 68719476736 512 i 5 o 622770257920 ty freebsd-ufs xs BSD xt 7
3 PART ad12s1cd 536870912000 512 i 4 o 17179869184 ty freebsd-ufs xs BSD xt 7
3 PART ad12s1cb 17179869184 512 i 2 o 0 ty freebsd-swap xs BSD xt 1
3 PART ad12s1ca 68719476736 512 i 1 o 554050781184 ty freebsd-ufs xs BSD xt 7
2 BSD ad12s1b 17179869184 512 i 1 o 0 ty 1
2 BSD ad12s1a 68719476736 512 i 0 o 554050781184 ty 7
0 DISK ad10 400088457216 512 hd 16 sc 63
1 PART ad10s1 400085812224 512 i 1 o 32256 ty !7 xs MBR xt 7
1 MBR ad10s1 400085812224 512 i 0 o 32256 ty 7