Bug 135702
| Summary: | Update port print/hplip to 3.9.6 | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Chris Petrik <c.petrik.sosa> | ||||||||||||||||
| Component: | Individual Port(s) | Assignee: | Dmitry Marakasov <amdmi3> | ||||||||||||||||
| Status: | Closed FIXED | ||||||||||||||||||
| Severity: | Affects Only Me | ||||||||||||||||||
| Priority: | Normal | ||||||||||||||||||
| Version: | Latest | ||||||||||||||||||
| Hardware: | Any | ||||||||||||||||||
| OS: | Any | ||||||||||||||||||
| Attachments: |
|
||||||||||||||||||
|
Description
Chris Petrik
2009-06-18 14:20:01 UTC
Responsible Changed From-To: freebsd-ports-bugs->amdmi3 I'll take it. State Changed From-To: open->repocopy Please send update as a patch State Changed From-To: repocopy->feedback Please send update as a patch Not sure why it's encoding the attachments, and I apologize for that here are the patches but I uploaded them to my site http://files.officialunix.com/freebsd/patches Hello, Here is the patch to update hplip. Last port update attempt before I give up. As I get no help from the commiter except "It doesn't work" "it doesn't compile" etc.. I am new at this and I love to make ports but with these responses I am losing motivation to spend time doing this. * Chris Petrik (c.petrik.sosa@gmail.com) wrote: > Last port update attempt before I give up. > > As I get no help from the commiter except "It doesn't work" "it doesn't > compile" etc.. I am new at this and I love to make ports but with these > responses I am losing motivation to spend time doing this. That's just impolite. I've offered you any help, but instead of asking questions, you just keep submitting broken stuff. For example, your last shar doesn't even patch: ===> Applying FreeBSD patches for hplip-3.9.6 1 out of 2 hunks failed--saving rejects to Makefile.am.rej => Patch patch-Makefile.am failed to apply cleanly. *** Error code 1 has nonsense like CONFIGURE_ARGS-= and still has broken plist. Don't take this personally, but you're going to change pretty complex port which is used by other people, and you don't seem to be competent enough in what you're doing. I could probably just fix and commit it, but that would not be the best thing to do. Let me cite pav@: -- Immediate fixing would negate one of the principles in FreeBSD project - person who made a mistake should correct it (so he learns from it). -- Since the current maintainer is inactive, it would be good to pass maintainership to you as you're definitely interested in this port, but to be able to do this, we have to go thru "new shar->test->fail->list of required fixes->repeat" iterations for you to learn how the stuff works and be a good maintainer for it, and also to not break it for other people. Since it's getting frustrating, I'm going to vacation and hopefully you've fixed most of problems, I'm just fixing the rest so it builds and posting an updated shar on freebsd-ports@ for testing. If there are no problems, I'll commit it in the end of this week. -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://www.amdmi3.ru I am confused as to why the port does not build. The build log on my machine. FreeBSD 7.2-Pre PCBSD 7.1 I386 I hit ctrl C if you require a file log I will be glad to post it here. It was just to prove that what the commiter is saying is irrelevant to the actual code. [chris@pcbsd]/home/chris/projects/ports/hplip% make patch ===> Found saved configuration for hplip-3.9.6 ===> Extracting for hplip-3.9.6 => MD5 Checksum OK for hplip-3.9.6.tar.gz. => SHA256 Checksum OK for hplip-3.9.6.tar.gz. ===> Patching for hplip-3.9.6 ===> Applying FreeBSD patches for hplip-3.9.6 [chris@pcbsd]/home/chris/projects/ports/hplip% [chris@pcbsd]/home/chris/projects/ports/hplip/files% cat patch-Makefile.am --- Makefile.am.old 2009-06-22 23:34:12.000000000 -0500 +++ Makefile.am 2009-06-22 23:36:52.000000000 -0500 @@ -24,11 +24,11 @@ if DOC_BUILD wwwsrc = doc www0dir = $(docdir) -dist_www0_DATA = $(wwwsrc)/index.html $(wwwsrc)/commandline.html $(wwwsrc)/copying.html $(wwwsrc)/devicemanager.html $(wwwsrc)/faxtrouble.html $(wwwsrc)/gettinghelp.html $(wwwsrc)/hpscan.html $(wwwsrc)/mainttask.html $(wwwsrc)/plugins.html $(wwwsrc)/print.html$(wwwsrc)/printing.html $(wwwsrc)/printoptions.html $(wwwsrc)/printtroubleshooting.html $(wwwsrc)/scanning.html $(wwwsrc)/scantrouble.html $(wwwsrc)/sendfax.html $(wwwsrc)/setup.html $(wwwsrc)/systray.html $(wwwsrc)/troubleshooting.html $(wwwsrc)/uninstalling.html $(wwwsrc)/upgrading.html +dist_www0_DATA = $(wwwsrc)/*.html www3dir = $(docdir)/styles -dist_www3_DATA = $(wwwsrc)/styles/* +dist_www3_DATA = $(wwwsrc)/styles/*.css www4dir = $(docdir)/images -dist_www4_DATA = $(wwwsrc)/images/* +dist_www4_DATA = $(wwwsrc)/images/*.png $(wwwsrc)/images/*.ico endif if HPLIP_BUILD @@ -89,10 +89,11 @@ hp_mkuri_LDADD = libhpmud.la # hpmud.rules -rulesdir = /etc/udev/rules.d -dist_rules_DATA = data/rules/55-hpmud.rules data/rules/56-hpmud_support.rules -halpredir = /usr/share/hal/fdi/preprobe/10osvendor -dist_halpre_DATA = data/rules/20-hplip-devices.fdi +# FreeBSD doesn't use udev so why install the rules? +#rulesdir = /etc/udev/rules.d +#dist_rules_DATA = data/rules/55-hpmud.rules data/rules/56-hpmud_support.rules +#halpredir = /usr/share/hal/fdi/preprobe/10osvendor +#dist_halpre_DATA = data/rules/20-hplip-devices.fdi # hplip.conf hplip_confdir = /usr/local/etc/hp [chris@pcbsd]/home/chris/projects/ports/hplip/files% So I am confused. * Chris Petrik (c.petrik.sosa@gmail.com) wrote: > Look at the make.log, and then try to notice the frustration with you > and myself? The port build, installs, and works on my end as im using > it. Sure the pkg_plist if bad, if you would give me advice im all ears > if not then... Sorry, I didn't quite understand the meaning of that log. > I myself don't care if im the owner of the port, I just care that it > gets updated, I don't spend 4 hours trying to port something just for > fame, I do it for myself and let other people enjoy the work also. Well, the least I can say, if you want it in ports, it has to be in a good shape. So you have to either spend some time cleaning it up, or state that you don't want to spend more time and it works for you - so it can be just posted to freebsd-ports@ or whereever to be used by anyone on their own risk, or as a base for a cleaner update. > If this is going to be like it is now I would suggest you update the > port, remove the PR, give me a site that has more detail of the ports > system, access to some sort of testing machine. No such things beside Porter's Handbook, Mk/* and existing ports. Nothing more is really needed. Just some time, a wish to learn and an ability to ask questions. We don't provide any dedicated testing machines, as we don't really have them. We have package building cluster and QA tinderbox that automatically check portstree (i.e. post-factum), and I have my own tinderbox on which I can test as many changes as it's needed before committing the to the portstree. I can't provide you access to it, unfortunately. > As I do read the Porters Handbook, and I find no info on how to use > CONFIGURE_ARGS= I found this reading the files in /usr/ports/Mk/* Porters handbook assumes basic make knowlenge. As you can see from `man make', there's no such thing as -=. > So I would appreciate it before you say "incompetent" that you also look > at the reason why i'm incompetent lack of Documentation is one, and > lack of friendly commiters is another. I'm sorry if my attitude seemed `unfriendly' to you, but all you had to do was to ask a question on how it's better to fix this or that. You know, I process many patces from many people, and `default' action is to just provide an error log. I guess it's pretty logical to assume that author either has the knowledge on how to fix stuff or will ask a question. Sometimes that's done repeatedly (there are people who just don't want to install their own tinderbox, and I have no problem with testing patches for them ten, hundred or thousand times). So please don't call me unhelpful and unfriendly, I just had no idea that you needed any help, and I'm always willing to help if it's needed. > Please let me know what you want to do so I stop fiddling with hplip. I've fixed bits that have left, so it builds fine on FreeBSD-7.2/amd64. The shar is attached - feel free to ask any questions regarding the changes I've maed, really. Is I've said in previous mail, I'm going to test if it builds on other FreeBSD versions/architectures (which will take some hours) and then post it on freebsd-ports@ mailing list, so it may be tested by end users. If everything's OK I'll commit it by the end of the week. -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://www.amdmi3.ru * Chris Petrik (c.petrik.sosa@gmail.com) wrote: > The shar is attached Now really attached -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://www.amdmi3.ru I would also like to see a push to get this port updated to at least 2.8.10 as this is the version of the driver that my printer supports. I was able to modify the original makefile to get this specific version installed. %pkg_info | fgrep hplip hplip-2.8.10_1 Drivers and utilities for HP Printers and All-in-One device I was going to create a patchset and use send-pr to update however it seems that the OP here has a mostly working patchset. Kudos! I look forward to seeing it. State Changed From-To: feedback->repocopy Please repocopy print/hplip to print/hplip3 Responsible Changed From-To: amdmi3->portmgr Please repocopy print/hplip to print/hplip3 State Changed From-To: repocopy->open Repocopy complete. Responsible Changed From-To: portmgr->amdmi3 Repocopy complete. Hello, Updated shar file, this fixes the regression, and also adds in GUI support. Not many want to test this, so I have only tested it and it seems to work. http://projects.officialunix.com/shars/hplip.shar This also updates the port to 3.9.6b Christopher Petrik http://www.officialunix.com Random Quote of the day: amdmi3 2009-08-04 00:53:23 UTC
FreeBSD ports repository
Modified files:
print/hplip3 Makefile distinfo pkg-descr pkg-install
pkg-message pkg-plist
print/hplip3/files hpssd.sh.in patch-CVE-2008-2940
patch-CVE-2008-2941 patch-Makefile.am
patch-Makefile.in patch-base_utils.py
patch-hpssd.py patch-io-hpmud-musb.c
Log:
- Forced commit to note that print/hplip3 was repocopied from print/hplip
PR: 135702
Repocopy by: marcus
Revision Changes Path
1.25 +0 -0 ports/print/hplip3/Makefile
1.11 +0 -0 ports/print/hplip3/distinfo
1.6 +0 -0 ports/print/hplip3/files/hpssd.sh.in
1.2 +0 -0 ports/print/hplip3/files/patch-CVE-2008-2940
1.2 +0 -0 ports/print/hplip3/files/patch-CVE-2008-2941
1.2 +0 -0 ports/print/hplip3/files/patch-Makefile.am
1.9 +0 -0 ports/print/hplip3/files/patch-Makefile.in
1.2 +0 -0 ports/print/hplip3/files/patch-base_utils.py
1.2 +0 -0 ports/print/hplip3/files/patch-hpssd.py
1.2 +0 -0 ports/print/hplip3/files/patch-io-hpmud-musb.c
1.3 +0 -0 ports/print/hplip3/pkg-descr
1.3 +0 -0 ports/print/hplip3/pkg-install
1.4 +0 -0 ports/print/hplip3/pkg-message
1.12 +0 -0 ports/print/hplip3/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
amdmi3 2009-08-05 00:44:53 UTC
FreeBSD ports repository
Modified files:
print/hplip3 Makefile distinfo pkg-plist
print/hplip3/files patch-Makefile.am patch-Makefile.in
patch-io-hpmud-musb.c
Added files:
print/hplip3/files hpssd.in patch-check.py patch-cups.py
pkg-message.in
Removed files:
print/hplip3 pkg-install pkg-message
print/hplip3/files hpssd.sh.in patch-CVE-2008-2940
patch-CVE-2008-2941 patch-base_utils.py
patch-hpssd.py
Log:
- Update to 3.9.6b
PR: 135702
Submitteed by: Chris Petrik <c.petrik.sosa@gmail.com>
Thanks to: "Juergen Lock" <nox@jelal.kn-bremen.de>
Revision Changes Path
1.26 +73 -77 ports/print/hplip3/Makefile
1.12 +3 -3 ports/print/hplip3/distinfo
1.1 +30 -0 ports/print/hplip3/files/hpssd.in (new)
1.7 +0 -30 ports/print/hplip3/files/hpssd.sh.in (dead)
1.3 +0 -74 ports/print/hplip3/files/patch-CVE-2008-2940 (dead)
1.3 +0 -210 ports/print/hplip3/files/patch-CVE-2008-2941 (dead)
1.3 +29 -33 ports/print/hplip3/files/patch-Makefile.am
1.10 +40 -95 ports/print/hplip3/files/patch-Makefile.in
1.3 +0 -53 ports/print/hplip3/files/patch-base_utils.py (dead)
1.1 +20 -0 ports/print/hplip3/files/patch-check.py (new)
1.1 +23 -0 ports/print/hplip3/files/patch-cups.py (new)
1.3 +0 -21 ports/print/hplip3/files/patch-hpssd.py (dead)
1.3 +11 -5 ports/print/hplip3/files/patch-io-hpmud-musb.c
1.1 +54 -0 ports/print/hplip3/files/pkg-message.in (new)
1.4 +0 -19 ports/print/hplip3/pkg-install (dead)
1.5 +0 -54 ports/print/hplip3/pkg-message (dead)
1.13 +956 -846 ports/print/hplip3/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed. Thanks! |
