Bug 136602

Summary: Update of ports/irc/ircservices to current
Product: Ports & Packages Reporter: Terry Sposato <terry>
Component: Individual Port(s)Assignee: Wesley Shields <wxs>
Status: Closed FIXED    
Severity: Affects Only Me CC: terry
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
port-ircservices.diff none

Description Terry Sposato 2009-07-09 06:10:01 UTC 
	Update ports/irc/ircservices to 5.1.17 which is current release

How-To-Repeat: 	Apply updated port and build as per normal
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2009-07-09 06:10:09 UTC 
Maintainer of irc/ircservices,

Please note that PR ports/136602 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/136602

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2009-07-09 06:10:11 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Andrey V. Elsukov 2009-07-09 06:52:57 UTC 
Edwin Groothuis wrote:
> Maintainer of irc/ircservices,
> 
> Please note that PR ports/136602 has just been submitted.
> 
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.

Hi, Edwin.

1. It seems ok.
2. I din't test it :)
3. The date created seems wrong.
4. As I know removing signature from pkg-descr is a bad style.

-- 
WBR, Andrey V. Elsukov
Comment 4 Mark Linimon 2009-07-10 04:55:02 UTC 
On Thu, Jul 09, 2009 at 06:40:06AM +0000, Andrey V. Elsukov wrote:
>  1. It seems ok.
>  2. I din't test it :)
>  3. The date created seems wrong.
>  4. As I know removing signature from pkg-descr is a bad style.

ok, does this count as an approval or a rejection?

mcl
Comment 5 Andrey V. Elsukov 2009-07-13 05:47:31 UTC 
Mark Linimon wrote:
> On Thu, Jul 09, 2009 at 06:40:06AM +0000, Andrey V. Elsukov wrote:
>>  1. It seems ok.
>>  2. I din't test it :)
>>  3. The date created seems wrong.
>>  4. As I know removing signature from pkg-descr is a bad style.
> 
> ok, does this count as an approval or a rejection?

A new version was released recently. So, I'll updated port and submit a new patch.

-- 
WBR, Andrey V. Elsukov
Comment 6 Mark Linimon freebsd_committer freebsd_triage 2009-07-13 16:16:25 UTC 
State Changed
From-To: feedback->suspended

Maintainer is working on new revision.
Comment 7 Terry Sposato 2009-07-13 23:25:47 UTC 
Hi,

Subsequent new versions from now are just security fixes so you should
only need to bump PORTVERSION on my current diff to build 5.1.18.

Regards,

Terry
Comment 8 Terry Sposato 2009-07-14 01:34:20 UTC 
Here is the updated diff for 5.1.18.
http://www.sucked-in.com/~terry/ircservices5.1.18.diff
<http://www.sucked-in.com/%7Eterry/ircservices5.1.18.diff>

diff -Nru /usr/ports/irc/ircservices/Makefile /usr/home/terry/ircservices/Makefile
--- /usr/ports/irc/ircservices/Makefile	2008-09-16 06:03:40.000000000 +1000
+++ /usr/home/terry/ircservices/Makefile	2009-07-14 10:29:56.000000000 +1000
@@ -6,11 +6,11 @@
 #
 
 PORTNAME=	ircservices
-PORTVERSION=	5.0.63
+PORTVERSION=	5.1.18
 CATEGORIES=	irc
-MASTER_SITES=	http://www.ircservices.za.net/download/old/ \
-	http://banana.irc.gr/ircservices/old/ \
-	ftp://ftp.freenet.de/pub/ftp.ircservices.za.net/pub/ircservices/old/
+MASTER_SITES=	http://www.ircservices.za.net/download/ \
+	http://banana.irc.gr/ircservices/ \
+	ftp://ftp.freenet.de/pub/ftp.ircservices.za.net/pub/ircservices/
 
 MAINTAINER=	bu7cher@yandex.ru
 COMMENT=	A system of IRC services for IRC networks
@@ -21,7 +21,7 @@
 USE_RC_SUBR=	ircservices
 
 DIST_SUBDIR=	${PORTNAME}
-CONFIGURE_ARGS=	-prefix ${PREFIX} -cflags "${CFLAGS}" -cc "${CC}"
+CONFIGURE_ARGS=	-bindest ${PREFIX}/sbin -datdest ${PREFIX}/etc/ircservices -cflags "${CFLAGS}" -cc "${CC}"
 
 IRCSERVICES_LANG?=	EN_US
 
@@ -50,8 +50,13 @@
 post-install:
 .if !defined(NOPORTDOCS)
 	@${MKDIR} ${DOCSDIR}
-	@${INSTALL_DATA} ${WRKSRC}/docs/*.html ${DOCSDIR}
-	@${INSTALL_DATA} ${WRKSRC}/Changes ${WRKSRC}/KnownBugs ${DOCSDIR}
+	(cd ${WRKSRC}/docs/ && ${COPYTREE_SHARE} \* ${DOCSDIR})
+	@${ECHO_MSG} ""
+        @${ECHO_MSG} "**********            IMPORTANT           **********"
+        @${ECHO_MSG} "The configuration directory has changed to ${PREFIX}/etc/ircservices"
+        @${ECHO_MSG} "Please copy your old config files there if updating"
+        @${ECHO_MSG} "**********          IMPORTANT           **********"
+        @${ECHO_MSG} ""
 .endif
 
 .include <bsd.port.post.mk>
diff -Nru /usr/ports/irc/ircservices/distinfo /usr/home/terry/ircservices/distinfo
--- /usr/ports/irc/ircservices/distinfo	2008-01-20 12:33:47.000000000 +1100
+++ /usr/home/terry/ircservices/distinfo	2009-07-14 10:26:08.000000000 +1000
@@ -1,3 +1,3 @@
-MD5 (ircservices/ircservices-5.0.63.tar.gz) = 72ca8245d99fd1d7f841131ef55a09aa
-SHA256 (ircservices/ircservices-5.0.63.tar.gz) = 7cf68b2dc956c25da694e1650b3871a9a55feac191292062d3d568d377be6ce3
-SIZE (ircservices/ircservices-5.0.63.tar.gz) = 1167436
+MD5 (ircservices/ircservices-5.1.18.tar.gz) = 2e73c1c35706398d754778cdc8a94dba
+SHA256 (ircservices/ircservices-5.1.18.tar.gz) = 39f33b9ee6543b9e4b5fb8dc0a509a19ca7d8b43b45fff1270b97f7fd48f0f60
+SIZE (ircservices/ircservices-5.1.18.tar.gz) = 1532076
diff -Nru /usr/ports/irc/ircservices/files/ircservices.in /usr/home/terry/ircservices/files/ircservices.in
--- /usr/ports/irc/ircservices/files/ircservices.in	2006-06-26 23:28:49.000000000 +1000
+++ /usr/home/terry/ircservices/files/ircservices.in	2009-07-14 10:27:09.000000000 +1000
@@ -11,9 +11,10 @@
 rcvar=${name}_enable
 
 command="%%PREFIX%%/sbin/${name}"
-pidfile="%%PREFIX%%/lib/services/${name}.pid"
-required_files="%%PREFIX%%/lib/services/ircservices.conf \
-		%%PREFIX%%/lib/services/modules.conf"
+command_args="-dir=%%PREFIX%%/etc/ircservices"
+pidfile="/var/run/${name}.pid"
+required_files="%%PREFIX%%/etc/ircservices/ircservices.conf \
+		%%PREFIX%%/etc/ircservices/modules.conf"
 
 load_rc_config ${name}
 
diff -Nru /usr/ports/irc/ircservices/pkg-descr /usr/home/terry/ircservices/pkg-descr
--- /usr/ports/irc/ircservices/pkg-descr	2006-10-04 15:46:08.000000000 +1000
+++ /usr/home/terry/ircservices/pkg-descr	2009-07-14 10:27:42.000000000 +1000
@@ -5,6 +5,3 @@
 control over the network.
 
 WWW: http://www.ircservices.za.net/
-
-- Alex Dupre
-ale@FreeBSD.org
diff -Nru /usr/ports/irc/ircservices/pkg-plist /usr/home/terry/ircservices/pkg-plist
--- /usr/ports/irc/ircservices/pkg-plist	2005-05-12 01:25:34.000000000 +1000
+++ /usr/home/terry/ircservices/pkg-plist	2009-07-14 10:21:44.000000000 +1000
@@ -1,66 +1,17 @@
-lib/services/convert-db
-lib/services/example-ircservices.conf
-lib/services/example-modules.conf
-lib/services/helpfiles/help
-lib/services/languages/de
-lib/services/languages/en_us
-lib/services/languages/es
-lib/services/languages/fr
-lib/services/languages/hu
-lib/services/languages/it
-lib/services/languages/ja_euc
-lib/services/languages/ja_sjis
-lib/services/languages/nl
-lib/services/languages/pt
-lib/services/languages/ru
-lib/services/languages/tr
-lib/services/modules/chanserv/access-levels.so
-lib/services/modules/chanserv/access-xop.so
-lib/services/modules/chanserv/main.so
-lib/services/modules/chanserv/sendpass.so
-lib/services/modules/database/version4.so
-lib/services/modules/encryption/md5.so
-lib/services/modules/httpd/auth-ip.so
-lib/services/modules/httpd/auth-password.so
-lib/services/modules/httpd/dbaccess.so
-lib/services/modules/httpd/debug.so
-lib/services/modules/httpd/main.so
-lib/services/modules/httpd/redirect.so
-lib/services/modules/httpd/top-page.so
-lib/services/modules/mail/main.so
-lib/services/modules/mail/sendmail.so
-lib/services/modules/mail/smtp.so
-lib/services/modules/memoserv/forward.so
-lib/services/modules/memoserv/ignore.so
-lib/services/modules/memoserv/main.so
-lib/services/modules/misc/devnull.so
-lib/services/modules/misc/helpserv.so
-lib/services/modules/misc/xml-export.so
-lib/services/modules/misc/xml-import.so
-lib/services/modules/nickserv/access.so
-lib/services/modules/nickserv/autojoin.so
-lib/services/modules/nickserv/link.so
-lib/services/modules/nickserv/mail-auth.so
-lib/services/modules/nickserv/main.so
-lib/services/modules/nickserv/oldlink.so
-lib/services/modules/nickserv/sendpass.so
-lib/services/modules/operserv/akill.so
-lib/services/modules/operserv/main.so
-lib/services/modules/operserv/news.so
-lib/services/modules/operserv/sessions.so
-lib/services/modules/operserv/sline.so
-lib/services/modules/protocol/bahamut.so
-lib/services/modules/protocol/dalnet.so
-lib/services/modules/protocol/dreamforge.so
-lib/services/modules/protocol/hybrid.so
-lib/services/modules/protocol/monkey.so
-lib/services/modules/protocol/ptlink.so
-lib/services/modules/protocol/rfc1459.so
-lib/services/modules/protocol/trircd.so
-lib/services/modules/protocol/ts8.so
-lib/services/modules/protocol/undernet-p9.so
-lib/services/modules/protocol/unreal.so
-lib/services/modules/statserv/main.so
+%%ETCDIR%%/convert-db
+%%ETCDIR%%/example-ircservices.conf
+%%ETCDIR%%/example-modules.conf
+%%ETCDIR%%/helpfiles/help
+%%ETCDIR%%/languages/de
+%%ETCDIR%%/languages/en_us
+%%ETCDIR%%/languages/es
+%%ETCDIR%%/languages/fr
+%%ETCDIR%%/languages/hu
+%%ETCDIR%%/languages/ja_euc
+%%ETCDIR%%/languages/ja_sjis
+%%ETCDIR%%/languages/nl
+%%ETCDIR%%/languages/ru
+%%ETCDIR%%/languages/tr
 sbin/ircservices
 sbin/ircservices-chk
 %%PORTDOCS%%%%DOCSDIR%%/0.html
@@ -70,30 +21,41 @@
 %%PORTDOCS%%%%DOCSDIR%%/4.html
 %%PORTDOCS%%%%DOCSDIR%%/5.html
 %%PORTDOCS%%%%DOCSDIR%%/6.html
-%%PORTDOCS%%%%DOCSDIR%%/7.html
-%%PORTDOCS%%%%DOCSDIR%%/COPYING.html
+%%PORTDOCS%%%%DOCSDIR%%/Changes
+%%PORTDOCS%%%%DOCSDIR%%/Changes.old
+%%PORTDOCS%%%%DOCSDIR%%/FDL.html
+%%PORTDOCS%%%%DOCSDIR%%/GPL.html
+%%PORTDOCS%%%%DOCSDIR%%/WhatsNew
 %%PORTDOCS%%%%DOCSDIR%%/a.html
 %%PORTDOCS%%%%DOCSDIR%%/b.html
 %%PORTDOCS%%%%DOCSDIR%%/c.html
+%%PORTDOCS%%%%DOCSDIR%%/convert-db.8
 %%PORTDOCS%%%%DOCSDIR%%/copyright.html
+%%PORTDOCS%%%%DOCSDIR%%/d.html
 %%PORTDOCS%%%%DOCSDIR%%/faq.html
 %%PORTDOCS%%%%DOCSDIR%%/index.html
+%%PORTDOCS%%%%DOCSDIR%%/ircservices-chk.8
+%%PORTDOCS%%%%DOCSDIR%%/ircservices.8
+%%PORTDOCS%%%%DOCSDIR%%/tech/1.html
+%%PORTDOCS%%%%DOCSDIR%%/tech/10.html
+%%PORTDOCS%%%%DOCSDIR%%/tech/11.html
+%%PORTDOCS%%%%DOCSDIR%%/tech/2.html
+%%PORTDOCS%%%%DOCSDIR%%/tech/3.html
+%%PORTDOCS%%%%DOCSDIR%%/tech/4.html
+%%PORTDOCS%%%%DOCSDIR%%/tech/5.html
+%%PORTDOCS%%%%DOCSDIR%%/tech/6.html
+%%PORTDOCS%%%%DOCSDIR%%/tech/7.html
+%%PORTDOCS%%%%DOCSDIR%%/tech/8.html
+%%PORTDOCS%%%%DOCSDIR%%/tech/9.html
+%%PORTDOCS%%%%DOCSDIR%%/tech/a.html
+%%PORTDOCS%%%%DOCSDIR%%/tech/b.html
+%%PORTDOCS%%%%DOCSDIR%%/tech/c.html
+%%PORTDOCS%%%%DOCSDIR%%/tech/d.html
+%%PORTDOCS%%%%DOCSDIR%%/tech/index.html
+%%PORTDOCS%%%%DOCSDIR%%/tech/style.css
 %%PORTDOCS%%%%DOCSDIR%%/upgrade.html
-%%PORTDOCS%%%%DOCSDIR%%/Changes
-%%PORTDOCS%%%%DOCSDIR%%/KnownBugs
-@dirrm lib/services/helpfiles
-@dirrm lib/services/languages
-@dirrm lib/services/modules/chanserv
-@dirrm lib/services/modules/database
-@dirrm lib/services/modules/encryption
-@dirrm lib/services/modules/httpd
-@dirrm lib/services/modules/mail
-@dirrm lib/services/modules/memoserv
-@dirrm lib/services/modules/misc
-@dirrm lib/services/modules/nickserv
-@dirrm lib/services/modules/operserv
-@dirrm lib/services/modules/protocol
-@dirrm lib/services/modules/statserv
-@dirrm lib/services/modules
-@dirrm lib/services
+%%PORTDOCS%%@dirrm %%DOCSDIR%%/tech
 %%PORTDOCS%%@dirrm %%DOCSDIR%%
+@dirrm %%ETCDIR%%/languages
+@dirrm %%ETCDIR%%/helpfiles
+@dirrm %%ETCDIR%%
Comment 9 Wesley Shields freebsd_committer freebsd_triage 2009-07-24 21:36:56 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->wxs

I'll take it.
Comment 10 Wesley Shields freebsd_committer freebsd_triage 2009-07-24 21:38:20 UTC 
A new patch has been submitted for this PR. Can you please take a look
at it and approve it if it is correct?

Thanks!

http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/136602

-- WXS
Comment 11 Wesley Shields freebsd_committer freebsd_triage 2009-07-24 21:38:35 UTC 
State Changed
From-To: suspended->feedback

New patch submitted and pending maintainer review.
Comment 12 Andrey V. Elsukov 2009-07-25 11:36:40 UTC 
25.07.09, 00:38, "Wesley Shields" <wxs@FreeBSD.org>:

> A new patch has been submitted for this PR. Can you please take a look
> at it and approve it if it is correct?
> Thanks!
> http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/136602

Hi, yes, i saw it. I tried to upgrade my services in our network, but
i had some problems after upgrade. I need some time to determine where is
the problem. My services works on 6.2-STABLE-amd64 and after upgrade it
begun drops core dump after start.

-- 
WBR, Andrey V. Elsukov
Comment 13 Terry Sposato 2009-07-26 10:32:38 UTC 
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
 
Andrey,

Have you tried using a vanilla config?
Not sure if there are any changes that need to be made going from
5.0.x to 5.1.x.
I have tried it here on 6-STABLE  and 7.2-RELEASE and it is running
fine for me.

Regards,

Terry
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
 
iEYEARECAAYFAkpsIrYACgkQggJ6ImaGmQqVZACgveh5HerbnimF2NA60PJkK9LN
hXkAmwQ6Q+1vfXVvF4ALAbEMsrak8GOh
=Sjkf
-----END PGP SIGNATURE-----
Comment 14 Andrey V. Elsukov 2009-08-10 10:14:31 UTC 
Terry Sposato wrote:
> Have you tried using a vanilla config?
> Not sure if there are any changes that need to be made going from
> 5.0.x to 5.1.x.
> I have tried it here on 6-STABLE  and 7.2-RELEASE and it is running
> fine for me.

So, sorry for long pause. I tried to upgrade again. Problem was with
russian language support. It's broken in 5.1.x. I think.

I tried build port with IRCSERVICES_LANG=RU and services drops core
after first access. Also i tried build it with EN_US (default) and it works.
But some services messages are not translated (i changed languange from nickserv
command).
I tried build russian language file with addition diagnostic and saw many
warnings about missing strings.

So my question is should I upgrade port or wait before problem will be fixed?

-- 
WBR, Andrey V. Elsukov
Comment 15 Wesley Shields freebsd_committer freebsd_triage 2009-08-15 02:02:30 UTC 
As maintainer of the port it is your decision on if you would like to
update and deal with this bug or wait. Does the bug affect all of the
different language options or is it just RU?

Does the upstream maintainer know about this? Is he working on a fix for
it?

-- WXS
Comment 16 dfilter service freebsd_committer freebsd_triage 2009-08-31 14:51:11 UTC 
wxs         2009-08-31 13:50:55 UTC

  FreeBSD ports repository

  Modified files:
    irc/ircservices      Makefile distinfo pkg-descr pkg-plist 
    irc/ircservices/files ircservices.in 
  Log:
  - Update to 5.1.18
  - Remove support for RU language (maintainer noted it was broken)
  - Update pkg-descr
  
  PR:             ports/136602
  Submitted by:   terry@sucked-in.com
  Approved by:    maintainer timeout
  
  Revision  Changes    Path
  1.40      +13 -8     ports/irc/ircservices/Makefile
  1.27      +3 -3      ports/irc/ircservices/distinfo
  1.2       +5 -4      ports/irc/ircservices/files/ircservices.in
  1.5       +0 -3      ports/irc/ircservices/pkg-descr
  1.7       +44 -82    ports/irc/ircservices/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 17 Wesley Shields freebsd_committer freebsd_triage 2009-08-31 14:51:46 UTC 
State Changed
From-To: feedback->closed

Committed the latest patch after maintainer timeout. I removed the 
documentation on using RU language setting.