Summary: | [libc] [patch] setmode(3) should always set errno on error | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Base System | Reporter: | Yair K. <cesium2> | ||||||
Component: | kern | Assignee: | Pedro F. Giffuni <pfg> | ||||||
Status: | Closed FIXED | ||||||||
Severity: | Affects Only Me | CC: | pfg | ||||||
Priority: | Normal | ||||||||
Version: | 10.0-STABLE | ||||||||
Hardware: | Any | ||||||||
OS: | Any | ||||||||
Attachments: |
|
Description
Yair K.
2009-07-12 00:00:06 UTC
Created attachment 153280 [details]
Patch based on NetBSD
I would prefer to take only the NetBSD approach. We can check later if we should simplify it like OpenBSD did.
Grab PR. A commit references this bug: Author: pfg Date: Sun Feb 22 20:16:45 UTC 2015 New revision: 279186 URL: https://svnweb.freebsd.org/changeset/base/279186 Log: setmode(3): Make sure that setmode sets errno on failure. Our man page already documented this partially but now we have some consistent behavior. PR: 136669 Obtained from: NetBSD (CVS rev. 1.31, 1.33) Relnotes: yes MFC after: 3 weeks Changes: head/lib/libc/gen/setmode.3 head/lib/libc/gen/setmode.c A commit references this bug: Author: pfg Date: Mon Mar 23 19:44:20 UTC 2015 New revision: 280392 URL: https://svnweb.freebsd.org/changeset/base/280392 Log: MFC r279186: setmode(3): Make sure that setmode sets errno on failure. Our man page already documented this partially but now we provide more consistent behavior. PR: 136669 Obtained from: NetBSD (CVS rev. 1.31, 1.33) Relnotes: yes Changes: _U stable/10/ stable/10/lib/libc/gen/setmode.3 stable/10/lib/libc/gen/setmode.c Committed and MFC'd. Thanks! |