Bug 13676

Summary: usr.bin/more/Makefile is broken
Product: Base System Reporter: Garrett A. Wollman <wollman>
Component: binAssignee: freebsd-bugs (Nobody) <bugs>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: 3.0-CURRENT   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Garrett A. Wollman 1999-09-10 05:00:00 UTC
	more's Makefile erroneously uses ${ECHO}

How-To-Repeat: 
	cd /usr/src/usr.bin/more; make -s
Comment 1 Sheldon Hearn 1999-09-10 08:26:14 UTC
On Thu, 09 Sep 1999 23:50:40 -0400, Garrett Wollman wrote:

> 	more's Makefile erroneously uses ${ECHO}

Why is it erroneous?

> 	-	@${ECHO} '#define DEFRC "\' >> ${.TARGET}
> 	+	echo '#define DEFRC "\' >> ${.TARGET}

Okay, so you want the echo commands to be displayed. What else is wrong
with using just ${ECHO} ?

Ciao,
Sheldon.
Comment 2 ru freebsd_committer freebsd_triage 1999-09-10 08:39:57 UTC
State Changed
From-To: open->closed

Identical patch applied. 

Comment 3 Sheldon Hearn 1999-09-10 08:42:22 UTC
On Fri, 10 Sep 1999 10:38:08 +0300, Ruslan Ermilov wrote:

> Because ${ECHO} == "true" in `make -s' case, see /usr/share/mk/bsd.sys.mk.

Knew there must be something. ;-)

Thanks,
Sheldon.
Comment 4 Ruslan Ermilov 1999-09-10 08:47:12 UTC
On Fri, Sep 10, 1999 at 09:42:22AM +0200, Sheldon Hearn wrote:
> 
> 
> On Fri, 10 Sep 1999 10:38:08 +0300, Ruslan Ermilov wrote:
> 
> > Because ${ECHO} == "true" in `make -s' case, see /usr/share/mk/bsd.sys.mk.
> 
> Knew there must be something. ;-)
> 
Except it is in /usr/share/mk/sys.mk :-!

-- 
Ruslan Ermilov		Sysadmin and DBA of the
ru@ucb.crimea.ua	United Commercial Bank,
ru@FreeBSD.org		FreeBSD committer,
+380.652.247.647	Simferopol, Ukraine

http://www.FreeBSD.org	The Power To Serve
http://www.oracle.com	Enabling The Information Age
Comment 5 Sheldon Hearn 1999-09-10 08:50:58 UTC
On Fri, 10 Sep 1999 10:47:12 +0300, Ruslan Ermilov wrote:

> Except it is in /usr/share/mk/sys.mk :-!

Yah? So where does bsd.prog.mk get sucked in via bsd.prog.mk?

Ciao,
Sheldon.