Bug 136793
| Summary: | Update port: security/luasec - Link against OpenSSL from ports | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Andrew Lewis <freeghb> | ||||||||||||
| Component: | Individual Port(s) | Assignee: | Dmitry Marakasov <amdmi3> | ||||||||||||
| Status: | Closed FIXED | ||||||||||||||
| Severity: | Affects Only Me | ||||||||||||||
| Priority: | Normal | ||||||||||||||
| Version: | Latest | ||||||||||||||
| Hardware: | Any | ||||||||||||||
| OS: | Any | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Andrew Lewis
2009-07-15 15:30:02 UTC
Responsible Changed From-To: freebsd-ports-bugs->amdmi3 I'll take it. State Changed From-To: open->feedback Could you please send an update as a patch. Also, won't it make sence to define USE_OPENSSL_PORT conditionally only for older FreeBSD versions? Afair there were some problems building ports when openssl is installed from ports as well. Attached: luasec.Makefile.patch.txt: Patch for security/luasec to use OpenSSL from ports - for older versions of FreeBSD only as suggested. patch-src-Makefile: To go in 'files', patch to luasec Makefile to respect CC, CFLAGS patch-src-ssl.c: To go in 'files', patch from Matthew Wild to fix a bug in luasec. [10:30:51] <MattJ> Without the patch the tests fail about 1/3 of the time [10:31:14] <MattJ> with it, I've run it in a loop for some time and still not had the error [10:32:18] <Nick> sounds promising [10:51:06] <MattJ> Nick, http://prosody.im/patches/luasec-clear-error- queue.patch [prosody.im] [10:52:05] <Nick> that simple, eh? :D [10:52:14] <MattJ> That simple :) [10:52:29] <MattJ> It turns out that an OpenSSL API call can return multiple errors [10:52:36] <MattJ> they are on a kind of stack [10:52:57] <MattJ> I suspect that some internal function sometimes adds an extra error [10:53:07] <MattJ> But LuaSec only pops the first error from the stack [10:53:33] <MattJ> The OpenSSL docs say you should ensure the error stack is empty before entering an API call [10:53:48] <MattJ> otherwise SSL_get_error() which LuaSec uses will not work properly [10:55:20] <Nick> mm, seems reasonable I think any FreeBSD version 700024 or later should work with the base OpenSSL. Kelly > luasec.Makefile.patch.txt: Patch for security/luasec to use OpenSSL from
> ports - for older versions of FreeBSD only as suggested.
Updated.
State Changed From-To: feedback->closed Committed, with minor changes. Thanks! amdmi3 2009-07-20 16:53:17 UTC
FreeBSD ports repository
Modified files:
security/luasec Makefile
Added files:
security/luasec/files patch-Makefile patch-src-Makefile
patch-src-ssl.c
Log:
- Respect CC/CFLAGS
- Use openssl from ports for older FreeBSD versions
- Add a patch to handle openssl errors properly
- While here, fix building with custom PREFIX/LOCALBASE
PR: 136793
Submitted by: Andrew Lewis <freeghb@gmail.com> (maintainer)
Revision Changes Path
1.3 +13 -1 ports/security/luasec/Makefile
1.1 +11 -0 ports/security/luasec/files/patch-Makefile (new)
1.1 +27 -0 ports/security/luasec/files/patch-src-Makefile (new)
1.1 +26 -0 ports/security/luasec/files/patch-src-ssl.c (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
|
