Bug 136870

Comment 1 Edwin Groothuis 2009-07-17 15:50:09 UTC

Maintainer of misc/e2fsprogs-libuuid,

Please note that PR ports/136870 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/136870

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org

Comment 2 Edwin Groothuis 2009-07-17 15:50:11 UTC

State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)

* Matthias Andree (matthias.andree@gmx.de) wrote:

> Please retry with 1.41.8 (recently updated) and if it still fails, send me  
> a log of the failure.

It is 1.41.8, actually I've got it while updating.

amdmi3@hades:e2fsprogs-libuuid% make -VMAKE_JOBS_NUMBER
3
amdmi3@hades:e2fsprogs-libuuid% make -VPORTVERSION     
1.41.8

Btw, seems like it does not affect e2fsprogs, but it does affect
e2fsprogs-libblkid. Logs are attached.

-- 
Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
amdmi3@amdmi3.ru  ..:  jabber: amdmi3@jabber.ru    http://www.amdmi3.ru

Comment 4 Dmitry Marakasov 2009-07-17 16:41:07 UTC

Responsible Changed
From-To: freebsd-ports-bugs->amdmi3

I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=136870 
 
Date: Fri, 17 Jul 2009 16:48:10 +0200

JFTR: I've previously requested to retry with the updated port (update  
sysutils/e2fsprogs and this port to 1.41.8 from up-to-date ports tree) and  
post the log if it still fails.

-- 
Matthias Andree

Hi Dmitry,

does the attached patch help? Apparently the sub-jobs are stomping over
each other when creating subst, so we'll just do that in pre-build.

The patch is also inlined below, if you find that more convenient.

(Probably the faster machine where I made the patch on didn't exhibit
the problem since it could build subst faster than the other directories
figure that it was missing, so I didn't see this during testing...)

Please test and let me know what you find.

Thanks.

Best regards
Matthias



Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/misc/e2fsprogs-libuuid/Makefile,v
retrieving revision 1.11
diff -u -r1.11 Makefile
--- Makefile	16 Jul 2009 21:41:38 -0000	1.11
+++ Makefile	17 Jul 2009 16:32:55 -0000
@@ -43,6 +43,7 @@
 
 pre-build:
 	${MKDIR} ${WRKSRC}/lib/uuid/elfshared
+	cd ${WRKSRC}/util && ${GMAKE} subst
 
 # ulimit guards against runaway tests
 # failure to launch uuidd is fine (one might be running, or we may lack

* Matthias Andree (matthias.andree@gmx.de) wrote:

> does the attached patch help? Apparently the sub-jobs are stomping over
> each other when creating subst, so we'll just do that in pre-build.
> 
> The patch is also inlined below, if you find that more convenient.
> 
> (Probably the faster machine where I made the patch on didn't exhibit
> the problem since it could build subst faster than the other directories
> figure that it was missing, so I didn't see this during testing...)
> 
> Please test and let me know what you find.

It seems to be fixed now.

-- 
Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
amdmi3@amdmi3.ru  ..:  jabber: amdmi3@jabber.ru    http://www.amdmi3.ru

Dmitry Marakasov wrote:
> Mark MAKE_JOBS_UNSAFE, it fails with forced jobs. Note that this is likely applicable to master port, sysutils/e2fsprogs.
I agree about the master port,

Dmitry, could you please commit my patch? People start reporting  
duplicates ;-) (ports/136920)

-- 
Matthias Andree

Comment 10 dfilter service 2009-07-20 16:28:29 UTC

amdmi3      2009-07-20 15:28:20 UTC

  FreeBSD ports repository

  Modified files:
    misc/e2fsprogs-libuuid Makefile 
  Log:
  - Fix parallel build
  
  PR:             136870
  Submitted by:   myself
  Patch by:       Matthias Andree <matthias.andree@gmx.de> (maintainer)
  
  Revision  Changes    Path
  1.12      +1 -0      ports/misc/e2fsprogs-libuuid/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"

Comment 11 Dmitry Marakasov 2009-07-20 16:29:30 UTC

State Changed
From-To: feedback->closed

Committed. Thanks!