Bug 137955

Comment 1 Dmitry Marakasov 2009-08-19 15:10:14 UTC

Responsible Changed
From-To: freebsd-ports-bugs->amdmi3

I'll take it.

>
> I've cleaned port up a bit. It uses standard GNU configure, so
> there's no need for many options and redefined targets.
>    
Thank you for the hint. This is my first port, and I still do not 
understand all the features of construction of ports. I still study.
> Also, MAINTAINER email is different from the one from which PR was
> submitted. Is this ok, i.e. are these both your emails and are further
> port updates planned to be submitted from MAINTAINER email?
>
>    
Sorry, these two addresses belong to me. I had planned to support the 
use of address ffault@gmail.com. But the PR to send a test computer, 
which was set up only the second address.
What should I do to fix this?
> --- Makefile begins here ---
> # New ports collection makefile for:    dhcdrop
> # Date created:         Aug 9 2009
> # Whom:                 Nick F
> #
> # $FreeBSD$
> #
>
> PORTNAME=	dhcdrop
> PORTVERSION=	0.5
> CATEGORIES=	net-mgmt sysutils
> MASTER_SITES=	http://www.netpatch.ru/projects/dhcdrop/
>
> MAINTAINER=	ffault@gmail.com
> COMMENT=	Tool for searching and suppressing false DHCP servers
>
> USE_BZIP2=	yes
> GNU_CONFIGURE=	yes
>
> MAN8=		${PORTNAME}.8
> MANLANG=	"" ru
>
> PLIST_FILES=	sbin/dhcdrop
>
> OPTIONS=	STATIC "Build a static version of dhcdrop" off
>
> .include<bsd.port.options.mk>
>
> .if defined(WITH_STATIC)
> CONFIGURE_ARGS+=--enable-static-build
> .endif
>
> .include<bsd.port.mk>
> --- Makefile ends here ---
>
>

* Babinski Nick (nick@malbi.dp.ua) wrote:

> > I've cleaned port up a bit. It uses standard GNU configure, so
> > there's no need for many options and redefined targets.
> >    
> Thank you for the hint. This is my first port, and I still do not 
> understand all the features of construction of ports. I still study.

So I take it as you're OK with changes. Don't hesitate to ask if
you have any questions.

> > Also, MAINTAINER email is different from the one from which PR was
> > submitted. Is this ok, i.e. are these both your emails and are further
> > port updates planned to be submitted from MAINTAINER email?
> >
> Sorry, these two addresses belong to me. I had planned to support the 
> use of address ffault@gmail.com. But the PR to send a test computer, 
> which was set up only the second address.

Everything is good then. The procedure is as follows: if the update to a
port comes from email different to what is listed in MAINTAINER,
maintainer is asked for approval first (with 2 week timeout). So if
you're planning to use different email, it may slow things down.
However, if you're planning to use ffault@gmail.com, there's no problem.
I'll be committing the port now.

-- 
Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
amdmi3@amdmi3.ru  ..:  jabber: amdmi3@jabber.ru    http://www.amdmi3.ru

Comment 4 dfilter service 2009-08-19 16:46:16 UTC

amdmi3      2009-08-19 15:46:08 UTC

  FreeBSD ports repository

  Modified files:
    net-mgmt             Makefile 
  Added files:
    net-mgmt/dhcdrop     Makefile distinfo pkg-descr 
  Log:
  DHCDROP - utility for tracing and neutralizing(blocking) fake DHCP
  servers in Ethernet. Supports various modes. Theres possibility
  to set outgoing MAC addresses and optional settings in generated
  DHCP requests. Supports legal DHCP servers list. One can run it
  in interactive mode under users control or fully automatic mode for
  start up from script.
  
  WWW: http://www.netpatch.ru/en/dhcdrop.html
  
  PR:             137955
  Submitted by:   Babinski Nick <nick@malbi.dp.ua>
  
  Revision  Changes    Path
  1.198     +1 -0      ports/net-mgmt/Makefile
  1.1       +32 -0     ports/net-mgmt/dhcdrop/Makefile (new)
  1.1       +3 -0      ports/net-mgmt/dhcdrop/distinfo (new)
  1.1       +8 -0      ports/net-mgmt/dhcdrop/pkg-descr (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"

Comment 5 Dmitry Marakasov 2009-08-19 16:46:30 UTC

State Changed
From-To: open->closed

New port added, with minor changes. Thanks!