Bug 13807
| Summary: | data-sensitivity buglet in 'make release' BUILDNAME | ||
|---|---|---|---|
| Product: | Base System | Reporter: | wilko <wilko> |
| Component: | misc | Assignee: | jkh |
| Status: | Closed FIXED | ||
| Severity: | Affects Only Me | ||
| Priority: | Normal | ||
| Version: | 3.3-STABLE | ||
| Hardware: | Any | ||
| OS: | Any | ||
Responsible Changed From-To: freebsd-bugs->jkh Over to Release manager State Changed From-To: open->closed I don't think it's really worth the effort to fix this. :) |
The BUILDNAME shell variable that is fed to 'make release' is sensitive to the data it is set to. 'Appropriate' data makes the 'make release' build fail: echo "echo make release Finished" >> /local2/Gen/mk chmod 755 /local2/Gen/mk chroot /local2/Gen /mk + _RELTARGET=doRELEASE + export CFLAGS=-O -pipe + export DISTRIBUTIONS=bin manpages catpages games proflibs dict info doc compat1x compat20 compat21 compat22 krb des /mk: 6: Syntax error: "(" unexpected *** Error code 2 Fix: I suppose properly escaping the variable assignments while generating the /mk file will do the trick. How-To-Repeat: make release NODOC=YES NOPORTS=YES CHROOTDIR=/local2/Gen BUILDNAME="FreeBSD-3.3-release (wkb; 180999)" RELEASETAG="RELENG_3_3_RELEASE" The offensive characters are () and most likely ; in the BUILDNAME variable The resulting /mk file has: export DISTRIBUTIONS="bin manpages catpages games proflibs dict info doc compat1x compat20 compat21 compat22 krb des" export BUILDNAME=FreeBSD-3.3-release (wkb; 180999) export VNDEVICE=vn0