Bug 138179

Summary: Fix sysutils/serpentine to not require muine
Product: Ports & Packages Reporter: Kevin Oberman <oberman>
Component: Individual Port(s)Assignee: Philip M. Gollucci <pgollucci>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Kevin Oberman 2009-08-25 19:00:02 UTC 
The muine port "is marked as broken: doesn't build and is apparently
unmaintained", but serpentine, due to an error in the Makefile, always
requires it, whether the MUINE option is set. (It defaults to 'off'.)
This makes serpentine and ports depending on it a dependency on the
broken muine port.

How-To-Repeat: Build serpentine with default (or any) config options
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2009-08-25 19:50:43 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->ahze

Fix synopsis and assign.
Comment 2 Kevin Oberman 2009-08-27 05:36:04 UTC 
My analysis abd recommended fix were in error. the correct fix is:
--- Makefile.orig	2009-08-26 21:33:06.000000000 -0700
+++ Makefile	2009-08-26 21:34:39.000000000 -0700
@@ -29,7 +29,7 @@
 
 .include <bsd.port.pre.mk>
 
-.if (defined(WITH_MUINE) || exists(${LOCALBASE}/bin/muine)) &&
${ARCH}=="i386"
+.if defined(WITH_MUINE) && ${ARCH}=="i386"
 BUILD_DEPENDS+=	muine:${PORTSDIR}/audio/muine
 RUN_DEPENDS+=	muine:${PORTSDIR}/audio/muine
 PLIST_SUB+=	MUINE=""
-- 
R. Kevin Oberman
Energy Sciences Network (ESnet)
Ernest Orlando Lawrence Berkeley National Laboratory (Berkeley Lab)
E-Mail: oberman@es.net                       Phone: +1 510-486-8634
Comment 3 Mark Linimon freebsd_committer freebsd_triage 2010-07-26 01:22:54 UTC 
Responsible Changed
From-To: ahze->freebsd-ports-bugs

Maintainer was reset. 

To submitter: would you be interested in taking over this port?
Comment 4 Philip M. Gollucci freebsd_committer freebsd_triage 2010-09-13 02:35:34 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->pgollucci

I will take it
Comment 5 dfilter service freebsd_committer freebsd_triage 2010-09-14 03:39:50 UTC 
pgollucci    2010-09-14 02:39:45 UTC

  FreeBSD ports repository

  Modified files:
    sysutils/serpentine  Makefile 
  Log:
  - Fix muine dependency which is not required and only usable on i386
  
  PR:             ports/138179
  Reported by:    Kevin Oberman <oberman@es.net>
  
  Revision  Changes    Path
  1.25      +8 -5      ports/sysutils/serpentine/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Philip M. Gollucci freebsd_committer freebsd_triage 2010-09-14 03:39:51 UTC 
State Changed
From-To: open->closed

Committed, Thanks!