Summary: | Cannot compile ports/irc/kvirc-devel | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Andrei V. Lavreniyuk <andy.lavr> | ||||
Component: | Individual Port(s) | Assignee: | Max Brazhnikov <makc> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Only Me | ||||||
Priority: | Normal | ||||||
Version: | Latest | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
Description
Andrei V. Lavreniyuk
2009-09-15 07:10:04 UTC
Maintainer of irc/kvirc-devel, Please note that PR ports/138832 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/138832 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool) > Maintainer of irc/kvirc-devel, > > Please note that PR ports/138832 has just been submitted. > > If it contains a patch for an upgrade, an enhancement or a bug fix > you agree on, reply to this email stating that you approve the patch > and a committer will take care of it. > > The full text of the PR can be found at: > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/138832 > > -- > Edwin Groothuis via the GNATS Auto Assign Tool > edwin@FreeBSD.org > Can you try upgrading it manually ? As testing resulted in 0 problems http://tinderbox.officialunix.com/logs/7.2-FreeBSD/kvirc-devel-4.0rc1.log Try moving svn to svn.bak and trying to upgrade it, since I wont find svn it wont bother adding the rev. please let me know if this work so I can make a patch, regardless later today I will do some testing outside the tinderbox. -- Chris Petrik WWW: http://www.officialunix.com FreeBSD Ports Contributor. Responsible Changed From-To: freebsd-ports-bugs->makc could you please take a look? I can not reproduce this error, this issue could be the fact that this is a rc1 snapshot and the cmakefiles requires or wants a svn working copy. Since I only tried it using svn 3464, and rc1 I doubt that is the reason. This is not a 8.x issues or else it would of been a compiler error rather a cmake error. The error is here, simple to read: -- Found Subversion CMake Error at /usr/local/share/cmake/Modules/FindSubversion.cmake:83 (MESSAGE): Command "/usr/local/bin/svn info /usr/ports/irc/kvirc-devel/work/kvirc-4.0rc1" failed with output: svn: '/usr/ports/irc/kvirc-devel/work/kvirc-4.0rc1' is not a working copy Call Stack (most recent call first): CMakeLists.txt:59 (Subversion_WC_INFO) ----- -- Patching for FreeBSD... -- Found shared-mime-info version: 0.60 -- Configuring incomplete, errors occurred! *** Error code 1 Stop in /usr/ports/irc/kvirc-devel. *** Error code 1 I will see if I can remove the SVN test and should fix the issues. Christopher Petrik http://www.officialunix.com Random Quote of the day: Hi! If rename /usr/local/bin/svn to svn.bak then compile fine. -- Best regards, Andrei V. Lavreniyuk. Hello, I have made a modification to the port that should remedy this issue, regardless if svn is installed or not. The thing is/was the fact that since this is still a snapshot they didn't disable the check for svn. That said there is an option to add in the rev by hand -DMANUAL_REVISION=3459 and this disabled the check as it already has the svn rev. I am currently complaining why this check is/was not disabled but they don't seem to be bothered by it, it is still "dev" code to some extent :) If you want you can try this patch that I will upload to: http://files.officialunix.com/patch-kvirc-devel-fix-svn Please give me couple mins to upload the patch. Christopher Petrik http://www.officialunix.com Random Quote of the day: Joan Crawford<http://www.brainyquote.com/quotes/authors/j/joan_crawford.html> - "I, Joan Crawford, I believe in the dollar. Everything I earn, I spend." Hi! --- http://files.officialunix.com/patch-kvirc-devel-fix-svn Not Found The requested URL /patch-kvirc-devel-fix-svn was not found on this server. --- Patch WITH_KDE4 --- --- Makefile.orig 2009-09-15 13:51:43.000000000 +0300 +++ Makefile 2009-09-16 20:43:05.000000000 +0300 @@ -22,7 +22,6 @@ QT_COMPONENTS= moc_build qmake_build rcc_build uic_build \ dbus webkit gui network sql xml USE_CMAKE= yes -CMAKE_ARGS= -DWITHOUT_ESD=yes -DWITHOUT_DOXYGEN=yes INSTALLS_ICONS= yes CONFLICTS= kvirc-3.4.* @@ -32,9 +31,16 @@ OPTIONS= AUDIOFILE "Compile with libaudiofile dependency" on \ DEBUG "Compile with debug support" off \ GSM "Compile with gsm support" off \ - KDE4 "Compile with KDE4 support (broken)" off \ + KDE4 "Compile with KDE4 support" off \ PHONON "Compile with phonon support" on +.include <bsd.port.options.mk> + +.if defined(WITH_KDE4) +USE_KDE4+= kdelibs kdeprefix +CMAKE_ARGS+= -DWITH_KDE4=yes +.endif + .include <bsd.port.pre.mk> .if defined(WITH_AUDIOFILE) @@ -53,11 +59,6 @@ CMAKE_ARGS+= -DWITHOUT_GSM=yes .endif -.if defined(WITH_KDE4) -USE_KDE4+= kdelibs kdeprefix -CMAKE_ARGS+= -DWITH_KDE4=yes -.endif - .if defined(WITH_PHONON) QT_COMPONENTS+= phonon CMAKE_ARGS+= -DKDE4_LIB_INSTALL_DIR=${KDE4_PREFIX}/lib \ @@ -66,6 +67,8 @@ CMAKE_ARGS+= -DWITHOUT_PHONON=yes .endif +CMAKE_ARGS= -DWITHOUT_ESD=yes -DWITHOUT_DOXYGEN=yes + post-configure: @${MV} ${WRKSRC}/data/protocols/irc.protocol ${WRKSRC}/data/protocols/kvirc.protocol @${MV} ${WRKSRC}/data/protocols/irc6.protocol ${WRKSRC}/data/protocols/kvirc6.protocol --- -- Best regards, Andrei V. Lavreniyuk. Hello, I am fixing my cvs repo perm issue, What exacly does the above patch do/fix heh? I will post a patch after this perm issue is resolved. Christopher Petrik http://www.officialunix.com Random Quote of the day: Stephen Leacock<http://www.brainyquote.com/quotes/authors/s/stephen_leacock.html> - "I detest life-insurance agents: they always argue that I shall some day die, which is not so." Hello, The patch is now uploaded, please test. Sorry for the delay :) http://files.officialunix.com/patch-kvirc-devel-fix-svn Christopher Petrik http://www.officialunix.com Random Quote of the day: Pablo Picasso<http://www.brainyquote.com/quotes/authors/p/pablo_picasso.html> - "Computers are useless. They can only give you answers." Patch. -- Chris Petrik Consulting: http://www.officialunix.com BSD Site: http://www.bsdjunk.com FreeBSD ports contributor Since 18-July-2009 Hi! Gud patch. Compile fine. Please commit to ports. Big thanks! -- Best regards, Andrei V. Lavreniyuk. Hello, Patch works fine, please commit. Christopher Petrik http://www.officialunix.com Random Quote of the day: Stephen Leacock<http://www.brainyquote.com/quotes/authors/s/stephen_leacock.html> - "I detest life-insurance agents: they always argue that I shall some day die, which is not so." makc 2009-09-18 06:07:33 UTC FreeBSD ports repository Modified files: irc/kvirc-devel Makefile pkg-plist Log: - Fix build when subversion is installed [1] - Allow build with KDE4 [2] - fix build on 6.x - sort plist PR: ports/138832 Submitted by: Andrei Lavreniyuk [2] Patched by: Chris Petrik (maintainer) [1],[2] Feature safe: yes Revision Changes Path 1.60 +24 -8 ports/irc/kvirc-devel/Makefile 1.18 +93 -91 ports/irc/kvirc-devel/pkg-plist _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org" State Changed From-To: feedback->closed Committed, with minor changes. Thanks! |