Bug 138913

Summary: [Maintainer Update] port mail/spamd correct bad startup script
Product: Ports & Packages Reporter: Olli Hauer <ohauer>
Component: Individual Port(s)Assignee: Dmitry Marakasov <amdmi3>
Status: Closed FIXED    
Severity: Affects Only Me CC: ohauer
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch_mail_spamd_4.5.0_2.txt none

Description Olli Hauer 2009-09-17 20:40:01 UTC 
It seems I tested the last patch for PR ports/137992 not correct.
The statement 'if [ $? ]; then' is missing a -eq and so it results
every time to the first case (blacklist only), wich is really bad
for every one using spamd in greylist mode.

Please commit the following patch to resolve this issue.
Additional set my mail in pkg-descr.

Regards,
olli
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2009-09-17 20:40:11 UTC 
Class Changed
From-To: update->maintainer-update

Fix category (submitter is maintainer) (via the GNATS Auto Assign Tool)
Comment 2 Dmitry Marakasov freebsd_committer freebsd_triage 2009-09-20 15:53:14 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->amdmi3

I'll take it.
Comment 3 Dmitry Marakasov 2009-09-20 15:59:41 UTC 
* olli hauer (ohauer@gmx.de) wrote:

> --- pkg-descr.orig
> +++ pkg-descr
> @@ -18,4 +18,4 @@
>  
>  WWW: http://freebsdspamd.berlios.de/
>  
> --Alex <samm@os2.kiev.ua>
> +olli hauer <ohauer@gmx.de>

I suggest we drop that line instead. It's meaning is like `who wrote
the pkg-descr', and actually I don't see any purpose for it, and
there's definitely no need to duplicate maintainer there.

-- 
Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
amdmi3@amdmi3.ru  ..:  jabber: amdmi3@jabber.ru    http://www.amdmi3.ru
Comment 4 Olli Hauer 2009-09-20 16:15:49 UTC 
>> --Alex <samm@os2.kiev.ua>
>> +olli hauer <ohauer@gmx.de>
>
> I suggest we drop that line instead. It's meaning is like `who wrote
> the pkg-descr', and actually I don't see any purpose for it, and
> there's definitely no need to duplicate maintainer there.

I agree

//olli
Comment 5 Dmitry Marakasov freebsd_committer freebsd_triage 2009-09-20 19:54:46 UTC 
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!
Comment 6 dfilter service freebsd_committer freebsd_triage 2009-09-20 19:54:54 UTC 
amdmi3      2009-09-20 18:54:39 UTC

  FreeBSD ports repository

  Modified files:
    mail/spamd           Makefile pkg-descr 
    mail/spamd/files     obspamd.in 
  Log:
  - Fix startup script
  
  PR:             138913
  Submitted by:   olli hauer <ohauer@gmx.de> (maintainer)
  Feature safe:   yes
  
  Revision  Changes    Path
  1.18      +1 -1      ports/mail/spamd/Makefile
  1.6       +2 -2      ports/mail/spamd/files/obspamd.in
  1.5       +0 -2      ports/mail/spamd/pkg-descr
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"