| Summary: | 'make release' fails in some cases | ||
|---|---|---|---|
| Product: | Base System | Reporter: | Makoto Matsushita <matusita> |
| Component: | bin | Assignee: | freebsd-bugs (Nobody) <bugs> |
| Status: | Closed FIXED | ||
| Severity: | Affects Only Me | CC: | jkh |
| Priority: | Normal | ||
| Version: | 4.0-CURRENT | ||
| Hardware: | Any | ||
| OS: | Any | ||
State Changed From-To: open->closed Fixed by jkh in rev 1.514 of release/Makefile. Thanks for noticing! |
target 'release.1' of src/release/Makefile says: # Clean out ${_R} and make the directory structure. release.1: mkdir -p ${_R} rm -rf ${_R}/* 2> /dev/null -chflags -R noschg ${_R}/. rm -rf ${_R}/* "mkdir -p, rm -rf, chflags, then rm -rf again" is the common way to get clean directory. In this way, the first rm(1) may exit with non-zero status; but this Makefile does not consider such a situation. I dunno when, but current 4.0-RELEASE of ${_R}/stage/trees has some schg-ed files (3.3-STABLE does not have such files). Fix: Ignore exit status of first rm(1), maybe. How-To-Repeat: do 'make release' twice.