Bug 139374

Summary: [patch] graphics/xpdf fix build with lesstif
Product: Ports & Packages Reporter: dirk.meyer <dirk.meyer>
Component: Individual Port(s)Assignee: Marcelo Araujo <araujo>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description dirk.meyer 2009-10-06 09:00:11 UTC 
	xdpf does not build with lesstif.
	Error mesasge:
In file included from XPDFApp.cc:18:
XPDFViewer.h:338: error: 'nColorMenuItems' was not declared in this scope

	bails out at:
	[...]
#if USE_COMBO_BOX
  Widget zoomComboBox;
#else
  Widget zoomMenu;
  Widget zoomMenuBtns[nZoomMenuItems];
  Widget colorMenuBtns[nColorMenuItems];
#endif
	[...]

	nColorMenuItems is not defined at all,
	neither in lestif nor in open-motif itself.

	The following detection stuff is wrong.
	[...]
#if (XmVERSION >= 2 && !defined(LESSTIF_VERSION))
#  define USE_COMBO_BOX 1
#else
#  undef USE_COMBO_BOX
#endif
	[...]

	Problem reported at 08th Nov 2008
	To: araujo@freebsd.org 
	Feedback received at 10th Nov 2008
	Details reported at 11th Nov 2008

Fix: a) fix the patch-zz-xpdf-annot.20080728a
	   by removing "!defined(LESSTIF_VERSION))" in XPDFViewer.h

	b) or Apply this patch.
How-To-Repeat: 
	pkg_add lesstif-0.95.2_1,2.tbz
	cd /usr/ports/graphics/xpdf && make WANT_LESTIF=1
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2009-10-06 09:00:22 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->araujo

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2009-10-20 12:16:36 UTC 
araujo      2009-10-20 11:16:27 UTC

  FreeBSD ports repository

  Modified files:
    graphics/xpdf        Makefile distinfo 
  Log:
  - Fix compatibility with lesstif. [1]
  - Add a new patch to fix multiple vulnerabilities. [2]
  - Bump PORTREVISION.
  
  PR:             ports/139374 [1], ports/139782 [2]
  Submitted by:   dirk.meyer@dinoex.sub.org [1],
                  Sylvio Cesar <scjamorim@bsd.com.br> [2]
  http://www.vuxml.org/freebsd/8581189c-bd5f-11de-8709-0017a4cccfc6.html
  
  Revision  Changes    Path
  1.92      +7 -2      ports/graphics/xpdf/Makefile
  1.31      +3 -0      ports/graphics/xpdf/distinfo
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Marcelo Araujo freebsd_committer freebsd_triage 2009-10-20 12:16:51 UTC 
State Changed
From-To: open->closed

Committed. Thanks!