Bug 140139

Summary: irc/bitchx: syntax error in configure script
Product: Ports & Packages Reporter: Jilles Tjoelker <jilles>
Component: Individual Port(s)Assignee: Dmitry Marakasov <amdmi3>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
irc-bitchx-syntaxfix.patch none

Description Jilles Tjoelker freebsd_committer freebsd_triage 2009-10-31 15:00:12 UTC 
Due to a change in /bin/sh a mismatched single quote inside backticks
(`...`) now causes configure to fail.

Fix: Apply this patch to the port Makefile.
How-To-Repeat: Try to build the port with a /bin/sh with r197691 change in it.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2009-10-31 15:00:20 UTC 
Maintainer of irc/bitchx,

Please note that PR ports/140139 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/140139

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2009-10-31 15:00:22 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Martin Wilke freebsd_committer freebsd_triage 2009-10-31 15:01:11 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->miwi

I'll take it.
Comment 4 Chris Petrik 2009-10-31 16:44:18 UTC 
Would this not cause problems with non current?

Think it would be better to add this into a version statement instead of
adding it to bottom of the makefile.
Comment 5 Chris Petrik 2009-10-31 17:38:34 UTC 
Please change the severity and priority to normal, this issue is with
current and not one of the released versions of FreeBSD, so this should be
changed.
Comment 6 Jilles Tjoelker freebsd_committer freebsd_triage 2009-10-31 22:10:04 UTC 
The patch should not cause problems for older versions of FreeBSD.

More precisely, the problem is this line in configure:
            system="MP-RAS-`$AWK '{print }' /etc/.relid'`"

There is no matching closing quote for the single quote after relid.
My patch removes that single quote.

Older versions of FreeBSD /bin/sh assume a closing quote before the
ending backtick.

Many other shells do not mind this because the line is rarely executed.
Some of them would abort if a case would arise where the line is executed.
However, I think it is helpful in creating/debugging shell scripts if
errors are detected as early as possible.

By the way, if upstream is still alive, ask them to apply the patch or
to update that part of the configure script from whereever they got it
from (I don't think they wrote it themselves).

-- 
Jilles Tjoelker
Comment 7 Chris Petrik 2009-10-31 22:47:10 UTC 
Ahh ok, makes sense.

I will see what the BX devs say.
Comment 8 Dmitry Marakasov freebsd_committer freebsd_triage 2009-11-05 02:40:44 UTC 
Responsible Changed
From-To: miwi->amdmi3

Take with miwi's approval
Comment 9 Dmitry Marakasov freebsd_committer freebsd_triage 2009-11-05 02:55:55 UTC 
State Changed
From-To: feedback->closed

Close in favor of ports/140274, with miwi's approval