Bug 140249

Summary: [PATCH] Unable to fetch distfiles of archivers/unzip
Product: Ports & Packages Reporter: Denny Lin <dennylin93>
Component: Individual Port(s)Assignee: Andrey A. Chernov <ache>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
unzip.patch none

Description Denny Lin 2009-11-03 15:30:03 UTC
Unable to fetch distfiles. MASTER_SITES seems to have a problem.

Fix: Add "\" in front of "(" and ")" (see patch).

	
How-To-Repeat: # cd /usr/ports/archivers/unzip && make fetch
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2009-11-03 15:39:10 UTC
Responsible Changed
From-To: freebsd-ports-bugs->ache

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Andrey A. Chernov freebsd_committer freebsd_triage 2009-11-04 12:24:43 UTC
State Changed
From-To: open->feedback

Something is wrong on your side, you should investigate (I can't reproduce it). 
I got them without any additional slashesh, moreover, () are valid URL chars. 

# make fetch 

Use INSTALL_AS_INFOUNZIP=yes to install Info Unzip as /usr/local/bin/info-unzip 

=> unzip60.tar.gz doesn't seem to exist in /usr/ports/distfiles/. 
=> Attempting to fetch from  
http://heanet.dl.sourceforge.net/project/infozip/UnZip%206.x%20(latest)/UnZip%206.0/. 
unzip60.tar.gz                                100% of 1344 kB  825 kBps 
=> unreduce_full.zip doesn't seem to exist in /usr/ports/distfiles/. 
=> Attempting to fetch from  
http://heanet.dl.sourceforge.net/project/infozip/UnZip%205.x%20and%20earlier/5.51/. 
unreduce_full.zip                             100% of 2849  B 1187 kBps
Comment 3 Denny Lin 2009-11-04 15:15:28 UTC
I've found the problem. The following lines are in my /etc/make.conf:
MASTER_SITE_BACKUP?= \
http://ftp.tw.freebsd.org/pub/FreeBSD/distfiles/${DIST_SUBDIR}/ \
ftp://ftp.tw.freebsd.org/pub/FreeBSD/distfiles/${DIST_SUBDIR}/ \
http://ftp2.tw.freebsd.org/pub/FreeBSD/distfiles/${DIST_SUBDIR}/ \
ftp://ftp2.tw.freebsd.org/pub/FreeBSD/distfiles/${DIST_SUBDIR}/ \
ftp://ftp4.freebsd.org/pub/FreeBSD/distfiles/${DIST_SUBDIR}/ \
${MASTER_SITES:S/%SUBDIR%/${MASTER_SITE_SUBDIR}/}

MASTER_SITE_OVERRIDE?= ${MASTER_SITE_BACKUP}

If I comment them out, # make fetch works, but if they're uncommented,
the blackslashes are required.

-- 
Denny Lin
Comment 4 Andrey A. Chernov freebsd_committer freebsd_triage 2009-11-06 05:55:08 UTC
State Changed
From-To: feedback->closed

Should be fixed in Makefile v1.67