Bug 140269

Summary: lang/ghc build failed by hs-ghc-paths install failed with "runghc: not found"
Product: Ports & Packages Reporter: ksmakoto
Component: Individual Port(s)Assignee: freebsd-haskell (Nobody) <haskell>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
140269.diff
none
patch-140269.txt none

Description ksmakoto 2009-11-04 10:10:01 UTC 
GHC(Glasgow Haskell Compiler, ports/lang/ghc) build failed by hs-ghc-paths install failed with "runghc: not found"

full build log ==> http://ja.pastebin.ca/1656372

How-To-Repeat: $ cd /usr/ports/lang/ghc
$ make BATCH=yes
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2009-11-04 14:50:37 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->haskell

Fix synopsis and assign.
Comment 2 Gabor Pali freebsd_committer freebsd_triage 2009-11-07 20:47:18 UTC 
Hello,

I have managed to find the cause of the problem, and  I created a
patch for fixing it.  Please, try the patch and let me know whether it
is working for you.

Regards,
:g
Comment 3 Gabor Pali freebsd_committer freebsd_triage 2009-11-07 21:01:10 UTC 
I re-send the patch, because I was messed in the last email.  This
will be okay hopefully.
Comment 4 Gabor Pali freebsd_committer freebsd_triage 2009-11-07 21:13:53 UTC 
State Changed
From-To: open->feedback

Awaiting feedback.
Comment 5 Gabor Pali freebsd_committer freebsd_triage 2009-11-07 21:36:10 UTC 
I send the patch in the body of the email:

Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/lang/ghc/Makefile,v
retrieving revision 1.80
diff -u -r1.80 Makefile
--- Makefile	2 Sep 2009 15:38:40 -0000	1.80
+++ Makefile	7 Nov 2009 20:38:48 -0000
@@ -181,7 +181,7 @@

 SLAVES_PREFIX=		${WRKDIR}/slaves_prefix
 SLAVES_WRKDIRPREFIX=	${WRKDIR}/slaves_wrkdirprefix
-SLAVES_MAKE_ARGS=	-DSLAVE PREFIX=${SLAVES_PREFIX}
WRKDIRPREFIX=${SLAVES_WRKDIRPREFIX}
+SLAVES_MAKE_ARGS=	-DSLAVE PREFIX=${SLAVES_PREFIX}
WRKDIRPREFIX=${SLAVES_WRKDIRPREFIX} PATH=${BOOT_DIR}/bin:${PATH}

 MAKE_ENV+=	PATH=${SLAVES_PREFIX}/bin:${PATH}
 CONFIGURE_ENV+=	PATH=${SLAVES_PREFIX}/bin:${PATH}
@@ -273,14 +273,14 @@

 .if defined(WITHOUT_HADDOCK)
 	@(cd ${PORTSDIR}/devel/hs-ghc-paths && \
-		${SETENV} PATH=${BOOT_DIR}/bin:${PATH} ${MAKE} ${SLAVES_MAKE_ARGS} install)
+		${MAKE} ${SLAVES_MAKE_ARGS} install)

 	@(cd ${PORTSDIR}/devel/hs-haddock && \
-		${SETENV} PATH=${BOOT_DIR}/bin:${PATH} ${MAKE} ${SLAVES_MAKE_ARGS} install)
+		${MAKE} ${SLAVES_MAKE_ARGS} install)
 .endif

 	@(cd ${PORTSDIR}/print/hs-hscolour && \
-		${SETENV} PATH=${BOOT_DIR}/bin:${PATH} ${MAKE} ${SLAVES_MAKE_ARGS} install)
+		${MAKE} ${SLAVES_MAKE_ARGS} install)
 .endif

 post-install:
Comment 6 Gabor Pali freebsd_committer freebsd_triage 2009-11-07 21:52:19 UTC 
Okay, some minor nits in the previously sent patch (sorry!):

_Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/lang/ghc/Makefile,v
retrieving revision 1.80
diff -u -r1.80 Makefile
--- Makefile	2 Sep 2009 15:38:40 -0000	1.80
+++ Makefile	7 Nov 2009 20:38:48 -0000
@@ -181,7 +181,7 @@

 SLAVES_PREFIX=		${WRKDIR}/slaves_prefix
 SLAVES_WRKDIRPREFIX=	${WRKDIR}/slaves_wrkdirprefix
-SLAVES_MAKE_ARGS=	-DSLAVE PREFIX=${SLAVES_PREFIX}
WRKDIRPREFIX=${SLAVES_WRKDIRPREFIX}
+SLAVES_MAKE_ARGS=	-DSLAVE PREFIX=${SLAVES_PREFIX}
WRKDIRPREFIX=${SLAVES_WRKDIRPREFIX} PATH=${BOOT_DIR}/bin:${PATH}

 MAKE_ENV+=	PATH=${SLAVES_PREFIX}/bin:${PATH}
 CONFIGURE_ENV+=	PATH=${SLAVES_PREFIX}/bin:${PATH}
@@ -273,14 +273,14 @@

 .if defined(WITHOUT_HADDOCK)
 	@(cd ${PORTSDIR}/devel/hs-ghc-paths && \
-		${SETENV} PATH=${BOOT_DIR}/bin:${PATH} ${MAKE} ${SLAVES_MAKE_ARGS} install)
+		${MAKE} ${SLAVES_MAKE_ARGS} install)

 	@(cd ${PORTSDIR}/devel/hs-haddock && \
-		${SETENV} PATH=${BOOT_DIR}/bin:${PATH} ${MAKE} ${SLAVES_MAKE_ARGS} install)
+		${MAKE} ${SLAVES_MAKE_ARGS} install)
 .endif

 	@(cd ${PORTSDIR}/print/hs-hscolour && \
-		${SETENV} PATH=${BOOT_DIR}/bin:${PATH} ${MAKE} ${SLAVES_MAKE_ARGS} install)
+		${MAKE} ${SLAVES_MAKE_ARGS} install)
 .endif

 post-install:
Comment 7 ksmakoto 2009-11-08 01:42:17 UTC 
Hello.

The patch works fine.
Thank you.
Comment 8 dfilter service freebsd_committer freebsd_triage 2009-11-08 19:40:15 UTC 
pgj         2009-11-08 19:40:06 UTC

  FreeBSD ports repository

  Modified files:
    lang/ghc             Makefile 
  Log:
  - Fix installation of hs-ghc-paths as slave port when build is launched in
    user mode.
  
  PR:             ports/140269
  Submitted by:   Makoto Kishimoto <ksmakoto(at)dd(dot)iij4u(dot)or(dot)jp>
  
  Revision  Changes    Path
  1.81      +4 -4      ports/lang/ghc/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 9 Gabor Pali freebsd_committer freebsd_triage 2009-11-08 19:51:23 UTC 
State Changed
From-To: feedback->closed

The patch has been committed, thank you for your report!