Bug 140649

Summary: [handbook] bad WITHOUT_MODULES example in handbook
Product: Documentation Reporter: Ben Kelly <ben>
Component: Books & ArticlesAssignee: freebsd-doc (Nobody) <doc>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   

Description Ben Kelly 2009-11-18 02:00:01 UTC
The handbook currently incorrectly suggests you can specify module subdirectories in WITHOUT_MODULES.  See the second tip on this page:

  http://www.freebsd.org/doc/en/books/handbook/kernelconfig-building.html

This is incorrect because the WITHOUT_MODULES logic in /usr/src/sys/modules/Makefile will only exclude items in the original SUBDIRS list.  Only the top level module directories are included in this list.

How-To-Repeat: Add the following to your /etc/make.conf:

  WITHOUT_MODULES=sound/driver/emu10k1

Build the kernel and see the emu10k1 module get built anyway.
Comment 1 Ben Kelly 2009-11-18 03:19:44 UTC
I forgot to mention this was initially reported by Gonzalo Nemmi.
(gnemmi gmail com)
Comment 2 Ben Kelly 2009-11-18 12:23:10 UTC
On current@ on 11/17/2009 Doug Barton suggested that WITHOUT_MODULES and =
MODULES_OVERRIDE should be documented in srcs.conf instead of make.conf:

"You can add to the mix the fact that options like modules_override and
without_modules are documented in make.conf(5) instead of in
src.conf(5) which is where (arguably) they should be."=
Comment 3 Pav Lucistnik freebsd_committer freebsd_triage 2009-12-14 14:13:40 UTC
State Changed
From-To: open->closed

I have edited the Handbook to reflect the reality.  Thanks for reporting this issue.
Comment 4 dfilter service freebsd_committer freebsd_triage 2009-12-14 14:23:56 UTC
pav         2009-12-14 14:23:24 UTC

  FreeBSD doc repository

  Modified files:
    en_US.ISO8859-1/books/handbook/kernelconfig chapter.sgml 
  Log:
  - WITHOUT_MODULES example does not work as advertised, modify to a version that
    will work
  
  PR:             docs/140649
  Reported by:    Ben Kelly <ben@wanderview.com>
  
  Revision  Changes    Path
  1.194     +2 -2      doc/en_US.ISO8859-1/books/handbook/kernelconfig/chapter.sgml
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"