Bug 140855

Summary: astro/gpstk: reading dual frequency NovaTel data, buffer overflow
Product: Ports & Packages Reporter: freebsd
Component: Individual Port(s)Assignee: Dmitry Marakasov <amdmi3>
Status: Closed FIXED    
Severity: Affects Only Me CC: gpstk
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch.shar
none
patch.shar none

Description freebsd 2009-11-25 03:10:04 UTC 
Reading dual frequency NovaTel OEM4 range data fails when number of SV's >=12 due
to insufficient buffer size.
ie. Two range records (L1 & L2) are produced for each SV which exceeds buffer allocated for 
12 SV

Fix: 

Increased size of buffer in NovatelData.hpp
Used sizeof and corrected determining if a buffer overrun will occur for OEM2 and
OEM4 receivers in NovatelData.cpp.

Patch files attached.

This patch should also work with gpstk v1.6
How-To-Repeat: 
Turn on debug in NovatelData.cpp, recompile and read appropriate data file with novaRINEX.
Comment 1 freebsd 2009-11-25 04:03:40 UTC 
Patch files not listed in Fix:

Please find shar file attached
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2009-11-25 04:07:32 UTC 
State Changed
From-To: open->feedback

Fix synopsis and ask for patch.  (One was not included.)
Comment 3 c.thomson 2009-11-25 04:09:07 UTC 
Patch files not listed in Fix:

Please find shar file attached
Comment 4 Edwin Groothuis freebsd_committer freebsd_triage 2009-11-25 20:56:50 UTC 
State Changed
From-To: feedback->open

Patches received
Comment 5 Dmitry Marakasov freebsd_committer freebsd_triage 2009-11-28 02:47:59 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->amdmi3

I'll take it.
Comment 6 Dmitry Marakasov freebsd_committer freebsd_triage 2009-11-28 15:14:54 UTC 
State Changed
From-To: open->closed

Committed. Thanks!