Bug 142785

Summary: [MAINTAINER] [PATCH] shells/fish Fix divide by zero bug
Product: Ports & Packages Reporter: Robert Farmer <rfarmer>
Component: Individual Port(s)Assignee: Dmitry Marakasov <amdmi3>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Robert Farmer 2010-01-13 15:00:07 UTC 
This port tries to do a floating point division by zero in C. On i386, this returns NaN and isn't a problem, but a NetBSD alpha user reports that it segfaults for him. Since this could be a problem on FreeBSD with other architectures (I don't have the hardware to test) and is bad code one way or another, patch it.

Reported by: chombee@lavabit.com
Fix by: Issac Dupree <ml@isaac.cedarswamps­tudios.org>

Fix: Please put this patch in the files folder as patch-util.c

Patch attached with submission follows:
Comment 1 Dmitry Marakasov freebsd_committer freebsd_triage 2010-01-13 17:37:46 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->amdmi3

I'll take it.
Comment 2 Dmitry Marakasov freebsd_committer freebsd_triage 2010-01-13 19:30:27 UTC 
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!
Comment 3 dfilter service freebsd_committer freebsd_triage 2010-01-13 19:30:33 UTC 
amdmi3      2010-01-13 19:30:19 UTC

  FreeBSD ports repository

  Modified files:
    shells/fish          Makefile 
  Added files:
    shells/fish/files    patch-util.c 
  Log:
  - Fix potential division by zero bug
  
  PR:             142785
  Submitted by:   Rob Farmer <rfarmer@predatorlabs.net> (maintainer)
  
  Revision  Changes    Path
  1.8       +1 -0      ports/shells/fish/Makefile
  1.1       +14 -0     ports/shells/fish/files/patch-util.c (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Robert Farmer 2010-01-13 19:34:52 UTC 
On Wed, Jan 13, 2010 at 11:31 AM, Dmitry Marakasov <amdmi3@amdmi3.ru> wrote=
:
> * Rob Farmer (rfarmer@predatorlabs.net) wrote:
>
>> >Synopsis: =A0 =A0 =A0 [MAINTAINER] [PATCH] shells/fish Fix divide by ze=
ro bug
>
> Note that the port fails to build in nondefaukt environements, namely
> with custom localbase:
>
> http://people.freebsd.org/~amdmi3/fish-1.23.1_1.log
>
> and WITHOUT_NLS:
>
> http://people.freebsd.org/~amdmi3/fish-nonls-1.23.1_1.log
>
> it'd be good to fix these as well.

I actually have a PR (# 142346) which fixes these things. It is
assigned to wxs@ right now.

--=20
Rob Farmer

>
> --
> Dmitry Marakasov =A0 . =A0 55B5 0596 FF1E 8D84 5F56 =A09510 D35A 80DD F9D=
2 F77D
> amdmi3@amdmi3.ru =A0..: =A0jabber: amdmi3@jabber.ru =A0 =A0http://www.amd=
mi3.ru
>
Comment 5 Dmitry Marakasov 2010-01-13 20:18:29 UTC 
* Rob Farmer (rfarmer@predatorlabs.net) wrote:

> I actually have a PR (# 142346) which fixes these things. It is
> assigned to wxs@ right now.

Great, thanks!

-- 
Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
amdmi3@amdmi3.ru  ..:  jabber: amdmi3@jabber.ru    http://www.amdmi3.ru