Bug 142916

Summary: Boot manager order differs between sysinstall(8) and sade(8)
Product: Base System Reporter: Jeremy Chadwick <freebsd>
Component: binAssignee: Bruce Cran <brucec>
Status: Closed FIXED    
Severity: Affects Only Me CC: kensmith
Priority: Normal    
Version: 8.0-STABLE   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Jeremy Chadwick 2010-01-17 19:40:05 UTC
	When using either sysinstall(8) or sade(8) to choose what kind of
	boot manager (Standard, FreeBSD Boot Manager, or None), the order of
	choices differs between the utilities.

	sysinstall(8) lists the order as Standard, BootMgr, None.  sade(8)
	lists the order as BootMgr, Standard, None.

	The order change was committed over a year ago to sysinstall(8) (see
	rev. 1.437 below), but not to sade(8).

	http://www.freebsd.org/cgi/cvsweb.cgi/src/usr.sbin/sysinstall/menus.c

Fix: Apply the change to sade(8)'s menus.c to keep things in sync.
	Attached is a patch based on the official sysinstall(8) diff.

	http://www.freebsd.org/cgi/cvsweb.cgi/src/usr.sbin/sysinstall/menus.c.diff?r1=1.436;r2=1.437

	Here we go:
How-To-Repeat: 	n/a
Comment 1 Bruce Cran freebsd_committer freebsd_triage 2010-03-02 23:21:18 UTC
Responsible Changed
From-To: freebsd-bugs->brucec

Take.
Comment 2 dfilter service freebsd_committer freebsd_triage 2010-04-21 20:07:47 UTC
Author: brucec
Date: Wed Apr 21 19:03:34 2010
New Revision: 207006
URL: http://svn.freebsd.org/changeset/base/207006

Log:
  Remove the reference to DD mode, and replace with Expert mode. Also, make
  sure the "Q = Finish" text is visible.
  Reword the boot manager screen to try and avoid confusion, and make the
  order of the menu items match that in sysinstall.
  
  PR:		bin/142916
  Submitted by:	Jeremy Chadwick <freebsd at jdc.parodius.com>
  Reviewed by:	randi
  Approved by:	rrs (mentor)
  MFC after:	1 week

Modified:
  head/usr.sbin/sade/disks.c
  head/usr.sbin/sade/menus.c

Modified: head/usr.sbin/sade/disks.c
==============================================================================
--- head/usr.sbin/sade/disks.c	Wed Apr 21 18:55:44 2010	(r207005)
+++ head/usr.sbin/sade/disks.c	Wed Apr 21 19:03:34 2010	(r207006)
@@ -202,10 +202,9 @@ static void
 print_command_summary(void)
 {
     mvprintw(14, 0, "The following commands are supported (in upper or lower case):");
-    mvprintw(16, 0, "A = Use Entire Disk   G = set Drive Geometry   C = Create Slice   F = `DD' mode");
-    mvprintw(17, 0, "D = Delete Slice      Z = Toggle Size Units    S = Set Bootable   | = Wizard m.");
-    mvprintw(18, 0, "T = Change Type       U = Undo All Changes     Q = Finish");
-    mvprintw(18, 47, "W = Write Changes");
+    mvprintw(16, 0, "A = Use Entire Disk   G = set Drive Geometry   C = Create Slice");
+    mvprintw(17, 0, "D = Delete Slice      Z = Toggle Size Units    S = Set Bootable   | = Expert m.");
+    mvprintw(18, 0, "T = Change Type       U = Undo All Changes     W = Write Changes  Q = Finish");
     mvprintw(21, 0, "Use F1 or ? to get more help, arrow keys to select.");
     move(0, 0);
 }

Modified: head/usr.sbin/sade/menus.c
==============================================================================
--- head/usr.sbin/sade/menus.c	Wed Apr 21 18:55:44 2010	(r207005)
+++ head/usr.sbin/sade/menus.c	Wed Apr 21 19:03:34 2010	(r207006)
@@ -92,24 +92,23 @@ DMenu MenuIPLType = {
 DMenu MenuMBRType = {
     DMENU_NORMAL_TYPE | DMENU_SELECTION_RETURNS,
     "overwrite me",		/* will be disk specific label */
-    "FreeBSD comes with a boot selector that allows you to easily\n"
+    "FreeBSD comes with a boot manager that allows you to easily\n"
     "select between FreeBSD and any other operating systems on your machine\n"
     "at boot time.  If you have more than one drive and want to boot\n"
-    "from the second one, the boot selector will also make it possible\n"
+    "from the second one, the boot manager will also make it possible\n"
     "to do so (limitations in the PC BIOS usually prevent this otherwise).\n"
-    "If you do not want a boot selector, or wish to replace an existing\n"
-    "one, select \"standard\".  If you would prefer your Master Boot\n"
-    "Record to remain untouched then select \"None\".\n\n"
-    "  NOTE:  PC-DOS users will almost certainly require \"None\"!",
-    "Press F1 to read about drive setup",
+    "If you have other operating systems installed and would like a choice when\n"
+    "booting, choose \"BootMgr\". If you would prefer to keep your existing\n"
+    "boot manager, select \"None\".\n\n",
+    "",
     "drives",
-    { { "BootMgr",	"Install the FreeBSD Boot Manager",
-	dmenuRadioCheck, dmenuSetValue, NULL, &BootMgr, 0, 0, 0, 0 },
-      { "Standard",	"Install a standard MBR (no boot manager)",
+    { { "Standard",	"Install a standard MBR (non-interactive boot manager)",
 	dmenuRadioCheck, dmenuSetValue, NULL, &BootMgr, '(', '*', ')', 1 },
-      { "None",		"Leave the Master Boot Record untouched",
+      { "BootMgr",	"Install the FreeBSD boot manager",
+	dmenuRadioCheck, dmenuSetValue, NULL, &BootMgr, '(', '*', ')', 0 },
+      { "None",		"Do not install a boot manager",
 	dmenuRadioCheck, dmenuSetValue, NULL, &BootMgr, '(', '*', ')', 2 },
-      { NULL, NULL, NULL, NULL, NULL, NULL, 0, 0, 0, 0 } },
+      { NULL, NULL, NULL, NULL, NULL, NULL, 0, 0, 0, 0 } }
 };
 #endif /* PC98 */
 #endif /* __i386__ */
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
Comment 3 Bruce Cran freebsd_committer freebsd_triage 2010-04-21 20:07:58 UTC
State Changed
From-To: open->patched

Fixed in HEAD.
Comment 4 dfilter service freebsd_committer freebsd_triage 2010-05-18 19:19:16 UTC
Author: brucec
Date: Tue May 18 18:19:06 2010
New Revision: 208274
URL: http://svn.freebsd.org/changeset/base/208274

Log:
  MFC r207006:
  
  Remove the reference to DD mode, and replace "Wizard" mode with "Expert" mode.
  Also, make sure the "Q = Finish" text is visible.
  Reword the boot manager screen to try and avoid confusion, and make the
  order of the menu items match that in sysinstall.
  
  PR:		bin/142916
  Submitted by:	Jeremy Chadwick <freebsd at jdc.parodius.com>
  Approved by:    rrs (mentor)

Modified:
  stable/8/usr.sbin/sade/disks.c
  stable/8/usr.sbin/sade/menus.c
Directory Properties:
  stable/8/usr.sbin/sade/   (props changed)

Modified: stable/8/usr.sbin/sade/disks.c
==============================================================================
--- stable/8/usr.sbin/sade/disks.c	Tue May 18 18:14:12 2010	(r208273)
+++ stable/8/usr.sbin/sade/disks.c	Tue May 18 18:19:06 2010	(r208274)
@@ -202,10 +202,9 @@ static void
 print_command_summary(void)
 {
     mvprintw(14, 0, "The following commands are supported (in upper or lower case):");
-    mvprintw(16, 0, "A = Use Entire Disk   G = set Drive Geometry   C = Create Slice   F = `DD' mode");
-    mvprintw(17, 0, "D = Delete Slice      Z = Toggle Size Units    S = Set Bootable   | = Wizard m.");
-    mvprintw(18, 0, "T = Change Type       U = Undo All Changes     Q = Finish");
-    mvprintw(18, 47, "W = Write Changes");
+    mvprintw(16, 0, "A = Use Entire Disk   G = set Drive Geometry   C = Create Slice");
+    mvprintw(17, 0, "D = Delete Slice      Z = Toggle Size Units    S = Set Bootable   | = Expert m.");
+    mvprintw(18, 0, "T = Change Type       U = Undo All Changes     W = Write Changes  Q = Finish");
     mvprintw(21, 0, "Use F1 or ? to get more help, arrow keys to select.");
     move(0, 0);
 }

Modified: stable/8/usr.sbin/sade/menus.c
==============================================================================
--- stable/8/usr.sbin/sade/menus.c	Tue May 18 18:14:12 2010	(r208273)
+++ stable/8/usr.sbin/sade/menus.c	Tue May 18 18:19:06 2010	(r208274)
@@ -92,24 +92,23 @@ DMenu MenuIPLType = {
 DMenu MenuMBRType = {
     DMENU_NORMAL_TYPE | DMENU_SELECTION_RETURNS,
     "overwrite me",		/* will be disk specific label */
-    "FreeBSD comes with a boot selector that allows you to easily\n"
+    "FreeBSD comes with a boot manager that allows you to easily\n"
     "select between FreeBSD and any other operating systems on your machine\n"
     "at boot time.  If you have more than one drive and want to boot\n"
-    "from the second one, the boot selector will also make it possible\n"
+    "from the second one, the boot manager will also make it possible\n"
     "to do so (limitations in the PC BIOS usually prevent this otherwise).\n"
-    "If you do not want a boot selector, or wish to replace an existing\n"
-    "one, select \"standard\".  If you would prefer your Master Boot\n"
-    "Record to remain untouched then select \"None\".\n\n"
-    "  NOTE:  PC-DOS users will almost certainly require \"None\"!",
-    "Press F1 to read about drive setup",
+    "If you have other operating systems installed and would like a choice when\n"
+    "booting, choose \"BootMgr\". If you would prefer to keep your existing\n"
+    "boot manager, select \"None\".\n\n",
+    "",
     "drives",
-    { { "BootMgr",	"Install the FreeBSD Boot Manager",
-	dmenuRadioCheck, dmenuSetValue, NULL, &BootMgr, 0, 0, 0, 0 },
-      { "Standard",	"Install a standard MBR (no boot manager)",
+    { { "Standard",	"Install a standard MBR (non-interactive boot manager)",
 	dmenuRadioCheck, dmenuSetValue, NULL, &BootMgr, '(', '*', ')', 1 },
-      { "None",		"Leave the Master Boot Record untouched",
+      { "BootMgr",	"Install the FreeBSD boot manager",
+	dmenuRadioCheck, dmenuSetValue, NULL, &BootMgr, '(', '*', ')', 0 },
+      { "None",		"Do not install a boot manager",
 	dmenuRadioCheck, dmenuSetValue, NULL, &BootMgr, '(', '*', ')', 2 },
-      { NULL, NULL, NULL, NULL, NULL, NULL, 0, 0, 0, 0 } },
+      { NULL, NULL, NULL, NULL, NULL, NULL, 0, 0, 0, 0 } }
 };
 #endif /* PC98 */
 #endif /* __i386__ */
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
Comment 5 Bruce Cran freebsd_committer freebsd_triage 2010-05-22 21:59:35 UTC
State Changed
From-To: patched->closed

Patch has been MFC'd to stable/8.