Bug 143164
| Summary: | [maintainer update] ports/vmailmgr -- fix package's logic for installing python API | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | mij <mij> | ||||||
| Component: | Individual Port(s) | Assignee: | Philip M. Gollucci <pgollucci> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | ||||||||
| Priority: | Normal | ||||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Responsible Changed From-To: freebsd-ports-bugs->pgollucci I'll take it. State Changed From-To: open->feedback the patch works, but we typically prefer to patch the configure.ac files and then USE_AUTOOLS to re-generate things, is that not possible here ?" sure, here we go State Changed From-To: feedback->open Submitter has fixed. State Changed From-To: open->closed Committed. Thanks! pgollucci 2010-02-11 20:25:44 UTC
FreeBSD ports repository
Modified files:
mail/vmailmgr Makefile pkg-plist
mail/vmailmgr/files patch-recursive.diff
Log:
- fix package's logic for installing python API
PR: ports/143164
Submitted by: Mij <mij@bitchx.it>
Revision Changes Path
1.14 +18 -3 ports/mail/vmailmgr/Makefile
1.2 +37 -22 ports/mail/vmailmgr/files/patch-recursive.diff
1.6 +22 -0 ports/mail/vmailmgr/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
|
I recently noticed that VMailMGR's logic for installing its python API is buggy. For locating the target directory, ./configure runs something like: local_cv_python_lib_dir=`$PYTHON -c "import sys;print sys.path[1]"` [..] pythonlibdir="$local_cv_python_lib_dir/vmailmgr" Besides possibly ending up installing in locations like /usr..python../lib-tk/, this code can yield a filename, e.g. /usr../setuptools-0.6c11-py2.6.egg . When this happens, it breaks the installation as soon as it tries to create/write the respective /vmailmgr folder in it. This bug is somewhat subtle, because it depends on what python components are installed in the system, and the order of them. The attached patch fixes such problem by enforcing to install in PYTHON_SITELIBDIR. For passing this value from make down to the package I add a --with-pythonapi=<loc> to the package's ./configure script. When set, <loc> points to the desired target location. When omitted, the python API is not installed. The port's Makefile determines whether to pass this value based on an user OPTION, defaulting disabled. When enabled, the python API is installed in PYTHON_SITELIBDIR. As a side note, the patch is big because autoconf generates vastly different code with respect to the original (5 years passed). Changes: * fix broken installation in some environments * add option for enabling/disabling python API * add MAKE_JOBS_SAFE=yes * bump portrevision