Bug 14330

Summary: [PATCH] fix clash between /usr/src/contrib/tcpdump/ppp.h and /usr/include/net/ppp_defs.h
Product: Base System Reporter: Tony Finch <dot>
Component: binAssignee: Peter Wemm <peter>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: 3.3-STABLE   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Tony Finch 1999-10-14 19:30:00 UTC 
cc -O -pipe -DHAVE_FCNTL_H=1 -DHAVE_NET_SLIP_H=1 -DTIME_WITH_SYS_TIME=1  -DHAVE_ETHER_NTOHOST=1 -DHAVE_SETLINEBUF=1 -DSTDC_HEADERS=1  -DRETSIGTYPE=void -DRETSIGVAL= -DHAVE_SOCKADDR_SA_LEN=1  -DHAVE_TM_GMTOFF=1 -DLBL_ALIGN=1 -DPPP -DHAVE_FDDI -g -I/usr/src/usr.sbin/tcpdump/tcpdump/../../../contrib/tcpdump/lbl   -c /usr/src/usr.sbin/tcpdump/tcpdump/../../../contrib/tcpdump/print-ppp.c
In file included from /usr/src/usr.sbin/tcpdump/tcpdump/../../../contrib/tcpdump/print-ppp.c:54:
/usr/src/usr.sbin/tcpdump/tcpdump/../../../contrib/tcpdump/ppp.h:18: warning: `PPP_ADDRESS' redefined
/usr/include/net/ppp_defs.h:40: warning: this is the location of the previous definition
/usr/src/usr.sbin/tcpdump/tcpdump/../../../contrib/tcpdump/ppp.h:19: warning: `PPP_CONTROL' redefined
/usr/include/net/ppp_defs.h:41: warning: this is the location of the previous definition
/usr/src/usr.sbin/tcpdump/tcpdump/../../../contrib/tcpdump/ppp.h:22: warning: `PPP_IP' redefined
/usr/include/net/ppp_defs.h:56: warning: this is the location of the previous definition
/usr/src/usr.sbin/tcpdump/tcpdump/../../../contrib/tcpdump/ppp.h:27: warning: `PPP_IPX' redefined
/usr/include/net/ppp_defs.h:59: warning: this is the location of the previous definition

How-To-Repeat: 
make buildworld
Comment 1 Sheldon Hearn freebsd_committer freebsd_triage 1999-10-15 10:06:34 UTC 
Responsible Changed
From-To: freebsd-bugs->peter

It's probably more appropriate for this to be resolved outside of 
the contrib directory. Over to Mr Wemm, pppd's most apparent  
maintainer.
Comment 2 Peter Wemm freebsd_committer freebsd_triage 2000-09-25 19:28:27 UTC 
Responsible Changed
From-To: peter->dec

dec is now maintainer
Comment 3 Peter Wemm freebsd_committer freebsd_triage 2000-09-25 19:28:54 UTC 
Responsible Changed
From-To: dec->peter

oops, wrong pr.
Comment 4 Peter Wemm freebsd_committer freebsd_triage 2001-12-10 20:35:46 UTC 
State Changed
From-To: open->closed

This isn't a problem on RELENG_4 or -current which have a newer 
tcpdump/libpcap.  RELENG_3 is essentially closed these days.