Bug 144303

Comment 1 Dmitry Marakasov 2010-03-04 12:51:52 UTC

Responsible Changed
From-To: freebsd-ports-bugs->amdmi3

I'll take it.

* Daniel Walter (sahne@0x90.at) wrote:

> echo x - x11-drivers/bsdmoted/pkg-descr
> sed 's/^X//' >x11-drivers/bsdmoted/pkg-descr << 'b4384606577f313d5ccb86a0d74f1cb8'
> XWii remote is an innovative hci developed by Nintendo. 
> XThis project intends to help FreeBSD users use wii remote as mouse. 
> XThis project is based on bthidd, developed by Maksim Yevmenkin 
> X<m_evmenkin@yahoo.com>, and information from http://www.wiili.org.
> X
> XWWW:   http://bsdmoted.sourceforge.net

It would be better to use http://sourceforge.net/projects/bsdmoted/
here, since http://bsdmoted.sourceforge.net is confusing and only
really useable for proceeding to the former page.

> X# New ports collection makefile for:   x11-drivers/bsdmoted
> X# Date created:                2010-02-25
> X# Whom:                        sahne <sahne@0x90.at>

We require full name in Whom:

> XPORTNAME=      bsdmoted

Tabs, not spaces should be used in Makefiles for indentation

> XPORTVERSION=   0.4.0
> X#PORTREVISION= 0
> X#PORTEPOCH=    0

Commented out stuff should be removed.

> XCATEGORIES=    x11-drivers

x11-drivers category is for real x11 drivers, which as I understand
this daemon is not. I guess more suitable category would be sysutils,
which is also a home for uhidd.

> X.include <bsd.port.pre.mk>
> X.include <bsd.port.post.mk>

Should be just .include <bsd.port.mk>

Also, the port doesn't install correctly with custom PREFIX/LOCALBASE, as
/usr/local is hardcoded in the Makefile. You should either:
- use ${REINPLACE_CMD} to change /usr/local to ${PREFIX}
- use MAKE_ARGS=	DESTDIR=${PREFIX}/sbin to override DESTDIR
- patch Makefile and change /usr/local to ${PREFIX} (literally). As
  PREFIX is passed to child make, it'll be correctly substituded.

-- 
Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
amdmi3@amdmi3.ru  ..:  jabber: amdmi3@jabber.ru    http://www.amdmi3.ru

Comment 3 Dmitry Marakasov 2010-03-04 13:23:16 UTC

State Changed
From-To: open->feedback

Ask for submitter fix.

Hi,

attached is the updated port, packed as a shar archive.

thanks for the suggestions.

regards

Daniel


On Thu, 4 Mar 2010, Dmitry Marakasov wrote:

> * Daniel Walter (sahne@0x90.at) wrote:
>
>> echo x - x11-drivers/bsdmoted/pkg-descr
>> sed 's/^X//' >x11-drivers/bsdmoted/pkg-descr << 'b4384606577f313d5ccb86a0d74f1cb8'
>> XWii remote is an innovative hci developed by Nintendo.
>> XThis project intends to help FreeBSD users use wii remote as mouse.
>> XThis project is based on bthidd, developed by Maksim Yevmenkin
>> X<m_evmenkin@yahoo.com>, and information from http://www.wiili.org.
>> X
>> XWWW:   http://bsdmoted.sourceforge.net
>
> It would be better to use http://sourceforge.net/projects/bsdmoted/
> here, since http://bsdmoted.sourceforge.net is confusing and only
> really useable for proceeding to the former page.
>
>> X# New ports collection makefile for:   x11-drivers/bsdmoted
>> X# Date created:                2010-02-25
>> X# Whom:                        sahne <sahne@0x90.at>
>
> We require full name in Whom:
>
>> XPORTNAME=      bsdmoted
>
> Tabs, not spaces should be used in Makefiles for indentation
>
>> XPORTVERSION=   0.4.0
>> X#PORTREVISION= 0
>> X#PORTEPOCH=    0
>
> Commented out stuff should be removed.
>
>> XCATEGORIES=    x11-drivers
>
> x11-drivers category is for real x11 drivers, which as I understand
> this daemon is not. I guess more suitable category would be sysutils,
> which is also a home for uhidd.
>
>> X.include <bsd.port.pre.mk>
>> X.include <bsd.port.post.mk>
>
> Should be just .include <bsd.port.mk>
>
> Also, the port doesn't install correctly with custom PREFIX/LOCALBASE, as
> /usr/local is hardcoded in the Makefile. You should either:
> - use ${REINPLACE_CMD} to change /usr/local to ${PREFIX}
> - use MAKE_ARGS=	DESTDIR=${PREFIX}/sbin to override DESTDIR
> - patch Makefile and change /usr/local to ${PREFIX} (literally). As
>  PREFIX is passed to child make, it'll be correctly substituded.
>
> -- 
> Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
> amdmi3@amdmi3.ru  ..:  jabber: amdmi3@jabber.ru    http://www.amdmi3.ru
>

Comment 5 Dmitry Marakasov 2010-04-14 16:28:34 UTC

State Changed
From-To: feedback->closed

New port added, with minor changes. Thanks!