Bug 144408

Summary: [patch] update makefs(8) (remove device option)
Product: Documentation Reporter: Enji Cooper <ngie>
Component: Books & ArticlesAssignee: Eitan Adler <eadler>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Enji Cooper freebsd_committer freebsd_triage 2010-03-02 01:40:04 UTC
device isn't a supported keyword in mtree(8) [makefs(8) references the device keyword]:

[root@garrcoop-fbsd /home/garrcoop]# mtree -k device
mtree: line 0: unknown keyword device

     -F specfile
           Use specfile as an mtree(8) `specfile' specification.

           If a specfile entry exists in the underlying file system, its per-
           missions and modification time will be used unless specifically
           overridden by the specfile.  An error will be raised if the type of
           entry in the specfile conflicts with that of an existing entry.

           In the opposite case (where a specfile entry does not have an entry
           in the underlying file system) the following occurs: If the spec-
           file entry is marked optional, the specfile entry is ignored.  Oth-
           erwise, the entry will be created in the image, and it is necessary
           to specify at least the following parameters in the specfile: type,
           mode, gname or gid, and uname or uid, device (in the case of block
                                                 ^^^^^^
           or character devices), and link (in the case of symbolic links).
           If time isn't provided, the current time will be used.  If flags
           isn't provided, the current file flags will be used.  Missing regu-
           lar file entries will be created as zero-length files.

This patch removes that reference.

Fix: See patch.

Patch attached with submission follows:
How-To-Repeat: n/a
Comment 1 Benedict Reuschling freebsd_committer freebsd_triage 2011-05-25 09:57:07 UTC
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I checked with NetBSD whether they have to fix that issue in their tree
as well. Apparently, their mtree has the 'device' definition:

http://netbsd.gw.com/cgi-bin/man-cgi?mtree++NetBSD-current

Question is: does it make sense to add it to our mtree as well?

Benedict Reuschling
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.8 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk3cxGMACgkQTSZQLkqBk0gSlACeIHoWrF8GgWa58K9JWe23RlbR
/pwAoJ+NyetacCf0yfywVC5YiASPikBc
=+bSs
-----END PGP SIGNATURE-----
Comment 2 Eitan Adler freebsd_committer freebsd_triage 2011-10-17 02:03:52 UTC
Responsible Changed
From-To: freebsd-doc->eadler

I'll take it.
Comment 3 dfilter service freebsd_committer freebsd_triage 2011-10-17 22:31:12 UTC
Author: eadler (ports committer)
Date: Mon Oct 17 21:31:03 2011
New Revision: 226482
URL: http://svn.freebsd.org/changeset/base/226482

Log:
  - remove device keyword from makefs manpage
  
  PR:		docs/144408
  Submitted by:	gcooper
  Approved by:	gjb
  Approved by:	sahil (mentor)
  MFC after:	1 week

Modified:
  head/usr.sbin/makefs/makefs.8

Modified: head/usr.sbin/makefs/makefs.8
==============================================================================
--- head/usr.sbin/makefs/makefs.8	Mon Oct 17 20:03:38 2011	(r226481)
+++ head/usr.sbin/makefs/makefs.8	Mon Oct 17 21:31:03 2011	(r226482)
@@ -134,8 +134,7 @@ and
 .Sy uname
 or
 .Sy uid ,
-.Sy device
-(in the case of block or character devices), and
+and
 .Sy link
 (in the case of symbolic links).
 If
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
Comment 4 Eitan Adler freebsd_committer freebsd_triage 2011-10-18 01:01:19 UTC
State Changed
From-To: open->patched

commited in r226482
Comment 5 Eitan Adler freebsd_committer freebsd_triage 2012-01-04 02:07:40 UTC
State Changed
From-To: patched->closed

MFCed in r229458 r229457 and r229456.