Bug 144828

Summary: [PATCH] Fix ABI abuse in textproc/libxml2
Product: Ports & Packages Reporter: Xin LI <delphij>
Component: Individual Port(s)Assignee: Xin LI <delphij>
Status: Closed FIXED    
Severity: Affects Only Me CC: gnome
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
libxml2.diff none

Description Xin LI freebsd_committer freebsd_triage 2010-03-17 19:50:00 UTC 
	libxml2 knows too much about zlib's internals.  With the upcoming
update, it would break.

	I'm thinking about making the -STABLE zlib use a different ABI but
the real fix is to use gzdirect() instead of twiddling with zlib internal
bits.

How-To-Repeat: 	Update base system zlib to 1.2.4 and everything using libxml2 to read
configuration would be broken.
Comment 1 Xin LI freebsd_committer freebsd_triage 2010-03-17 19:51:01 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->freebsd-gnome

Over to maintainer.
Comment 2 Jeremy Messenger 2010-03-17 20:04:42 UTC 
Approved! If you took the patch from somewhere (saw similar patch in its  
mailing list), please give a credit. Thanks!

Cheers,
Mezz


-- 
mezz7@cox.net  -  mezz@FreeBSD.org
FreeBSD GNOME Team
http://www.FreeBSD.org/gnome/  -  gnome@FreeBSD.org
Comment 3 dfilter service freebsd_committer freebsd_triage 2010-03-17 21:06:32 UTC 
delphij     2010-03-17 21:06:18 UTC

  FreeBSD ports repository

  Modified files:
    textproc/libxml2     Makefile 
  Added files:
    textproc/libxml2/files patch-xmlIO.c 
  Log:
  libxml2 knows too much about zlib internals.  Beginning from zlib 1.2.2.3
  the zlib authors has provided a 'gzdirect' function to detect whether the
  current gzFile descriptor is still providing a stream from uncompression,
  so use it instead of rolling own.
  
  The upcoming zlib 1.2.4 update will break the current libxml2 usage.
  
  Patch was the same as Mark Adler provided to libxml2 maintainers at:
  
          http://osdir.com/ml/svn-commits-list/2010-01/msg05723.html
  
  PR:             ports/144828
  Approved by:    mezz (freebsd-gnome@)
  
  Revision  Changes    Path
  1.163     +1 -1      ports/textproc/libxml2/Makefile
  1.3       +20 -0     ports/textproc/libxml2/files/patch-xmlIO.c (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Xin LI freebsd_committer freebsd_triage 2010-03-17 21:06:42 UTC 
State Changed
From-To: open->closed

Patch applied against CVS -HEAD.
Comment 5 Xin LI freebsd_committer freebsd_triage 2010-03-17 21:06:42 UTC 
Responsible Changed
From-To: freebsd-gnome->delphij

I have committed the patch.