Bug 14533

> >Number:         14533
> >Category:       bin
> >Synopsis:       pccardd improperly assigns irqs
> >Confidential:   no
> >Severity:       non-critical
> >Priority:       medium
> >Responsible:    freebsd-bugs
> >State:          open
> >Quarter:        
> >Keywords:       
> >Date-Required:
> >Class:          change-request
> >Submitter-Id:   current-users
> >Arrival-Date:   Mon Oct 25 22:00:01 PDT 1999
> >Closed-Date:
> >Last-Modified:
> >Originator:     Adam Wight
> >Release:        FreeBSD 4.0-CURRENT i386
> >Organization:
> >Environment:
> 
> >Description:
> 	pccardd sets the default irq mask for cards to the irq of the pcic
> instead of the configured irq that the resource file (pccard.conf) suggests.
> 

This is necessary to avoid many races for suspend/remove.

> 
> >Fix:
> Index: cardd.c
> ===================================================================
> RCS file: /usr/cvs/src/usr.sbin/pccard/pccardd/cardd.c,v
> retrieving revision 1.41
> diff -u -r1.41 cardd.c
> --- cardd.c     1999/08/28 01:17:35     1.41
> +++ cardd.c     1999/10/26 04:49:26
> @@ -559,7 +559,7 @@
>         }
>         strcpy(drv.name, drvp->kernel);
>         drv.unit = drvp->unit;
> -       drv.irqmask = 1 << sp->irq;
> +       drv.irqmask = 1 << sp->config->irq;
>         drv.flags = sp->config->flags;
>         if (sp->flags & MEM_ASSIGNED) {
>                 drv.mem = sp->mem.addr;
> 
> >Release-Note:
> >Audit-Trail:
> >Unformatted:
> 
> 
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe freebsd-bugs" in the body of the message
>

Comment 2 Warner Losh 2000-05-16 06:12:26 UTC

Responsible Changed
From-To: freebsd-bugs->imp

I think this has been corrected witht he MFPAO. 

Comment 3 Warner Losh 2001-06-04 18:17:26 UTC

State Changed
From-To: open->closed

No longer relevant with new interrupt passing mechanism.