Bug 146128

Summary: [PATCH]print/gv: update to 3.6.9
Product: Ports & Packages Reporter: bf <bf1783>
Component: Individual Port(s)Assignee: Sylvio Cesar Teixeira <sylvio>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff
none
gv_369_diff.txt
none
gv_369_diff_3.txt none

Description bf 2010-04-29 00:30:01 UTC

Fix: Patch attached with submission follows:
Comment 1 Sylvio Cesar Teixeira freebsd_committer freebsd_triage 2010-04-29 01:29:23 UTC
Responsible Changed
From-To: freebsd-ports-bugs->sylvio

I'll take it.
Comment 2 Sylvio Cesar Teixeira freebsd_committer freebsd_triage 2010-05-01 02:12:51 UTC
Hi

Error:

http://people.freebsd.org/~sylvio/gv-3.6.9.log

Can you fix it?
Comment 3 Sylvio Cesar Teixeira freebsd_committer freebsd_triage 2010-05-01 02:14:03 UTC
State Changed
From-To: open->feedback

- Waiting fix of submitter.
Comment 4 b. f. 2010-05-04 03:27:01 UTC
---------- Forwarded message ----------
From: "b. f." <bf1783@googlemail.com>
Date: Mon, 3 May 2010 22:21:49 -0400
Subject: Re: ports/146128: [PATCH]print/gv: update to 3.6.9
To: sylvio@freebsd.org
Cc: dinoex@freebsd.org

On 4/30/10, sylvio@freebsd.org <sylvio@freebsd.org> wrote:
> Synopsis: [PATCH]print/gv: update to 3.6.9
>
> State-Changed-From-To: open->feedback
> State-Changed-By: sylvio
> State-Changed-When: Sat May 1 01:14:03 UTC 2010
> State-Changed-Why:
> - Waiting fix of submitter.
>
> http://www.freebsd.org/cgi/query-pr.cgi?pr=146128
>


There are two problems here:

The first problem, with print/gv, is due to the fact that 3.6.9 added
UTF-8 support, when there is a Xaw3d that is built with
internationalization. However, the case when Xaw3d is built _without_
internationalization isn't handled properly, because in that case gv
isn't properly linked with libiconv.  This can be fixed with the
revised patch that I have attached.

The second problem is that internationalization in Xaw3d isn't handled
properly now in ports.  I've opened a PR to fix this:

http://www.freebsd.org/cgi/query-pr.cgi?pr=146278

The update to print/gv should be done _after_ this second problem with
Xaw3d is resolved.

I didn't notice this earlier because my Xaw3d, unlike the default
package you used, was built with internationalization.

Regards,
                   b.
Comment 5 Sylvio Cesar Teixeira freebsd_committer freebsd_triage 2010-05-09 16:28:49 UTC
Hi, new error:

http://people.freebsd.org/~sylvio/gv-3.6.9.log
Comment 6 b. f. 2010-05-09 17:13:45 UTC
On 5/9/10, Sylvio Cesar Teixeira <sylvio@freebsd.org> wrote:
> Hi, new error:
>
> http://people.freebsd.org/~sylvio/gv-3.6.9.log
>

Is this the second diff that I sent, with the addition of LIBS=-liconv
to CONFIGURE_ENV, and the added patch, files/patch-configure? If so,
can you send me a tarball of the tinderbox's print/gv directory, and
the config.log from the failed build?

Thanks,
                b.
Comment 7 b. f. 2010-05-10 02:08:06 UTC
On 5/9/10, b. f. <bf1783@googlemail.com> wrote:
> On 5/9/10, Sylvio Cesar Teixeira <sylvio@freebsd.org> wrote:
>> Hi, new error:
>>
>> http://people.freebsd.org/~sylvio/gv-3.6.9.log
>>
>
> Is this the second diff that I sent, with the addition of LIBS=-liconv
> to CONFIGURE_ENV, and the added patch, files/patch-configure? If so,
> can you send me a tarball of the tinderbox's print/gv directory, and
> the config.log from the failed build?
>
> Thanks,
>                 b.
>


Never mind: I was able to reproduce the problem (I didn't notice it
earlier because I've been using gcc45 for ports, and hence it doesn't
occur on my system), and make another patch, which I've attached.
Please try it instead.

b.
Comment 8 dfilter service freebsd_committer freebsd_triage 2010-05-16 20:45:11 UTC
sylvio      2010-05-16 19:45:03 UTC

  FreeBSD ports repository

  Modified files:
    print/gv             Makefile distinfo 
  Added files:
    print/gv/files       patch-configure 
  Log:
  - Update to 3.6.9
  
  PR:             ports/146128
  Submitted by:   bf <bf1783@gmail.com> (maintainer)
  
  Revision  Changes    Path
  1.67      +7 -2      ports/print/gv/Makefile
  1.22      +3 -3      ports/print/gv/distinfo
  1.1       +11 -0     ports/print/gv/files/patch-configure (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 9 Sylvio Cesar Teixeira freebsd_committer freebsd_triage 2010-05-16 20:45:35 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!