Bug 147074

The games/nexuiz port (with WITHOUT_[SDL_]CLIENT) fails with:

(...)
cc -MD -DPREFER_PRELOAD -I/usr/local/include -DLINK_TO_LIBJPEG -DDP_FS_BASEDIR='"/usr/local/share/nexuiz"' -Wall -Wold-style-definition -Wstrict-prototypes -
Wsign-compare -Wdeclaration-after-statement   -O2 -pipe -march=athlon -fno-strict-aliasing -fno-strict-aliasing -funroll-loops -c jpeg.c -o jpeg.o
jpeg.c:39:21: error: jpeglib.h: No such file or directory
jpeg.c:455: error: 'JPEG_EOI' undeclared here (not in a function)
jpeg.c:462: error: field 'pub' has incomplete type
jpeg.c:545: error: expected ')' before 'cinfo'
jpeg.c:547: error: expected ')' before 'cinfo'
jpeg.c:556: error: expected ')' before 'cinfo'
jpeg.c:568: error: expected ')' before 'cinfo'
jpeg.c:582: error: expected ')' before 'cinfo'
jpeg.c: In function 'JPEG_LoadImage_BGRA':
jpeg.c:598: error: storage size of 'cinfo' isn't known
jpeg.c:599: error: storage size of 'jerr' isn't known
jpeg.c:607: warning: implicit declaration of function 'jpeg_std_error'
jpeg.c:608: warning: implicit declaration of function 'jpeg_create_decompress'
jpeg.c:612: error: 'JPEG_ErrorExit' undeclared (first use in this function)
jpeg.c:612: error: (Each undeclared identifier is reported only once
jpeg.c:612: error: for each function it appears in.)
jpeg.c:613: warning: implicit declaration of function 'JPEG_MemSrc'
jpeg.c:614: warning: implicit declaration of function 'jpeg_read_header'
jpeg.c:615: warning: implicit declaration of function 'jpeg_start_decompress'
jpeg.c:636: warning: implicit declaration of function 'jpeg_finish_decompress'
jpeg.c:637: warning: implicit declaration of function 'jpeg_destroy_decompress'
jpeg.c:648: warning: implicit declaration of function 'jpeg_read_scanlines'
jpeg.c:599: warning: unused variable 'jerr'
jpeg.c:598: warning: unused variable 'cinfo'
jpeg.c: At top level:
jpeg.c:706: error: expected ')' before 'cinfo'
jpeg.c:714: error: expected ')' before 'cinfo'
jpeg.c:726: error: expected ')' before 'cinfo'
jpeg.c:737: error: expected ')' before 'cinfo'
jpeg.c:752: error: expected ')' before 'cinfo'
jpeg.c:759: error: expected ')' before 'cinfo'
jpeg.c:768: error: expected ')' before 'cinfo'
jpeg.c:773: error: expected ')' before 'cinfo'
jpeg.c: In function 'JPEG_SaveImage_preflipped':
jpeg.c:801: error: storage size of 'cinfo' isn't known
jpeg.c:802: error: storage size of 'jerr' isn't known
jpeg.c:822: error: 'JPEG_ErrorExit' undeclared (first use in this function)
jpeg.c:824: warning: implicit declaration of function 'jpeg_create_compress'
jpeg.c:825: warning: implicit declaration of function 'JPEG_FileDest'
jpeg.c:830: error: 'JCS_RGB' undeclared (first use in this function)
jpeg.c:832: warning: implicit declaration of function 'jpeg_set_defaults'
jpeg.c:833: warning: implicit declaration of function 'jpeg_set_quality'
jpeg.c:844: warning: implicit declaration of function 'jpeg_start_compress'
jpeg.c:853: warning: implicit declaration of function 'jpeg_write_scanlines'
jpeg.c:856: warning: implicit declaration of function 'jpeg_finish_compress'
jpeg.c:857: warning: implicit declaration of function 'jpeg_destroy_compress'
jpeg.c:802: warning: unused variable 'jerr'
jpeg.c:801: warning: unused variable 'cinfo'
jpeg.c: At top level:
jpeg.c:868: warning: 'struct jpeg_compress_struct' declared inside parameter list
jpeg.c:868: warning: its scope is only this definition or declaration, which is probably not what you want
jpeg.c: In function 'JPEG_try_SaveImage_to_Buffer':
jpeg.c:874: warning: implicit declaration of function 'JPEG_MemDest'
jpeg.c:877: error: dereferencing pointer to incomplete type
jpeg.c:878: error: dereferencing pointer to incomplete type
jpeg.c:879: error: dereferencing pointer to incomplete type
jpeg.c:879: error: 'JCS_RGB' undeclared (first use in this function)
jpeg.c:880: error: dereferencing pointer to incomplete type
jpeg.c:884: error: dereferencing pointer to incomplete type
jpeg.c:885: error: dereferencing pointer to incomplete type
jpeg.c:886: error: dereferencing pointer to incomplete type
jpeg.c:887: error: dereferencing pointer to incomplete type
jpeg.c:888: error: dereferencing pointer to incomplete type
jpeg.c:889: error: dereferencing pointer to incomplete type
jpeg.c:890: error: dereferencing pointer to incomplete type
jpeg.c:896: error: dereferencing pointer to incomplete type
jpeg.c:896: error: dereferencing pointer to incomplete type
jpeg.c:898: error: dereferencing pointer to incomplete type
jpeg.c:908: error: dereferencing pointer to incomplete type
jpeg.c: In function 'JPEG_SaveImage_to_Buffer':
jpeg.c:913: error: storage size of 'cinfo' isn't known
jpeg.c:914: error: storage size of 'jerr' isn't known
jpeg.c:930: error: 'JPEG_ErrorExit' undeclared (first use in this function)
jpeg.c:914: warning: unused variable 'jerr'
jpeg.c:913: warning: unused variable 'cinfo'
*** Error code 1

Stop in /usr/ports/workdir/usr/ports/games/nexuiz/work/Nexuiz/sources/darkplaces.
*** Error code 1

Stop in /usr/ports/workdir/usr/ports/games/nexuiz/work/Nexuiz/sources/darkplaces.
*** Error code 1

Stop in /usr/ports/workdir/usr/ports/games/nexuiz/work/Nexuiz/sources/darkplaces.
*** Error code 1

Stop in /usr/ports/games/nexuiz.
*** Error code 1

Stop in /usr/ports/games/nexuiz.

Fix: The port should depend on jpeg unconditionally. See the attached patch.


Patch attached with submission follows:
How-To-Repeat: # cd /usr/ports/games/nexuiz
# make config # (uncheck CLIENT and SDL_CLIENT)
# make