Bug 147463

Summary: [tools] [patch] Patch for tools/regression/lib/libc/string/Makefile
Product: Base System Reporter: Erik Cederstrand <erik>
Component: miscAssignee: Enji Cooper <ngie>
Status: Closed FIXED    
Severity: Affects Only Me CC: ngie
Priority: Normal Flags: ngie: mfc-stable10+
ngie: mfc-stable9-
ngie: mfc-stable8-
Version: 9.0-CURRENT   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Erik Cederstrand 2010-06-04 09:40:01 UTC
tools/regression/lib/libc/string/Makefile is, in contrast to most other tests, dependent on devel/libtap. Not having ltap library gives an error when running 'make'.

Warn the user what's wrong.

Fix: Apply the patch to get better error message.

cd /usr/ports/devel/libtap && make install

to install libtap and be able to build the test

Patch attached with submission follows:
How-To-Repeat: cd tools/regression/lib/libc/string/
make
Comment 1 Enji Cooper freebsd_committer freebsd_triage 2015-11-09 10:20:13 UTC
The test cases have been integrated into ATF in this commit and will be MFCed to stable/10:

------------------------------------------------------------------------
r290539 | ngie | 2015-11-07 23:53:31 -0800 (Sat, 07 Nov 2015) | 6 lines

Integrate tools/regression/lib/libc/string into the FreeBSD test suite
as lib/libc/tests/string

MFC after: 1 week
Sponsored by: EMC / Isilon Storage Division

I'm not sure if it's worth modifying stable/9's Makefile to emit that message though seeing as how stable/9 is getting close to being EOL.
Comment 2 Enji Cooper freebsd_committer freebsd_triage 2015-12-13 07:00:10 UTC
The integration work was merged to stable/10. Closing the bug (thank you for the submission!).