Bug 14760

Summary: bsd.port.mk: Speed-up for clean-depends
Product: Ports & Packages Reporter: reg <reg>
Component: Individual Port(s)Assignee: Satoshi Asami <asami>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description reg 1999-11-07 10:20:02 UTC
	This patch significantly speeds up package-depends and
	clean-depends, through recursively calling depencies then only
	sorting the list and only calling the clean target once.
Comment 1 Will Andrews 1999-11-07 22:13:46 UTC
On 07-Nov-99 reg@shale.csir.co.za wrote:
>>Number:         14760
>>Category:       ports
>>Synopsis:       bsd.port.mk: Speed-up for clean-depends
> 
>>Description:
> 
>       This patch significantly speeds up package-depends and
>       clean-depends, through recursively calling depencies then only
>       sorting the list and only calling the clean target once.

I was actually considering doing something like this for quite some time.
Thanks for your excellent work!! :-)

Satoshi, I've tested this and recommend that you commit it ASAP - this will
make a world of a difference in cleaning things up! (Not that my opinion
matters much, but I _AM_ a porter. ;)

Here's the results on my machine:

[ Before clean-depends patch submitted by reg@shale.csir.co.za ]:

<1 4171-0> (99-11-07 17:03:54) [root@shadow /usr/ports/x11/gnome]# make clean
===>  Cleaning for esound-0.2.15
===>  Cleaning for libaudiofile-0.1.9
===>  Cleaning for libtool-1.3.3
===>  Cleaning for libtool-1.3.3
===>  Cleaning for gnomeaudio-1.0.0
===>  Cleaning for gmake-3.77
===>  Cleaning for XFree86-3.3.5
===>  Cleaning for gnomelibs-1.0.53
===>  Cleaning for esound-0.2.15
===>  Cleaning for libaudiofile-0.1.9
===>  Cleaning for libtool-1.3.3
===>  Cleaning for libtool-1.3.3
===>  Cleaning for ORBit-0.5.0
===>  Cleaning for gettext-0.10.35
===>  Cleaning for libtool-1.3.3
===>  Cleaning for glib-1.2.6
===>  Cleaning for libtool-1.3.3
===>  Cleaning for gmake-3.77
===>  Cleaning for libtool-1.3.3
===>  Cleaning for gmake-3.77
===>  Cleaning for libtool-1.3.3
===>  Cleaning for imlib-1.9.8
===>  Cleaning for gmake-3.77
===>  Cleaning for libtool-1.3.3
===>  Cleaning for giflib-4.1.0
===>  Cleaning for gmake-3.77
===>  Cleaning for libtool-1.3.3
===>  Cleaning for XFree86-3.3.5
===>  Cleaning for jpeg-6b
===>  Cleaning for png-1.0.3
===>  Cleaning for tiff-3.5.1
===>  Cleaning for jpeg-6b
===>  Cleaning for gtk-1.2.6
===>  Cleaning for gettext-0.10.35
===>  Cleaning for libtool-1.3.3
===>  Cleaning for glib-1.2.6
===>  Cleaning for libtool-1.3.3
===>  Cleaning for libtool-1.3.3
===>  Cleaning for XFree86-3.3.5
===>  Cleaning for XFree86-3.3.5
===>  Cleaning for xpm-3.4k
===>  Cleaning for XFree86-3.3.5
===>  Cleaning for XFree86-3.3.5
===>  Cleaning for gnomemedia-1.0.51
===>  Cleaning for gmake-3.77
[continues for several more pages..]
===>  Cleaning for libtool-1.3.3
===>  Cleaning for XFree86-3.3.5
===>  Cleaning for XFree86-3.3.5
===>  Cleaning for xpm-3.4k
===>  Cleaning for XFree86-3.3.5
===>  Cleaning for XFree86-3.3.5
===>  Cleaning for gnome-1.0.53
<1 4172-0> (99-11-07 17:07:48) [root@shadow /usr/ports/x11/gnome]#

[after clean-depends patch:]
<1 4177-0> (99-11-07 17:08:51) [root@shadow /usr/ports/x11/gnome]# make clean
===>  Cleaning for esound-0.2.15
===>  Cleaning for gnomeaudio-1.0.0
===>  Cleaning for gnomemedia-1.0.51
===>  Cleaning for libaudiofile-0.1.9
===>  Cleaning for gnomepim-1.0.55
===>  Cleaning for ORBit-0.5.0
===>  Cleaning for gettext-0.10.35
===>  Cleaning for glib-1.2.6
===>  Cleaning for gmake-3.77
===>  Cleaning for libglade-0.7
===>  Cleaning for libgtop-1.0.6
===>  Cleaning for libtool-1.3.3
===>  Cleaning for gnomegames-1.0.51
===>  Cleaning for electriceyes-0.3.11
===>  Cleaning for giflib-4.1.0
===>  Cleaning for imlib-1.9.8
===>  Cleaning for jpeg-6b
===>  Cleaning for png-1.0.3
===>  Cleaning for tiff-3.5.1
===>  Cleaning for xpm-3.4k
===>  Cleaning for gnomeobjc-1.0.40
===>  Cleaning for guile-1.3
===>  Cleaning for python-1.5.2
===>  Cleaning for tcl-8.2.0
===>  Cleaning for gnumeric-0.41
===>  Cleaning for gnomeutils-1.0.50
===>  Cleaning for gnomenetwork-1.0.2
===>  Cleaning for ggv-0.70
===>  Cleaning for ghostscript-5.10
===>  Cleaning for gnomeprint-0.10
===>  Cleaning for gsfonts-5.10
===>  Cleaning for gnomeadmin-1.0.3
===>  Cleaning for gnomecontrolcenter-1.0.51
===>  Cleaning for gtop-1.0.5
===>  Cleaning for libxml-1.7.3
===>  Cleaning for libghttp-1.0.4
===>  Cleaning for gnomemc-4.5.40
===>  Cleaning for p5-type1inst-0.6.1
===>  Cleaning for gtk-1.2.6
===>  Cleaning for tk-8.2.0
===>  Cleaning for XFree86-3.3.5
===>  Cleaning for gnomecore-1.0.53
===>  Cleaning for gnomelibs-1.0.53
===>  Cleaning for gnome-1.0.53
<1 4178-0> (99-11-07 17:09:03) [root@shadow /usr/ports/x11/gnome]# 

Can you say.. WOW! So much faster, especially with those HUGE meta-ports like
x11/gnome, x11/kde, et cetera.. and no more repetition ad nauseum. :-)

--
Will Andrews <andrews@technologist.com>
GCS/E/S @d- s+:+>+:- a--->+++ C++ UB++++ P+ L- E--- W+++ !N !o ?K w---
?O M+ V-- PS+ PE++ Y+ PGP+>+++ t++ 5 X++ R+ tv+ b++>++++ DI+++ D+ 
G++>+++ e->++++ h! r-->+++ y?
Comment 2 Joseph Koshy freebsd_committer freebsd_triage 1999-11-10 04:40:04 UTC
Responsible Changed
From-To: freebsd-ports->asami

Port-meister's area. 
Comment 3 Satoshi Asami freebsd_committer freebsd_triage 2000-03-03 01:55:39 UTC
State Changed
From-To: open->closed

Thanks, committed!