Summary: | [patch] powerpc64 support for x11-toolkits/gtk20 | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Nathan Whitehorn <nwhitehorn> | ||||
Component: | Individual Port(s) | Assignee: | freebsd-gnome (Nobody) <gnome> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Only Me | ||||||
Priority: | Normal | ||||||
Version: | Latest | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
Description
Nathan Whitehorn
2010-06-08 20:40:00 UTC
Responsible Changed From-To: freebsd-ports-bugs->gnome Over to maintainer (via the GNATS Auto Assign Tool) Hello, Is the following part needed? Because it is also in bsd.port.mk:1208. It is a bit double doing it again in the port. # Get the architecture .if !defined(ARCH) ARCH!= ${UNAME} -p .endif -Koop On Fri, 11 Jun 2010 23:05:32 +0200 Koop Mast <kwm@FreeBSD.org> wrote: > Hello, > > Is the following part needed? Because it is also in bsd.port.mk:1208. > It is a bit double doing it again in the port. > > # Get the architecture > .if !defined(ARCH) > ARCH!= ${UNAME} -p > .endif > > -Koop > It does not seem so. I had just blindly copied the architecture detection code out of the xorg-server Makefile. You have to move the conditional until after the .include <bsd.port.pre.mk> for it to work, though, since ARCH isn't defined before that. -Nathan kwm 2010-06-14 08:14:54 UTC FreeBSD ports repository Modified files: x11-toolkits/gtk20 Makefile Added files: x11-toolkits/gtk20/files extra-arch-powerpc64 Log: Fix the build on powerpc64. Due to a flaw in binutils 2.15, function names can conflict with ELF assembler directives on PPC64 systems. As a result, it is not possible to have functions named things like 'text' and 'data', one of which GTK 2.0 has. PR: ports/147699 Submitted by: nwhitehorn@ Revision Changes Path 1.246 +4 -0 ports/x11-toolkits/gtk20/Makefile 1.1 +20 -0 ports/x11-toolkits/gtk20/files/extra-arch-powerpc64 (new) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org" State Changed From-To: open->closed Committed thanks! |