Bug 147796

Summary: [patch] device smbus missing from ipmi(4) synopsys section
Product: Documentation Reporter: Enji Cooper <ngie>
Component: Books & ArticlesAssignee: freebsd-doc (Nobody) <doc>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Enji Cooper freebsd_committer freebsd_triage 2010-06-11 20:50:01 UTC 
Tried kldload(8)'ing ipmi(4) and it failed siting this in the dmesg:

KLD ipmi.ko: depends on smbus - not available or version mismatch
linker_load_file: Unsupported file type

I build and installed the i2c/smbus module and voila:

$ kldstat -v | grep ipmi
 8    1 0xffffffff80e17000 2cc      ipmi_linux.ko (/boot/TAMESHI_CURRENT.r206173/ipmi_linux.ko)
		229 ipmi_linux
 9    1 0xffffffff80e18000 6dc4     ipmi.ko (/boot/TAMESHI_CURRENT.r206173/ipmi.ko)
		234 smbus/ipmi_smbus
		233 pci/ipmi_pci
		232 pci/ipmi2_pci
		231 isa/ipmi_isa
		230 acpi/ipmi_acpi

Fix: See attached patch.

Patch attached with submission follows:
How-To-Repeat: Don't build kernel with smbus(4), but build with ipmi(4) support. If built via modules, then ipmi will fail to load.
Comment 1 John Baldwin freebsd_committer freebsd_triage 2010-06-14 13:41:38 UTC 
> Don't build kernel with smbus(4), but build with ipmi(4) support. If built 
> via modules, then ipmi will fail to load.

Actually, if you have an smbus.ko around (which you do by default unless you 
use NO_MODULES=yes or MODULES_OVERRIDE), it will autoload smbus.ko and work 
fine.  Also, if you use 'device ipmi' without 'device smbus' in your config, 
it will build fine (it just won't support IPMI SSIF devices that use smbus).  
For that reason, I don't think this patch is needed (and is in fact wrong as 
you can support 90+% of IPMI BMC's without 'device smbus').

-- 
John Baldwin
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2010-06-15 02:31:33 UTC 
State Changed
From-To: open->closed

jhb seems to think this is the wrong approach.