Bug 147956

Summary: emulators/wine: add missing dependency p5-XML-LibXML
Product: Ports & Packages Reporter: Kevin Lo <kevlo>
Component: Individual Port(s)Assignee: Gerald Pfeifer <gerald>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Kevin Lo freebsd_committer freebsd_triage 2010-06-18 04:40:01 UTC 
There is a missing dependency for winemaker

Fix: Add p5-XML-LibXML dependency.

Patch attached with submission follows:
How-To-Repeat: # winemaker --lower-uppercase update.vcproj
Winemaker 0.7.4
Copyright 2000 Francois Gouget <fgouget@codeweavers.com> for CodeWeavers
Copyright 2004 Dimitrie O. Paun
Copyright 2009 André Hentschel
Can't locate XML/LibXML.pm in @INC (@INC
contains: /usr/local/lib/perl5/5.10.1/BSDPAN /usr/local/lib/perl5/site_perl/5.10.1/mach /usr/local/lib/perl5/site_perl/5.10.1 /usr/local/lib/perl5/5.10.1/mach /usr/local/lib/perl5/5.10.1 .) at /usr/local/bin/winemaker line 849.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2010-06-18 04:40:11 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->gerald

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 gerald 2010-06-21 22:04:17 UTC 
I don't think the patch is correct -- you are only requesting a
BUILD dependency here, where I assume you want to use winemaker
after installation?
                                                                                
There is no build issue as far as I can tell, and I am wondering whether 
to actually remove winemaker from the installed version of this package
to avoid having to add another dependency which is not used otherwise.
                                                                                
Do you see a strong need to have winemaker installed?  Any other options
to address this?

Gerald
Comment 3 dfilter service freebsd_committer freebsd_triage 2010-07-05 21:09:25 UTC 
gerald      2010-07-05 20:09:12 UTC

  FreeBSD ports repository

  Modified files:
    emulators/wine       Makefile 
  Log:
  Add a run-time dependency on p5-XML-LibXML which is required by the
  winemaker tool.
  
  PR:             147956
  Submitted by:   kevlo
  Feature safe:   yes
  
  Revision  Changes    Path
  1.338     +2 -0      ports/emulators/wine/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Gerald Pfeifer freebsd_committer freebsd_triage 2010-07-05 21:10:58 UTC 
State Changed
From-To: open->closed

I just committed an updated variation of your patch; thanks for bringing 
this to my attention!  (This transitively adds another two ports on top, 
p5-XML-NamespaceSupport and p5-XML-SAX, so it's not exactly cheap, and I 
am considering making this into an option possibly.)
Comment 5 dfilter service freebsd_committer freebsd_triage 2010-07-11 21:55:16 UTC 
gerald      2010-07-11 20:50:59 UTC

  FreeBSD ports repository

  Modified files:
    emulators/wine       Makefile 
  Log:
  Add a new option WINEMAKER to attract the extensive Perl dependencies
  that are required to fully support the winemaker tool.  This makes the
  dependencies I added to address PR 147956 optional and off by default
  as not to burden the vast majority of users of this port unnecessarily.
  
  PR:             147956
  Requested by:   Alex Kozlov <spam@rm-rf.kiev.ua>
  Feature safe:   yes
  
  Revision  Changes    Path
  1.341     +6 -2      ports/emulators/wine/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"